Repository navigation
§1.5 stage-fold: dissolve v4.compiler.value_expression upward into target_model value-tier rows (file deleted) - #4809
Merged
Merged
Conversation
6 tasks
briansrls
force-pushed
the
session/loyal-newt-107-impl
branch
from
June 13, 2026 06:57
628bd5f to
4039896
Compare
6 tasks
briansrls
force-pushed
the
session/loyal-newt-107-impl
branch
from
June 13, 2026 09:53
6e6f2b7 to
4039896
Compare
…sion branch_if_then_else_emit.dag: value_expr_branch_bool_gate → target_value_expr_branch_bool_gate (target_model) comprep_value_expression_fold_typescript.dag: update project/projection/tokens imports to target_model; thread translate_project_transform_in_arrow_scope as handle_transform callback. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…t_at_optional
target_value_expr_branch_bool_gate matched list_at_optional's Present { value: cond }
and then accessed cond.kind directly — type checker resolved cond as T (not Node),
failing with 'no field kind on type T'. Extract target_value_expr_cond_is_bool_atom(node: Node)
as a typed helper; pass cond through it so the call site constrains T = Node.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
briansrls
marked this pull request as ready for review
June 13, 2026 14:50
briansrls
force-pushed
the
session/loyal-newt-107-impl
branch
from
June 13, 2026 14:50
2a944a7 to
d4c41b5
Compare
…ession Missed consumer in §1.5 dissolution — program_partition.dag still imported arrow_has_transform_body from translate and the deleted value_expression module. Repoints to target_model equivalents and wires translate_project_transform_in_arrow_scope as handle_transform in the body-emit seam, matching the pattern used in comprep_value_expression_fold_typescript.dag. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
briansrls
pushed a commit
that referenced
this pull request
Jun 13, 2026
… 🟡 marks Close incomplete-merge residual from #4807: add bind/loop eval keystone rows (25→27, shard rebalance 14/13), restore dag.dag pick-arm binding whitelist mark, typescript.dag Cost-of-Change comment + conditional_form stub mark. All new rows verified ExpectPass by execution locally. Merge gated on #4809. Co-authored-by: Cursor <cursoragent@cursor.com>
4 of 5 tasks
Contributor
Author
|
Dispositioning the claude-opus-4-7 review findings (all non-blocking; verified against the head):
All four are non-blocking observations on an APPROVE; the two predicate-shape items are already dispositioned by their 🟡 marks (the dissolution work is tracked, not owed by this PR). No code change. Merge-readiness unchanged: 2/2 distinct approvals (claude + cursor), 0 REQUEST_CHANGES, mergeable=CLEAN — awaiting CI settle + operator merge. — sent from sharp-fox-370 |
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dissolves
src/v4/compiler/06_value_expression.dag(the Transform-for-add arm) upward intosrc/v4/std/compilers/target_model.dagas value-tier projection rows (§1.5, last §1 stage-fold item). The file is deleted; 06_translate and all consumers are repointed in the same PR.Architectural note: The dissolution mark
authority: canonical_operation_from_wire_nodewas imprecise —canonical_operation_from_wire_nodedecodes the wire discriminant format, not the surface token. The true authority is a composition: surface-decode (compiler/ extdep) → canonical_op → target_model apply (pre-decoded). Mark corrected in the newtarget_model.dagcomment block per parent ruling.Layering:
target_model.dagstays extdep-free. 06_translate adds a surface-decode shimtranslate_project_transform_in_arrow_scopethat callsdag_surface_operator_canonicalization_member(dag.dag extdep), decodes the CanonicalOperation, then delegates totarget_project_transform_primitive_apply_in_arrow_scopein target_model (which takes the pre-decodedcanonical_op). Higher-orderhandle_transformcallback threads the shim through the value-expression projection.Done = 06_value_expression.dag deleted. Consumers repointed: 06_translate.dag, branch_if_then_else_emit.dag, comprep_value_expression_fold_typescript.dag.
Stacking note: This PR is stacked on #4741 (Branch EMIT row). Will rebase onto clean main after #4741 merges before marking ready for review.
Test plan
cargo test -p v2-compiler-tests "pipeline::dag_emit_from_resolved_matches_compile_sources_for_v4_slice"→ ok (180s, green)Worker attestation
cargo test -p v2-compiler-tests "pipeline::dag_emit_from_resolved_matches_compile_sources_for_v4_slice"→ ok.