Repository navigation
label-hygiene(F1b): rename grounding_pilot → grounding_inhabitance_mirror (live probe, not delete) - #4756
Merged
Conversation
Rename remaining pilot-local bindings in int_literal_ranges tests and grounding_engine module docs after grounding_pilot → grounding_inhabitance_mirror. Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
changed the title
briansrls
marked this pull request as ready for review
June 12, 2026 17:52
Fix fmt check failures in grounding_engine, int_literal_ranges, and int_literal_cardinality_test that blocked CI on PR #4756. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
CI investigation (
|
| Job | Root cause |
|---|---|
v4_lens_gate |
Hit timeout-minutes: 20 during substrate equivalence perturb: type-head flip… — prior C9 witnesses all returned true |
v4_lens_ci |
Same 20m wall during affected-testgen perturb phase — batch-green witnesses (6/6) already passed |
ci |
Aggregator fail-closed cascade because the two lens jobs were cancelled |
fmt, ci_floor, ci_floor_emit, ci_floor_parity, affected, and the other gates all passed on the first run. No remaining grounding_pilot / rust_pilot_primitives symbols in the tree.
Action taken: reran the failed jobs on workflow run 27433331581 (no code change warranted). Watching for green.
— sent from merry-crab-479
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Label-hygiene F1b disposition for
src/v3/grounding_pilotand the grounding-centeredpilot_family (census, PR #4749).Decision: RENAME, not DELETE. Evidence:
v3-grounding-enginepath-depends on the crate; usesRUST_INHABITANCE_MIRRORfor Phase-2 row parity against the loaded Dag.github/references togrounding_pilotCargo.tomlmembergrounding_engineuntil substrate rows are structurally walkable (dissolution trigger unchanged)Renames (pilot_ family only, per F1b scope):
grounding_pilot→grounding_inhabitance_mirror(v3-grounding-inhabitance-mirror)rust_pilot_primitives→rust_grounding_primitives(+ bootstrap regen)RUST_PILOT_PRIMITIVES→RUST_INHABITANCE_MIRROR,DAG_PILOT_TYPES→DAG_INHABITANCE_TYPESgrounding_enginePilot*import aliases →Mirror*Out of scope (independent
pilot_uses, left for other lanes): E-5 emit-harness tests (rust_pilot_source_passes_*),v4_roster_pilot_*,anthropic_operations_messages_pilot_present, v4 corpusunified_corpus_eval_pilot_*.Did not touch files in open PRs #4741/#4747.
Test plan
cargo test -p v3-grounding-inhabitance-mirror -p v3-grounding-engine— 20/20 passcargo test -p v3-compiler rust_grounding_primitives— 3/3 passcargo test -p v3-compiler --lib int128_witness_matches_i128_grounding— passcargo run -p v3-compiler --features bootstrap-regen-fresh --bin regen_bootstrap -- --verify— committed snapshots match