Repository navigation
dissolve: inline fold algebra scaffolding after #4736 generic instantiation - #4739
Merged
Merged
Conversation
briansrls
marked this pull request as ready for review
June 12, 2026 15:38
Merged
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dissolves two 🟡 bootstrap-limitation marks whose dissolve-on (
node://adhoc-f581ce40-042, landed via #4736) has fired. Inline named algebra step fns back into struct literals and delete the scaffolding (−28 net LOC).03_name_resolve.dag:named_exports_topdown_{init,child_context,step}inlined intonamed_exports_topdown_algebra()NodeFoldTopDownliteral.bounded_lattice_completeness.dag:infer_partial_bounded_lattice_instances_fold_{init,step}inlined intopartial_bounded_lattice_instances_in_treeNodeFoldliteral. Dissolve-on condition (b) verified:List<Node>from[]/[n0]in anonymous init body type-checks inline. Step usesfold_list_right(substrate equivalent to builtinfold+list_snoc_item; builtinfoldis not in scope inside nested struct-literal lambdas).Mechanical refactor only — no behavior change.
Test plan
cargo test -p v2-compiler-tests generic_instantiation— 5 passed (incl.v4_name_resolve_compiles_with_fold_list_dissolution,v4_nodefold_topdown_inline_algebra_compiles_and_runs)ci_floor_emitprobe (v4-m1-rust-emit-probe.sh) — 474 files emitted, 0 diagnosticsci_floor_emit,v4_lens_gate,v4_lens_ci)