Repository navigation
docs: restore deleted modeling rubric + tighten 🟡-debt marking, boundary references, and stale-scope drift - #4650
Merged
Merged
Conversation
…dary wording Restores docs/modeling-discipline.md and docs/modeling/grounding-worked-examples.md (deleted in the #4192 visibility flip while still cited as enforcement authority by INVARIANTS.md and live .dag marks — the gap that let PR #4627's dissolution findings through review), with retired-ledger refs re-pointed to PR review / dashboard work items and a #4627 worked example added to Practice 10. Tightens the marking discipline so 🟡 records debt and never authorizes it: PRs enumerate new 🟡s, each needs a bound dissolution plan, and the default review posture is debt-negative (INVARIANTS hand-rolled-derived-operation shape + modeling-discipline Calibration). Adds the references-not-imports P2 problem shape (target atoms compared literally in compiler/ code are boundary violations; a new file under src/v4/compiler/ is a default-block finding), the M8 predicate-dissolution mechanical trigger, and the M9 operations extension (a hand-rolled fold whose accumulator coincides with an existing carrier IS that carrier). Fixes drift: THESIS facet-4 / DIRECTION-CHECKLIST H3 / SELF_HOSTING.md still named the deleted ci.dag as live scope; annotates remaining references to deleted subdocs as historical. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… gate) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ught post-restore) in Practice 10 worked example Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…m, annotate retired DECISIONS.md cites, ground the Shape-B beachhead description Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
Addressed the composer-2.5 REQUEST_CHANGES in 006a8bd — all three findings verified real and fixed:
— sent from smart-wren-720 |
…rite-graph) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
briansrls
pushed a commit
that referenced
this pull request
Jun 11, 2026
…n_named_param_bindings dissolve-on Practice 10 compliance for #4650: eval_wave1_argument_binding_key and body_producer param-ref sites now carry consumer:arrow-domain-named-param-binding-accessor marks bound to node://adhoc-5edb46b5-841, dissolve-on node_query arrow_domain_named_param_bindings (#4627 rebase). No behavior change. Co-authored-by: Cursor <cursoragent@cursor.com>
Merged
2 of 4 tasks
briansrls
added a commit
that referenced
this pull request
Jun 11, 2026
…P add for eval callee dispatch (#4646) * WIP: COMPREP source-bridge (resolve→body_producer): wire resolved MVP add thr * WIP: COMPREP source-bridge (resolve→body_producer): wire resolved MVP add thr * fix(comprep #4646): fold duplicate diagnostic import + add P5 disposition tags on bridge scaffold Address claude REQUEST_CHANGES: merge duplicate Accepted/Rejected imports in comprep_add_body_producer.dag; mark the MVP1 flat-index bridge helpers, is_* atom predicates, and eval_callee_admits_body_dispatch with explicit 🟡 gated dissolve-on blocks (bind node://adhoc-9a72d4fb-8c2) so the debt removed from 05_eval is not laundered into ungated body_producer debt. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(comprep #4646): restore P5 disposition tag on eval_node_is_arrow Address composer-2.5 REQUEST_CHANGES: the predicate-dissolution receipt above eval_node_is_arrow was removed with eval_wave1_add_* but the helper remains in the eval_transform_node fail-closed arm; restore explicit gated block. Co-authored-by: Cursor <cursoragent@cursor.com> * docs(comprep #4646): bound 🟡 on param_x/y accessors names arrow_domain_named_param_bindings dissolve-on Practice 10 compliance for #4650: eval_wave1_argument_binding_key and body_producer param-ref sites now carry consumer:arrow-domain-named-param-binding-accessor marks bound to node://adhoc-5edb46b5-841, dissolve-on node_query arrow_domain_named_param_bindings (#4627 rebase). No behavior change. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Restores the two enforcement docs deleted in the #4192 public-visibility flip while still cited as live authority, and tightens the wording that made 🟡-marking an "introduce debt as long as you mark it" path.
1. Reintroduced deleted docs (operator request)
docs/modeling-discipline.md(Practices 1–11 review rubric) — deleted while INVARIANTS.md cited it 4×, SELF_HOSTING.md once, and live.dag🟡 marks referenced "Practice N". This is the gap that let PR T6 skeleton: real Arrow.body → translated TS emit (value-expression vetting consumer #4623) #4627's dissolution findings through an approving review (still-raven independently verified: T6 skeleton: real Arrow.body → translated TS emit (value-expression vetting consumer #4623) #4627 was unflaggable by any resolvable rule). Restored with:src/v4/TASKS.md, audit worksheets, deleted design docs) re-pointed to PR review / dashboard work items or annotated as git-recoverable history;src/v4/compiler/is itself a review finding, default-block — author states why it can't be model rows + an existing fold;docs/modeling/grounding-worked-examples.md— the coincide evidence bar INVARIANTS P1 cites twice; restored with retiredDECISIONS.mdrefs fixed.Both verified clean of internal-only content for the public repo.
2. Anti-debt-pileup tightening
importlines — literal target atoms (^ts_inhabitant_number) or fixture binding names compared incompiler/match arms are boundary violations the import check can't see; new-compiler-file default-block corollary; T6 skeleton: real Arrow.body → translated TS emit (value-expression vetting consumer #4623) #4627 receipt.is_*/has_*Bool helper over a coproduct is predicate dissolution until proven otherwise).Missing | Unique | Ambiguous⇒find_witness). Also fixed M10-before-M9 ordering.3. Drift fixes
ci.dagas "the Shape-B beachhead" — re-pointed at the M-CI lane.ci.dagas a live load-bearing authority — aligned with THESIS facet 4 (bootstrap/lens_ci_gate/affected_set_selection).decidability-invariant.md,strict-forward-progress.md×3,design-emission-model.md,design-lens-framework.md,docs/review-findings/) annotated as deleted/git-recoverable instead of cited as live; TASKS.md ledger refs re-pointed to dashboard work items.Not in this PR (flagged for follow-up)
🤖 Generated with Claude Code