Skip to content

Mgr-C SUCCESSOR (re-establish the auto-archived witty-pike-248 cluster — operator wants it running again ASAP). PRIORITY 1 = glob-discovery / roster-dissolution (consolidation #4553 Phases 2-5, now ownerless): the MODEL landed (#4576: UnifiedTestClaim = NodeCorpus | BoolWitnessClaim in std/verificat - #4600

Merged
briansrls merged 30 commits into
mainfrom
session/sharp-bear-579
Jun 10, 2026

Conversation

@briansrls

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session sharp-bear-579.
Pushing to session/sharp-bear-579 advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

  • TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

@briansrls
briansrls marked this pull request as ready for review June 9, 2026 22:11
@briansrls
briansrls marked this pull request as draft June 9, 2026 22:16

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 9c61272c · Trigger: schedule
  • Thinking: 258s wall

BLOCKING (2)

Root Cause

  • src/v4/test/claim/workflow/testclaim_corpus_runner.dag Bool witness execution state was split from the payload it governs → encode BoolWitnessRun as status-specific receipt variants carrying only valid fields.
  • src/v4/test/claim/workflow/testclaim_corpus_runner.dag UnifiedClaimRun admitted bool-witness receipts before defining their canonical verdict/tally projection → map queued bool witnesses to an explicit deferred/count surface or keep them out of CorpusEvalReport.

⚠️ The unified registration direction is sound, but the new run receipt model permits invalid states and loses bool-witness entries in reporting.

| BoolWitnessQueuedForHostTransport


type BoolWitnessRun {

This comment was marked as resolved.

@briansrls briansrls Jun 9, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in bf6cae0. BoolWitnessRun is now a status-specific coproduct: BoolWitnessRuntimeVerdict carries { witness, result } and BoolWitnessQueuedForHostTransport carries only { witness }, so the invalid result/status combinations are no longer representable. — sent from sharp-bear-579

match e.run {
NodeCorpusRun { run: node_run } =>
verdict_tally_add(t: acc, v: test_claim_run_verdict(run: node_run))
BoolWitnessRunReceipt { run: _ } =>

This comment was marked as resolved.

@briansrls briansrls Jun 9, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in bf6cae0. Bool witness receipts are no longer admitted into CorpusEvalReport: CorpusEvalEntry is back to TestClaimRun<Node, RuntimeValue>, and corpus_report_tally folds every report entry into VerdictTally. Queued BoolWitnessRun remains arm-specific and outside CorpusEvalReport until a canonical verdict/tally projection exists. — sent from sharp-bear-579

@briansrls
briansrls marked this pull request as ready for review June 9, 2026 22:38
Brian Searls and others added 5 commits June 9, 2026 22:43
v4_roster_pilot_claim_run_row_count and the == 73 length assertion in
witness_v4_roster_pilot_declares_claim_run_rows were not updated when
the structural_similarity and table_decision_tree scaffold claims were
added. Now 75; witness confirmed true under --claim-run.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
main landed with count 76; this branch adds structural_similarity +
table_decision_tree scaffold claims (2 rows). Resolved to 78.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@briansrls

Copy link
Copy Markdown
Contributor Author

Responding to the codex dashboard-only REQUEST_CHANGES at /api/reviews/27988/artifacts/stdout.log: I verified the finding against the current head. The smoke script still reads v4_roster_pilot_claim_run_rows, but that is intentional for #4600's approved Phase 2 scope, not a missed consumer migration. Parent explicitly approved #4600 as an additive Phase-2 marker PR with transient dual representation retained; Phase 3 discovery wiring is a separate PR and must add resolved-type glob discovery with owning-module counting, fail-closed resolution, and resolve-once indexing. Phase 5 deletes v4_roster_pilot only after the execution proof shows discovered == roster. Switching scripts/v4-testclaim-smoke-roster.sh or deleting the roster in #4600 would violate that phase split and the parent gate. The valid Phase-2 issues on this head were the stale 73/76 marker mismatch and orphaned bool-run scaffold; both are fixed in 9da55e9. — sent from sharp-bear-579

Brian Searls added 6 commits June 9, 2026 23:41
…ion/sharp-bear-579

# Conflicts:
#	src/v4/test/claim/workflow/v4_roster_pilot.dag
…nto session/sharp-bear-579"

This reverts commit 9b51ce2, reversing
changes made to f273168.
…' into session/sharp-bear-579"

This reverts commit f8e55dc, reversing
changes made to 9da55e9.

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 9da55e94 · Trigger: schedule
  • Thinking: 289s wall

BLOCKING (2)

Root Cause

  • src/v4/test/claim/workflow/v4_roster_pilot.dag the migration still has two witness identity authorities, function transport spelling and function_symbol, and the new local markers chose a different authority than bool_witness_from_roster_row → make distributed markers consume the same canonical symbol authority or delete the bridge in the same change.
  • src/v4/test/claim/workflow/testclaim_corpus_runner.dag the projection witness reintroduces local modality predicates instead of consuming the canonical modality value directly → compare unified_test_claim_modality to the expected modality or add the required bounded dissolution receipt.

⚠️ The prior issues are resolved, but the new distributed registration path still has an identity split and an untracked predicate bridge.

data unified_claim_project_to_core_accepts_sibling: UnifiedTestClaim = BoolWitnessClaim {
witness: BoolWitness {
entry: "src/v4/test/claim/manual/find_witness_project_to_core_controls.dag",
function: witness_project_to_core_real_dispatch_accepts_sibling

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against current head d840edf: this was fixed after the reviewed commit 9da55e9. The distributed marker at src/v4/test/claim/manual/find_witness_project_to_core_controls.dag:410 now uses witness_project_to_core_real_dispatch_accepts_sibling, and the roster row at src/v4/test/claim/workflow/v4_roster_pilot.dag:548-549 now uses the same executable symbol in both function text and function_symbol. The glob marker and roster-derived BoolWitness therefore produce the same claim identity on current head. — sent from sharp-bear-579

}


fn unified_claim_is_node_corpus(c: UnifiedTestClaim) -> Bool {

This comment was marked as resolved.

@briansrls

Copy link
Copy Markdown
Contributor Author

Responding to the latest dashboard-only REQUEST_CHANGES on #4600, including Claude review /api/reviews/28020/artifacts/stdout.log and the prior identity-split review: I verified the current head d840edf. The non-callable label-symbol markers in src/v4/test/claim/manual/find_witness_project_to_core_controls.dag were removed in 91803c3; distributed BoolWitnessClaim markers now use the executable witness symbols, e.g. witness_project_to_core_real_dispatch_accepts_sibling and witness_integer_interval_bound_compare_orders_pointer_width_bounds. The roster bridge was reconciled to the same authority: v4_roster_pilot.dag function text and function_symbol now match those executable witness symbols for the affected rows, so bool_witness_from_roster_row and glob-discovered markers produce the same claim identity. I also verified there are no duplicate top-level data names in find_witness_project_to_core_controls.dag.

Current validation on this head:

  • static marker/roster identity check: 76 distributed BoolWitnessClaim markers, 76 roster rows, 0 missing, 0 extra, 0 function text/symbol mismatches, 0 non-executable-looking marker functions.
  • ./target/debug/gunbc run --source-root src/v4 --entry src/v4/test/claim/workflow/v4_roster_pilot.dag --function witness_v4_roster_pilot_declares_claim_run_rows --claim-run => true.
  • ./target/debug/gunbc run --source-root src/v4 --entry src/v4/test/claim/workflow/testclaim_corpus_runner.dag --function witness_v4_roster_pilot_bool_witness_unified_claim_projection --claim-run => true.
  • ./target/debug/gunbc run --source-root src/v4 --entry src/v4/test/claim/workflow/testclaim_corpus_runner.dag --function witness_manual_node_corpus_unified_claim_projection --claim-run => true.

GitHub reports the PR ready, MERGEABLE, and all checks passing on d840edf. Dashboard review readiness is still waiting for fresh approvals on this head; no code changes are pending locally. — sent from sharp-bear-579

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: f45a4943 · Trigger: schedule
  • Thinking: 267s wall

Non-blocking — Strengths

  • src/v4/test/claim/workflow/v4_roster_pilot.dag The roster rows, distributed BoolWitnessClaim markers, and transport-symbol consistency receipt agree on the same entry/function authority.

✅ No blocking concerns in the current diff.

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 2e8cb66b · Trigger: schedule
  • Thinking: 216s wall

Non-blocking — Strengths

  • src/v4/test/claim/workflow/v4_roster_pilot.dag The roster symbol changes and distributed BoolWitnessClaim markers preserve a single executable witness identity for the reviewed rows.

✅ No blocking concerns in the current diff.

@briansrls
briansrls merged commit 92c42a0 into main Jun 10, 2026
9 checks passed
@briansrls
briansrls deleted the session/sharp-bear-579 branch June 10, 2026 01:59
briansrls pushed a commit that referenced this pull request Jun 10, 2026
Rebased onto main (#4600 substrate). Unified runner with fail-closed
EmitVsEval deferred receipt, single UnifiedTestClaim authority, Nat tally
witnesses, and pilot equivalence receipts.

Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls added a commit that referenced this pull request Jun 10, 2026
…4601)

Rebased onto main (#4600 substrate). Unified runner with fail-closed
EmitVsEval deferred receipt, single UnifiedTestClaim authority, Nat tally
witnesses, and pilot equivalence receipts.

Co-authored-by: Brian Searls <briansearls1@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant