Skip to content

TypeScript RCA Manager — per #4137 §11.8 ALPHA/PREVIEW lane (NOT release-minimum per Wave F F3). Currently no worksheets started. Goal by end of next iteration: L0 complete per #4117 pattern. Author worksheets for TS R2a/R2b/R3-external leaf-model widening, TS TargetAtomRealization rows, TS TargetTy - #4256

Closed
briansrls wants to merge 4 commits into
mainfrom
session/swift-fox-907

Conversation

@briansrls

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session swift-fox-907.
Pushing to session/swift-fox-907 advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

  • TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

@briansrls
briansrls marked this pull request as ready for review June 1, 2026 23:30
@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: openai-pro / gpt-5-5-pro
  • Commit: 7ac097cb · Trigger: manual
  • Comparison: main @ 03b62c67 ... session/swift-fox-907 @ 7ac097cb
  • Conversation: View conversation

1. Story of the diff

This PR adds four TypeScript planning worksheets under docs/planning/, not implementation code. Together they document an ALPHA/PREVIEW L0 lane for TypeScript: stable algebra-inhabitance fact IDs for number, bigint, boolean, and string; R2a/R2b/R3-external leaf-model claim wiring with falsification fixtures and interim host runners; TargetAtomRealization rows/catalog entries for Symbol/Bool/String; and a TargetTypeExpressionProjection row that maps the six Node connectives onto TypeScript syntax while bounding known field-label and parameter-name gaps. chatgpt-review-1ab2eddc-38e7-4c…

chatgpt-review-1ab2eddc-38e7-4c…

chatgpt-review-1ab2eddc-38e7-4c…

chatgpt-review-1ab2eddc-38e7-4c…

The load-bearing mechanism is documentation of authority chains: shared carriers stay in std/, TypeScript-specific rows stay in src/v4/extdeps/languages/typescript.dag, and compiler/claim consumers are named explicitly instead of adding TypeScript-only coproduct arms or name-keyed translate branches. That is the right shape for an RCA-manager worksheet PR, but one worksheet records a Rust smoke test as L0 evidence without the dissolution path that the neighboring worksheets include.

2. Invariant categories

  1. LAYER MODEL — Compliant. This is markdown-only and does not change Dag substrate types, but the planning text preserves the substrate/implementation split where it speaks about model authority: AlgebraInhabitanceDecl is named as std authority while TypeScript owns exported fact rows, and the target worksheets state that src/v4/std/target_model.dag owns the shared carriers while typescript.dag owns only TypeScript rows. chatgpt-review-1ab2eddc-38e7-4c…

chatgpt-review-1ab2eddc-38e7-4c…

chatgpt-review-1ab2eddc-38e7-4c…

  1. INVARIANTS.md + modeling-discipline.md — Finding. docs/planning/v4-ts-target-type-expression-projection-worksheet-2026-06-01.md:51 lists v4_std_target_realization_dag_smoke_test.rs covers the shared carrier, Rust precedent, and TypeScript same-path expansion. as L0 acceptance, but that worksheet never says the Rust smoke is temporary or names its dissolution trigger. P5 requires scaffolds to have a named, checkable dissolution trigger; the neighboring TargetAtomRealization worksheet does this correctly with “The host smoke remains temporary under T-PB-B / pb_rust_tests_outside_residual_zero” and the .dag TestClaim/generated target-verification trigger. chatgpt-review-1ab2eddc-38e7-4c…

chatgpt-review-1ab2eddc-38e7-4c…

chatgpt-review-b99167f6-8db2-48…

  1. CODING.md — N/A. No Rust code, functions, methods, helpers, or production comments are added; the diff is planning markdown. CODING.md’s comment-discipline concerns do not apply to these receipt tables beyond readability, and the worksheet prose is structured rather than explanatory code commentary. chatgpt-review-1ab2eddc-38e7-4c…

chatgpt-review-1ab2eddc-38e7-4c…

  1. TESTING.md — Finding. The TypeExpressionProjection worksheet’s L0 acceptance depends on a Rust smoke test without documenting how that evidence migrates to the .dag TestClaim/generated-verification surface. TESTING.md says the long-term shape is .dag TestClaim declarations, that external-toolchain boundary tests migrate to ExecuteCommand-based .dag claims, and that the 0-floor shape has no Rust-side residual. chatgpt-review-1ab2eddc-38e7-4c…

chatgpt-review-1e1dbf39-28ac-44…

  1. LOCKED DESIGN DECISIONS — Compliant. The worksheets preserve the ALPHA/PREVIEW, non-release-minimum scope and avoid changing the target-realization thesis: target-specific behavior is represented as TypeScript rows/projections rather than new compiler branches, matching the “one spec file, not a new compiler path per target” direction. chatgpt-review-1ab2eddc-38e7-4c…

chatgpt-review-1ab2eddc-38e7-4c…

chatgpt-review-1ab2eddc-38e7-4c…

chatgpt-review-8e9c07a0-5304-46…

  1. TRACKED vs UNTRACKED DEBT — Finding. The TypeExpressionProjection worksheet has a receipt for the Rust smoke test but not the full tracked-bridge triple: documentation, bounds, and named dissolution trigger. The leaf-model worksheet records T-PB-B/T-22-style bounds for interim host runners, and the TargetAtomRealization worksheet records the host-smoke dissolution path; the TypeExpressionProjection worksheet should do the same for v4_std_target_realization_dag_smoke_test.rs. chatgpt-review-1ab2eddc-38e7-4c…

chatgpt-review-1ab2eddc-38e7-4c…

chatgpt-review-1ab2eddc-38e7-4c…

2.5. Top-down PM intent review

Finding. The PM-level intent is preserved for the TypeScript modeling itself: the worksheets keep TypeScript as target-model data rather than compiler special cases. But the TypeExpressionProjection worksheet dilutes the zero-floor testing intent by making a Rust smoke test part of L0 acceptance without a named .dag TestClaim/generated-verification dissolution path. The thesis says tests are structural data and Rust-authored tests are a smell on the way to zero residual; the diff line that needs reconciliation is the unbounded v4_std_target_realization_dag_smoke_test.rs acceptance row. chatgpt-review-8e9c07a0-5304-46…

chatgpt-review-1ab2eddc-38e7-4c…

3. Verdict

REQUEST_CHANGES

The worksheets mostly preserve the TypeScript RCA lane shape, but the TypeExpressionProjection worksheet leaves a Rust smoke-test receipt untracked. Add the same kind of T-PB-B / pb_rust_tests_outside_residual_zero or T-22-style dissolution path used by the adjacent worksheets, and I would expect this to be approvable.

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 7ac097cb · Trigger: schedule
  • Thinking: 214s wall

✅ Design-doc PR only; the worksheets preserve the alpha/preview scope, name authorities and dissolution receipts, and I found no blocking thesis or invariant conflicts.

@briansrls

Copy link
Copy Markdown
Contributor Author

Superseded by lively-crane-146 (TS RCA Mgr v2). Worksheet content was authored on this branch per #4192 policy (worksheets live outside gunbc); in-tree L0 authority receipts land via #4257 (session/bright-hawk-736). Do not merge planning markdown here.

@briansrls briansrls closed this Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant