Repository navigation
TypeScript RCA Manager — per #4137 §11.8 ALPHA/PREVIEW lane (NOT release-minimum per Wave F F3). Currently no worksheets started. Goal by end of next iteration: L0 complete per #4117 pattern. Author worksheets for TS R2a/R2b/R3-external leaf-model widening, TS TargetAtomRealization rows, TS TargetTy - #4206
briansrls wants to merge 4 commits into
Conversation
…sheets Symbol is callable but not constructable; new Symbol() must be falsification, not the happy path. Addresses PR #4147 blocking review (P1 / MDN grounding). Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
e63b8cbd· Trigger:schedule - Thinking:
315s wall
BLOCKING (2)
Root Cause
docs/planning/v4-ts-leaf-model-r2-r3-external-worksheet-2026-06-01.mdR2b uses a rounded power-of-two boundary as the number-lane negative witness → replace it with a checkable precision-loss fixture whose number verdict is distinct from the exact bigint model.docs/planning/v4-ts-target-atom-realization-worksheet-2026-06-01.mdTS needs a Symbol factory value realization but the plan assumes the existing SG-1 carrier can already express factory calls → ratify the missing std target_model value-template shape before dispatching the TS row worker.
| | Claim ID | Subject fact (typescript.dag) | Happy exercise | Falsification | | ||
| |----------|------------------------------|----------------|---------------| | ||
| | `leaf_model_claim_ts_r2a_number_algebra_operations` | `ts_number_algebra_inhabitance_ts_facts_number` | `function r2a(a: number, b: number): [number, boolean] { return [a + b, a < b]; }` | Call `a.log2_exact()` → TS2339 | | ||
| | `leaf_model_claim_ts_r2b_bigint_beyond_safe_integer` | `ts_bigint_algebra_inhabitance_ts_facts_bigint` | Runtime: `(2n ** 63n - 1n) + 1n === 2n ** 63n` via Node | Same expr in `number` lane → diverges from model | |
There was a problem hiding this comment.
BLOCKING: The R2b falsification is not falsifying: ((2 ** 63 - 1) + 1) === 2 ** 63 evaluates true under JavaScript number rounding, so the wrong-path probe can pass with the same verdict as bigint, violating the leaf-model falsification contract and INVARIANTS P1.
| ```text | ||
| ts_target_atom_realization_symbol: | ||
| type_form: symbol (primitive) or branded alias per Arbiter — NOT a nominal class shadowing global Symbol | ||
| value_form: Symbol(<string-literal>) // ECMA factory call; must match R3-external happy fixture |
There was a problem hiding this comment.
BLOCKING: value_form: Symbol(<string-literal>) is not representable by the landed TargetAtomRealization/TargetValueTemplate vocabulary, so the worksheet either requires changing the std carrier it says to consume or creates a parallel TS value-template authority, violating INVARIANTS P2.
|
Review metadata
1. Story of the diffThis PR adds five planning worksheets for the TypeScript alpha/preview lane, without changing compiler or 2. Invariant categories
TESTING.md — Finding.
2.5. Top-down PM intent reviewFinding. The PM intent is L0 completion per the #4117-style pattern: the worksheet itself states acceptance must be “dual-path verification (happy + falsification) against tsc and Node,” not compile-only wiring. But the R2b row then gives a non-specific “Same expr in 3. VerdictREQUEST_CHANGES. The worksheet structure is directionally strong and mostly respects single-authority modeling, but the R2b falsification and TypeScript toolchain contract are not precise enough to authorize L0 implementation work, and the §P5(b) receipt carries a stale PR number. Fixing those keeps the planning artifact faithful before downstream workers execute it. |
|
Closing as SUPERSEDED. Jun-1 TS-RCA planning worksheets (leaf-model/atom-realization/type-expr-projection/grammar-inverse). Superseded by ctrl#1489 (emit-ladder authority); TS type-expr work is folded into the T3 type-tier lane under Mgr-SPINE. Operator-authorized close (via still-raven-546). |
Auto-opened by session-dashboard for session
fierce-fox-719.Pushing to
session/fierce-fox-719advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan