Skip to content

T-38: harden generated corpus eval receipt #4159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
briansrls merged 12 commits into from
Jun 1, 2026
Merged

T-38: harden generated corpus eval receipt #4159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0e885fa
WIP: Runtime/TestClaim Manager — authority over T-22 eval execution, …
briansrls Jun 1, 2026
525a79a
fix(t38): require generated corpus tally conjunction
briansrls Jun 1, 2026
54c1c03
WIP: Runtime/TestClaim Manager — authority over T-22 eval execution, …
briansrls Jun 1, 2026
c04adad
WIP: Runtime/TestClaim Manager — authority over T-22 eval execution, …
briansrls Jun 1, 2026
26223da
fix(t38): match modeled manual corpus gate
briansrls Jun 1, 2026
17fa213
WIP: Runtime/TestClaim Manager — authority over T-22 eval execution, …
briansrls Jun 1, 2026
c9e95a8
WIP: Runtime/TestClaim Manager — authority over T-22 eval execution, …
briansrls Jun 1, 2026
1d0b0bc
Tighten generated corpus eval receipt probes
briansrls Jun 1, 2026
66c5491
WIP: Runtime/TestClaim Manager — authority over T-22 eval execution, …
briansrls Jun 1, 2026
233bd33
Merge origin/main into T-38 receipt follow-up
briansrls Jun 1, 2026
48e49a5
WIP: Runtime/TestClaim Manager — authority over T-22 eval execution, …
briansrls Jun 1, 2026
e5d810d
Test inverted corpus tally receipt rejection
briansrls Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/v4-testclaim-corpus-eval.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,8 +411,8 @@ def check_generated_corpus_eval(corpus_eval_rs: Path) -> None:
)
normalized_all_pass = "".join(all_pass_body.split())
fail_deferred_conjunction = re.compile(
r"tally\.fail={2}[^&|;=!]*(?:Nat::)?[Zz]ero\b[^&|;]*&&"
r"[^&|;]*tally\.deferred={2}[^&|;=!]*(?:Nat::)?[Zz]ero\b"
r"tally\.fail={2}[^&|;=!A-Za-z0-9_:]*(?:Nat::)?[Zz]ero\b[^&|;=]*&&"

@briansrls briansrls Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BLOCKING: The hardened receipt still matches inverted predicates written as !(tally.fail == Zero) or !(tally.deferred == Zero), so T-38 can pass on a generated corpus gate that is logically false instead of failing closed under INVARIANTS P3.

r"[^&|;]*tally\.deferred={2}[^&|;=!A-Za-z0-9_:]*(?:Nat::)?[Zz]ero\b[^&|;=]*(?:;|\})"
)
if not fail_deferred_conjunction.search(normalized_all_pass):
raise ReceiptError(
Expand Down
44 changes: 42 additions & 2 deletions src/v3/compiler/tests/integration/v4_workflow_ci_runner_dag_smoke_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1340,9 +1340,11 @@ fn v4_workflow_ci_t38_script_checks_generated_manual_corpus_eval_receipt() {
"witness_manual_corpus_gate_closed",
"corpus_report_tally(report);",
"fail_deferred_conjunction",
"tally\\.fail={2}[^&|;=!]*(?:Nat::)?[Zz]ero\\b",
"tally\\.fail={2}[^&|;=!A-Za-z0-9_:]*(?:Nat::)?[Zz]ero\\b",
"[^&|;=]*&&",
"&&",
"tally\\.deferred={2}[^&|;=!]*(?:Nat::)?[Zz]ero\\b",
"tally\\.deferred={2}[^&|;=!A-Za-z0-9_:]*(?:Nat::)?[Zz]ero\\b",
"[^&|;=]*(?:;|\\})",
"inline_empty_gate",
"if(?<!!)is_empty\\([^)]*report[^)]*entries",
"\\{false\\}else\\{manual_corpus_all_pass\\([^)]*report",
Expand All @@ -1354,3 +1356,41 @@ fn v4_workflow_ci_t38_script_checks_generated_manual_corpus_eval_receipt() {
);
}
}

#[test]
fn v4_workflow_ci_t38_script_receipt_rejects_inverted_zero_predicates() {
let output = std::process::Command::new("python3")
.arg("-c")
.arg(
r#"
import re

fail_deferred_conjunction = re.compile(
r"tally\.fail={2}[^&|;=!A-Za-z0-9_:]*(?:Nat::)?[Zz]ero\b[^&|;=]*&&"
r"[^&|;]*tally\.deferred={2}[^&|;=!A-Za-z0-9_:]*(?:Nat::)?[Zz]ero\b[^&|;=]*(?:;|\})"
)

assert fail_deferred_conjunction.search(
"tally.fail==Nat::Zero&&tally.deferred==Nat::Zero}"
)
assert not fail_deferred_conjunction.search(
"(tally.fail==Zero)==false&&tally.deferred==Zero}"
)
assert not fail_deferred_conjunction.search(
"tally.fail==Zero&&(tally.deferred==Zero)==false}"
)
assert not fail_deferred_conjunction.search(
"tally.fail==NotZero&&tally.deferred==NotZero}"
)
"#,
)
.output()
.expect("python3 should run T-38 receipt regex regression");

assert!(
output.status.success(),
"{TESTCLAIM_CORPUS_EVAL_SCRIPT_PATH}: generated corpus-eval receipt regex accepted an inverted zero predicate\nstdout:\n{}\nstderr:\n{}",
String::from_utf8_lossy(&output.stdout),
String::from_utf8_lossy(&output.stderr)
);
}
Loading