Repository navigation
P5 bootstrap-evaluator corpus runtime implementation per worksheet on main (post #4143) — runtime verdict authority, not authoring-time const witnesses - #4150
Conversation
7f25ffa to
6c4fdf3
Compare
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
abd66b9b· Trigger:schedule - Thinking:
271s wall
BLOCKING (1)
Root Cause
src/v4/test/claim/workflow/testclaim_corpus_runner.dagBootstrapEvaluatorCorpusRuntimeEval allows any Symbol as evaluator_pin → make the v4 pin invariant unrepresentable or return a report/outcome variant that preserves the mismatch reason and roster facts.
|
Violations (could not place on specific lines):
|
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
6c4fdf34· Trigger:schedule - Thinking:
238s wall
BLOCKING (1)
Root Cause
src/v4/test/claim/manual/manual_corpus_roster.dagmanual_corpus_node_runtime_value_rows remains List<TestClaimRun<Node, RuntimeValue>> → introduce a claim/subject roster carrier that cannot contain authoring-time verdicts, then execute run_test_claim from that carrier.
|
|
||
| fn runtime_subject_from_roster_run( | ||
| runtime: BootstrapEvaluatorCorpusRuntimeEval, | ||
| run: TestClaimRun<Node, RuntimeValue> |
There was a problem hiding this comment.
BLOCKING: runtime_subject_from_roster_run still accepts TestClaimRun input, so the runtime path carries and silently drops a pre-authored verdict instead of making the worksheet §4 F2 "claims, not pre-built runs" authority unrepresentable (P2 facts-flow-forward/P5).
… eval in testclaim_corpus_runner; address cursor RC; coordinate vivid-lynx on rust emit (#4259) * WIP: T-38 bootstrap-evaluator corpus runtime (#4150 restart): per-row T-22 ev * WIP: T-38 bootstrap-evaluator corpus runtime (#4150 restart): per-row T-22 ev * T-38: align corpus eval receipt with per-row subjects * T-38: clarify corpus receipt is source-shape only
|
Closing — superseded by #4259 (T-38A.3 manual corpus runner via run_test_claim, MERGED 2026-06-02T01:00:54Z). Original cursor RC addressed at #4259 spawn per operator 2026-06-01 policy. witty-crab-534 was archived; nimble-crab-195 caretaker → neat-wolf adhoc-168ccc84-887 (eager-cat-510) completed the work. — sent from nimble-dove-733 |
Summary
Implements the P5 bootstrap-evaluator corpus runtime slice from
docs/planning/v4-p5-bootstrap-evaluator-corpus-runtime-worksheet-2026-06-01.md. The manual corpus runner rebuilds each rosteredTestClaimEvalSubjectwith the bootstrapv4_evaluatorruntime pin, checks that pin on the execution path, and invokesrun_test_claimbefore folding the existingCorpusEvalReport.The host transport now fails closed by adding an emitted Rust integration test to the generated crate and running
witness_manual_corpus_gate_closed(). The JSON receipt reportsruntime_gate_bool: trueandruntime_witness: PASS_EXECUTEDonly after that emitted test passes.Validation
bash -n scripts/v4-testclaim-corpus-eval.sh— passed.git diff --check— passed.CTRL_BUILD_WRAP_CARGO=0 cargo test -p v3-compiler --test integration v4_workflow_ci_runner_dag_smoke_test::v4_workflow_ci_m1_rust_emit_probe_modeled_and_bound_to_ci_yml -- --exact --quiet— passed.CTRL_BUILD_WRAP_CARGO=0 cargo test -p v3-compiler --test integration v4_workflow_ci_runner_dag_smoke_test::v4_workflow_ci_bankruptcy_tier0_ -- --quiet— passed.CTRL_BUILD_WRAP_CARGO=0 cargo test -p v3-compiler --test integration v4_workflow_ci_runner_dag_smoke_test::v4_workflow_ci_wave1_ -- --quiet— passed.CTRL_BUILD_WRAP_CARGO=0 cargo test -p v3-compiler --test integration v4_workflow_ci_runner_dag_smoke_test::v4_workflow_ci_t38_script_checks_generated_manual_corpus_eval_receipt -- --exact --quiet— passed.Worksheet F1-F6
execution_status: runtime_verdictsafter the emitted Rust runtime gate test passes.run_manual_testclaim_corpus_evalexecutes the modeled runner path viarun_test_claiminstead of repackaging roster rows.bootstrap_projection_inputs.runtime_model.runtime_identity; the runner checks it againstv4_evaluator_runtime_idbefore executing entries.manual_corpus_gate(report)reads the runtime-producedCorpusEvalReport; the host transport runswitness_manual_corpus_gate_closed()and fails closed unless it evaluates true.