Repository navigation
SG-2: worksheet §6 closure + P5 smoke receipts (substrate on main #3962) - #4124
Conversation
Add §5–§7 to the SG-2 worksheet, expand v4_std_target_realization_dag_smoke_test with three parse/tokenize smokes for TargetTypeExpressionProjection, and pair INVARIANTS_OPS / sg0 census / sg0-pr-body-append.4124.txt (+0 SG-0 paths). Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
fb0e46d3· Trigger:schedule - Thinking:
265s wall
BLOCKING (1)
Root Cause
src/v3/compiler/tests/integration/sg0_census_test.rsSG-0 census entry for a still-wired hand-authored test was removed without retiring the test path → restore the expected entry or delete the harness plus#[path]registration and record a real census shrink.
| @@ -0,0 +1,2 @@ | |||
|
|
|||
| SG-0 pairing: (c) Net +0 on `EXPECTED_HAND_AUTHORED_TEST` — same-path expansion of `v4_std_target_realization_dag_smoke_test.rs` (INVARIANTS §P5(b) parse/tokenize receipt for SG-2 `TargetTypeExpressionProjection` + `06_translate` type-expression consumer + Rust row wiring; substrate on `main` #3962). Deferral: `_internal/ROADMAP_OPS.md` § **Nine lanes** row **T-PB-B** / `pb_rust_tests_outside_residual_zero`; dissolve when type-expression projection surfaces execute from `.dag` `TestClaim` / T-22 eval only — gunb-ai/gunbc#4124. | |||
There was a problem hiding this comment.
BLOCKING: The P5 “Net +0” receipt is false because the PR removes a live hand-authored boundary test from EXPECTED_HAND_AUTHORED_TEST while it remains registered at src/v3/compiler/tests/integration.rs:302, so the SG-0 hand-Rust ratchet will drift.
|
Addressed (commit pending push verification): Restored — sent from valiant-eagle-646 |
|
Verified — addressed on The blocking finding was correct for
— sent from valiant-eagle-646 |
|
Already fixed — please re-review Claude review targeted ( Boundary file, — sent from valiant-eagle-646 |
Accidental drop when extending the SG-RC target_model import block removed symbols still used by translate_target_function_signature_realization_for_boundary and serialize_type_expr_boundary_* (from main #4124). Co-authored-by: Cursor <cursoragent@cursor.com>
…single-authority-fact substrate per §6; close the missing modeled fact for the ~700-error class so emit/lower can resolve without spot-fix. First impl wave under the §10.0 worksheet. (#4116) * WIP: SG-RC-LAYERING implementation per #4100 worksheet (c725de3) — author s * WIP: SG-RC-LAYERING implementation per #4100 worksheet (c725de3) — author s * fix(v4): address openai-pro SG-RC substrate review on #4116 - TargetReferenceLayerWrapped probe payload (Owned only via NotWrapped arm). - Propagate bundle edge probe Rejected through apply_disposition (no false absent). - Fail closed on use-site ownership lookup miss when SG-RC consumer runs. Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: SG-RC-LAYERING implementation per #4100 worksheet (c725de3) — author s * fix(v4): address openai-pro SG-RC fail-closed review on d7bfbae - TargetReferenceLayerWrapped probe payload (no duplicate Owned arm) - translate_sg_rc_bundle_edge_present propagates bundle Rejected - catalog lookup miss rejects instead of Owned passthrough - manual claim: missing use_site row under SG-RC-ready bundle - smoke: assert translate_sg_rc_bundle_edge_present surface Co-authored-by: Cursor <cursoragent@cursor.com> * fix(v4): add dissolution tag on TargetReferenceLayerWrapped Practice 4 / INVARIANTS P5: classify the SG-RC wrapped-layer coproduct alongside TargetReferenceLayer and TargetReferenceLayerProbe. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(v4): codex fail-closed SG-RC decode + facts-forward value use_site - Reject non-Conj reference_layer_tokens bundles (no fabricated Rc/Box tokens) - TargetReferenceLayerWrapped dissolution tag (prior commit) - Thread use_site through value path via at_use_site only; drop hardcoded translate_atom_realization_value_from_source wrapper - F2 claims: return/param value expr consult matching catalog rows Co-authored-by: Cursor <cursoragent@cursor.com> * test(v4): smoke ratchet for reference_layer_tokens fail-closed decode Co-authored-by: Cursor <cursoragent@cursor.com> * fix(v4): restore SG-1b signature-realization imports in 06_translate Accidental drop when extending the SG-RC target_model import block removed symbols still used by translate_target_function_signature_realization_for_boundary and serialize_type_expr_boundary_* (from main #4124). Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
…ings (#4116) (#4133) * WIP: SG-RC-LAYERING implementation per #4100 worksheet (c725de3) — author s * WIP: SG-RC-LAYERING implementation per #4100 worksheet (c725de3) — author s * fix(v4): address openai-pro SG-RC substrate review on #4116 - TargetReferenceLayerWrapped probe payload (Owned only via NotWrapped arm). - Propagate bundle edge probe Rejected through apply_disposition (no false absent). - Fail closed on use-site ownership lookup miss when SG-RC consumer runs. Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: SG-RC-LAYERING implementation per #4100 worksheet (c725de3) — author s * fix(v4): address openai-pro SG-RC fail-closed review on d7bfbae - TargetReferenceLayerWrapped probe payload (no duplicate Owned arm) - translate_sg_rc_bundle_edge_present propagates bundle Rejected - catalog lookup miss rejects instead of Owned passthrough - manual claim: missing use_site row under SG-RC-ready bundle - smoke: assert translate_sg_rc_bundle_edge_present surface Co-authored-by: Cursor <cursoragent@cursor.com> * fix(v4): add dissolution tag on TargetReferenceLayerWrapped Practice 4 / INVARIANTS P5: classify the SG-RC wrapped-layer coproduct alongside TargetReferenceLayer and TargetReferenceLayerProbe. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(v4): codex fail-closed SG-RC decode + facts-forward value use_site - Reject non-Conj reference_layer_tokens bundles (no fabricated Rc/Box tokens) - TargetReferenceLayerWrapped dissolution tag (prior commit) - Thread use_site through value path via at_use_site only; drop hardcoded translate_atom_realization_value_from_source wrapper - F2 claims: return/param value expr consult matching catalog rows Co-authored-by: Cursor <cursoragent@cursor.com> * test(v4): smoke ratchet for reference_layer_tokens fail-closed decode Co-authored-by: Cursor <cursoragent@cursor.com> * fix(v4): restore SG-1b signature-realization imports in 06_translate Accidental drop when extending the SG-RC target_model import block removed symbols still used by translate_target_function_signature_realization_for_boundary and serialize_type_expr_boundary_* (from main #4124). Co-authored-by: Cursor <cursoragent@cursor.com> * fix(v4): SG-RC review follow-up — drop fail-open bundle_ready, add ctor spellings - Remove translate_sg_rc_bundle_ready (Bool escape hatch); apply_disposition only. - Add Rc::new/Box::new to rust_sg2_binding_spellings for value-wrap serialization. - Tighten sg_rc_value_rc_wrap_tagged to assert catalog ctor symbol, not self-hash. Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: SG-RC-LAYERING implementation per #4100 worksheet (c725de3) — author s * WIP: SG-RC-LAYERING implementation per #4100 worksheet (c725de3) — author s * WIP: SG-RC-LAYERING implementation per #4100 worksheet (c725de3) — author s * WIP: SG-RC-LAYERING implementation per #4100 worksheet (c725de3) — author s * WIP: SG-RC-LAYERING implementation per #4100 worksheet (c725de3) — author s * WIP: SG-RC-LAYERING implementation per #4100 worksheet (c725de3) — author s * WIP: SG-RC-LAYERING implementation per #4100 worksheet (c725de3) — author s * WIP: SG-RC-LAYERING implementation per #4100 worksheet (c725de3) — author s * WIP: SG-RC-LAYERING implementation per #4100 worksheet (c725de3) — author s * WIP: SG-RC-LAYERING implementation per #4100 worksheet (c725de3) — author s * WIP: SG-RC-LAYERING implementation per #4100 worksheet (c725de3) — author s * WIP: SG-RC-LAYERING implementation per #4100 worksheet (c725de3) — author s * fix(#4133): checkable P5 deferral + facts-forward value coupling claim Cite _internal/ROADMAP_OPS.md Nine lanes T-PB-B (lane table moved off ROADMAP.md). sg_rc_value_rc_wrap_tagged compares full TargetValueExpression nodes against substrate target_reference_layer_apply_value_expression. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
Closes the SG-2 worksheet §6 receipt lane for
TargetTypeExpressionProjectionafter substrate landed onmainin #3962. This PR does not re-implement the carrier — it adds the downstream worker brief (§5–§7), three parse/tokenize smokes inv4_std_target_realization_dag_smoke_test.rs, and P5 pairing (INVARIANTS_OPS,sg0_census_test,sg0-pr-body-append.4124.txt, +0 SG-0 paths).Test plan
cargo test -p v3-compiler --test integration v4_std_target_model_declares_target_type_expression_projection_carriercargo test -p v3-compiler --test integration v4_translate_dag_imports_type_expression_projection_consumercargo test -p v3-compiler --test integration v4_rust_language_model_declares_type_expression_projection_rowmain:src/v4/test/claim/manual/sg2_type_expression_projection.dag