Repository navigation
T-24: workflow/ci.dag emits ci.yml — dissolve detect-affected-components.sh and hand-authored YAML - #3895
Closed
briansrls wants to merge 63 commits into
Closed
T-24: workflow/ci.dag emits ci.yml — dissolve detect-affected-components.sh and hand-authored YAML#3895briansrls wants to merge 63 commits into
briansrls wants to merge 63 commits into
Conversation
…v projection Co-authored-by: Cursor <cursoragent@cursor.com>
Add v4_ci_runner_pool to ci_changed_path_affects_workflow_policy so the detect-ci-affected-components host transport matches ci.dag authority. Register detect_ci_affected_components bin and v4_ci_* modules in EXPECTED_HAND_AUTHORED_NON_TEST and INVARIANTS §P5 non-test table. Co-authored-by: Cursor <cursoragent@cursor.com>
CI failed on sg0-pr-body-append.3853.txt — the (c) pairing line cited gunbc#3853 but omitted "dispatch", which check-pr-sg0-net-shrink-discipline requires on the pairing line or its immediate continuation. Co-authored-by: Cursor <cursoragent@cursor.com>
The Lens-CI v4 compile step failed because `ReadFailClosed { .. }` uses
rest syntax the parser does not accept. Bind the Diagnostic payload with
an explicit wildcard field instead.
Co-authored-by: Cursor <cursoragent@cursor.com>
v4 compile rejects a line-leading `!=` token (Ne); fold the nonuniform-runner-count check onto one line for Lens-CI. Co-authored-by: Cursor <cursoragent@cursor.com>
Main landed incomplete WasmModelCoreLawKey/SwiftModelCoreLawKey return
blocks (unclosed '('); GitHub PR merge replayed that blob and broke
test_strict_deprose_dag.py. Restore merge-base tag entries and close
the handlers matching TsModelCoreLawKey.
Co-authored-by: Cursor <cursoragent@cursor.com>
Resolve strict_deprose_dag.py conflict by retaining the closed dissolve-on-arrival return block; main's incomplete handler broke test_strict_deprose_dag.py on PR merge. Co-authored-by: Cursor <cursoragent@cursor.com>
Main deleted scripts/strict_deprose_dag.py and CI steps; keep T-24 detect-ci-affected-components wiring in ci.yml. Restores mergeable=CLEAN. Co-authored-by: Cursor <cursoragent@cursor.com>
EXPECTED_HAND_AUTHORED_NON_TEST paths must name pb_hand_rust_at_shim_floor (T-PB-A), not pb_rust_tests_outside_residual_zero (T-PB-B test subset). Align INVARIANTS §P5(b) rows and sg0-pr-body-append.3853.txt with emit_rust_bin_shim.rs peer pattern (claude RC 20162). Co-authored-by: Cursor <cursoragent@cursor.com>
Operator srv1/srv2 fleet rows only evidence Arm64; RunnerArchUnknown admitted an ungrounded pool state (codex RC @548516db, inline @ci.dag:121). Smoke test ratchets closed coproduct (codex 20315-class substrate fix). Co-authored-by: Cursor <cursoragent@cursor.com>
`type RunnerArch = Arm64` alias syntax is unresolved in Lens-CI v4 compile (CI 26619390306). Keep closed coproduct with only `Arm64` variant — Unknown fallback still deleted. Co-authored-by: Cursor <cursoragent@cursor.com>
Lens-CI v4 compile treats bare `Arm64` as unresolved type, not a sum variant tag (CI 26619597241). Prefix variant per v4 naming convention; Unknown fallback remains deleted. Co-authored-by: Cursor <cursoragent@cursor.com>
… resolve it Isolated v4 compile of ci.dag fails on any RunnerArch variant tag (Arm64, RunnerArchArm64). Fleet Arm64 is a comment-level closed operator fact; pool struct keeps host/capacity fields only. Rename misleading unit test. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Append file declared +3 while origin/main…HEAD census diff is net +1 (v4_ci_runner_pool.rs only); unblocks ci job SG-0 net-shrink check. Co-authored-by: Cursor <cursoragent@cursor.com>
Unblocks fmt CI on openai-pro arch:Symbol + Wave-0 scope header fix. Co-authored-by: Cursor <cursoragent@cursor.com>
Connect ci_runner_pool_fleet_capacities_valid to runner_pool_m1_probe.dag so modeled Int-bound validators have a consumer per Practice 2. Co-authored-by: Cursor <cursoragent@cursor.com>
Stop fn-body slicing at `\npub fn ` boundaries and collect all path/prefix literals per line so M1 smoke parity matches ci.dag. Co-authored-by: Cursor <cursoragent@cursor.com>
Codex flagged missing T-PB-B receipt for expanded v4_workflow_ci_runner_dag_smoke_test.rs parity ratchets; document +0 EXPECTED_HAND_AUTHORED_TEST expansion in sg0 append and INVARIANTS_OPS. Co-authored-by: Cursor <cursoragent@cursor.com>
Post-#3891 main unblocks v4 full-tree emit probe (exit 143 / T-22 timeout pattern on pre-fix baseline).
Contributor
Author
|
Superseded by #3853 (merged @ — sent from wise-otter-34 |
Contributor
Author
briansrls
commented
May 29, 2026
briansrls
left a comment
briansrls
left a comment
Contributor
Author
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
414f7d4f· Trigger:schedule - Thinking:
299s wall
Non-blocking — Strengths
src/v4/workflow/ci.dagThe affected-set path buckets are modeled in ci.dag, use std algebra helpers and canonical Outcome, and the interim Rust mirror is explicitly receipted with parity ratchets.
ROADMAP — Verified
- T-24 detect-affected-components.sh dissolution: The shell bridge is deleted and CI now invokes the tracked ci_affected_components transport.
ROADMAP — Incomplete
- T-24 ci.yml authority dissolution: The changed ci.dag text explicitly leaves the CI/YAML authority bridge open, so this PR does not claim final hand-authored ci.yml dissolution.
✅ No blocking concerns found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-opened by session-dashboard for session
wise-otter-34.Pushing to
session/wise-otter-34advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan