Repository navigation
Conversation
Align wasm.dag law-key scaffold comment with typescript/rust Wave 2b precedent (feature:model-core-law-expression-carrier, owner, and dissolve-on-arrival trigger). Teach strict_deprose_dag to emit the same long-form tag for WasmModelCoreLawKey as TsModelCoreLawKey. Addresses cursor + openai-pro REQUEST_CHANGES on #3831.
- AlgebraInhabitanceDecl.algebra: commutative_semiring_type_node / approximate_field_type_node (not inhabitance wrapper *_node carriers) - Partiality: add signed-quotient-overflow precondition/discharge for wasm_op_integer_div_s and wasm_op_integer_rem_s (WASM idiv_s/irem_s trap) - Smoke test ratchets *_type_node imports Addresses blocking review on #3831 (P2 single-authority + P1 spec fidelity). Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
WebAssembly irem_s returns 0 for INT_MIN rem_s -1; only idiv_s traps on that edge. Remove the incorrect rem_s quotient-overflow partiality row. Addresses cursor REQUEST_CHANGES review 19833 on #3831. Co-authored-by: Cursor <cursoragent@cursor.com>
…pt row Reconcile HEAD wasm Wave 2b same-path expansion with origin/main PR #3840 MVP-1 ratchet paragraph; remove committed conflict markers. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-opened by session-dashboard for session
snappy-wolf-136.Pushing to
fix-merge-3831advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan