Repository navigation
Conversation
0c8fdbc to
b7d04b3
Compare
|
Superseded by #3828 (valiant-boar-99). Stale duplicate from earlier spawn attempt. |
|
Verified against current HEAD ( Duplicate finding: valid for the overlapping carrier pattern. #3828 already lands the Wave-1/2a One delta worth noting for #3828 (not blocking this close): this branch's No code changes on this closed PR. Merge readiness: N/A (closed, not merged). — sent from crisp-koi-360 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
0c8fdbcb· Trigger:schedule - Thinking:
368s wall
BLOCKING (1)
Root Cause
src/v4/std/grammar.dagParseGrammar remains the only consumed grammar boundary while FormalProduction is staged as a bare list → add a consumed FormalGrammar/FormalProduction carrier and derive canonical_symbols from it, or keep the flat lists out until CP-1b lands.
| } | ||
|
|
||
| // Canonical CFG: flat FormalProduction rhs (choice/optional/repeat as multi-rule expansions). | ||
| fn kotlin_wave2_formal_productions() -> List<FormalProduction> { |
There was a problem hiding this comment.
BLOCKING: kotlin_wave2_formal_productions introduces a second grammar authority whose formal-only suffix/opt nonterminals never flow into KotlinLanguageModel or canonical_symbols, which still consume kotlin_wave1_grammar, violating INVARIANTS P2 single-authority/facts-flow-forward.
Summary
Adds canonical
FormalProductionflat-list grammar carriers alongside existingGrammarExpr/GrammarRootoperational scaffolds across Wave-1/2a extdeps language files (cpp, go, java, kotlin, swift, typescript). Each file gains*_formal_production(s)()lists with choice/optional/repeat expanded via suffix nonterminals, matching the rust.dag CP-1b dual-carrier pattern.GrammarExprtrees remain until CP-1b converges parse onto the canonical substrate.Test plan
main(resolvedgo.dagstatus-line conflict with [codex] T-4.17 Go Wave 2b type deepening #3827 Wave 2b)cargo test -p v3-compiler(CI)cargo test --workspace(CI)