Repository navigation
F11: replace invalid 🟡 tags in affected_set.dag — bare #3153-subsumed gates with concrete feature/consumer gates per F11 analysis finding - #3671
Merged
Conversation
briansrls
marked this pull request as ready for review
May 25, 2026 20:48
Practice 4 requires each 🟡 gate carry a bound task/PR alongside the feature name and dissolve-on condition. All 9 gates had the feature: and dissolve-on: fields but no explicit bind reference; only BoundaryReceipt was already correct with '— bind T-21 —'. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
All 9 gates were missing the bound task token; ExclusionProof also had the bind reference misplaced at the tail of the dissolve-on clause. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ion/still-stag-65
briansrls
commented
May 25, 2026
briansrls
left a comment
briansrls
left a comment
Contributor
Author
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
26220a20· Trigger:schedule - Thinking:
148s wall
Non-blocking — Strengths
src/v4/lens/affected_set.dagThe changed yellow tags replace bare #3153-subsumed comments with feature gates, a bound task, and explicit dissolve-on conditions.
ROADMAP — Verified
- T-21: src/v4/TASKS.md defines lens/affected_set.dag as the incremental re-exec frontier, so the new bind T-21 gates point at a concrete task.
✅ No blocking concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-opened by session-dashboard for session
still-stag-65.Pushing to
session/still-stag-65advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan