T-4 go.dag — primitive fact-bundles + ModelCore wave-1 (rust.dag pattern)

[briansrls]

Summary

• go.dag — Go spec predeclared primitive fact-bundles + go_model_core_wave1() (rust/kotlin pattern).
• swift.dag — Swift Book scalar fact-bundles + swift_language_model_anchor.dag (folded from closeout child Language fact-bundle expansion — manager closeout (snappy-bear-761) #3571).
• Map spec_facts migration — mechanical ModelCore substrate-evolution (3/4): spec_facts: List<PrimitiveFactAxisBinding> → Map<Symbol, Node> uniqueness constraint — discharge E3-deferred follow-up from #3500 (codex BLOCKING #4: List admits duplicate axis bindings; std/collection already declares Map) #3549 follow-through for java/kotlin/lean/llvm_ir/machine_code/typescript/wasm on this branch.
• strict-deprose — header sync for llvm_ir + typescript after symbol churn.

Test plan

• cargo run --bin v2-compiler -- compile --source-root src/v4 --output-dir /tmp/out --target rust — 0 diagnostics
• python3 scripts/strict_deprose_dag.py --check — OK

[briansrls]

Codex APPROVE (#16452) — verified, no code change required.

Re-read the diff at HEAD against INVARIANTS.md / docs/modeling-discipline.md Practice 8:

• Language slices only extend fact-bundle + ModelCore wave-1 carriers; no parallel algebra or hollow aliases added.
• go_model_core_wave1 consumer-less staging matches the python/rust E-6(b) pattern with an explicit dissolution trigger at go.dag:809.
• Map spec_facts migration in sibling files is mechanical (ModelCore substrate-evolution (3/4): spec_facts: List<PrimitiveFactAxisBinding> → Map<Symbol, Node> uniqueness constraint — discharge E3-deferred follow-up from #3500 (codex BLOCKING #4: List admits duplicate axis bindings; std/collection already declares Map) #3549 follow-through), not a second authority.

CI follow-up (this thread): pushed strict_deprose_dag --check header sync for llvm_ir.dag / typescript.dag (Owns-line drift after Map migration symbol renames) — that was the failing gate on the prior HEAD, not a modeling finding.

— sent from snappy-bear-761

[briansrls]

Cursor APPROVE (#16489 on 3e4cae5a5) — verified, no code change.

Re-read at current HEAD (928188006 adds vivid-swift parse smokes only; go/swift/Map slice unchanged vs reviewed SHA):

• go_model_core_wave1 E-6(b) consumer-less scaffold + T-11 dissolve-on at go.dag:809-812 — matches rust/python wave-1 pattern.
• Map spec_facts migrations align with model_core.dag on main; no hollow aliases in changed lines.

Exploratory (non-blocking): Swift int/float width tags sharing swift_tag_bits32/64 vs Go’s separated tags — noted; acceptable wave-1 while width facts stay type-directed via substrate carriers. SwiftIntegerOverflowSemantics {} placeholder vs Go overflow coproduct — wave-2/T-11 follow-on; bool grounding already marked 🟡 on swift.

Awaiting second distinct provider approval + CI green on 928188006.

— sent from snappy-bear-761

[briansrls]

Claude APPROVE (#16502 on 65d231637) — verified, no code change.

Spot-checks hold on current HEAD:

• go_wave1_primitive_fact_bundles at go.dag:790, go_model_core_wave1 at go.dag:810 — match smoke assertions (v4_compiler_emit_translate_smoke_test.rs:224-237). Harness intentionally asserts ModelCore wave-1 only (no GoLanguageModel / go anchor on this branch; vivid-swift slice held post-pause).
• E-6(b) consumer-less marker at go.dag:806-809 — tracked debt, T-11 dissolve-on.
• src/v4/test/claim/manual/swift_language_model_anchor.dag present; imports swift_language_model_wave1 / swift_model_core_wave1 defined in swift.dag.
• Map spec_facts migration is mechanical ModelCore substrate-evolution (3/4): spec_facts: List<PrimitiveFactAxisBinding> → Map<Symbol, Node> uniqueness constraint — discharge E3-deferred follow-up from #3500 (codex BLOCKING #4: List admits duplicate axis bindings; std/collection already declares Map) #3549 follow-through across the listed extdeps files.

Exploratory (non-blocking): table-driven language parse smokes as the file grows — agreed; follow-on after pause.

CI re-running on this SHA (65d231637 go parse + smoke fix); awaiting green ci job before operator merge.

— sent from snappy-bear-761

[briansrls]

Claude APPROVE (#16514 on 6994ad570) — verified, no code change.

Spot-check on reviewed HEAD:

• Go/swift wave-1 fact-bundle + Map<Symbol, Node> spec_facts pattern matches rust/java; map_insert/empty_map ambient resolution unchanged from substrate convention.
• go_model_core_wave1 E-6(b) at go.dag:806-809 with named T-11 dissolve-on — scaffold discipline satisfied.
• typescript.dag imports Empty for fold_list empty seed (import v4.std.algebra { BooleanAlgebra, Empty, fold_list }) — present on branch.
• Go smoke (~22 lines) extends existing harness; no new hand-Rust modules.

Exploratory (non-blocking): Owns-header grouping as wave-2 grows; variadic map_of to dedupe _primitive_fact_map_N helpers — agreed as future cost-of-change, not this PR.

Note: 6994ad570 is a merge of main (#3551 lattice follow-up) into the lane branch — out of T-4 scope but does not invalidate the substrate review above.

— sent from snappy-bear-761

[briansrls]

Review metadata

• Provider / model: codex / unknown
• Commit: 6994ad57 · Trigger: schedule
• Thinking: 274s wall

---

BLOCKING (2)

Root Cause

• src/v4/extdeps/languages/go.dag integer fact axes were copied into parallel fields instead of deriving signedness/overflow from one canonical width/kind carrier → collapse to one signed/unsigned integer fact shape or make signedness a projection from GoIntegerWidth.
• src/v4/extdeps/languages/swift.dag nonnumeric scalar and representation facts are modeled as independent axes → split to a nonnumeric-only scalar carrier or make each nonnumeric variant carry its matching representation.

⚠️ Two substrate model shapes permit impossible fact combinations, and fixing them now prevents those carriers from becoming downstream authority.

[briansrls]

BLOCKING: GoIntegerPrimitiveFacts stores signedness separately from GoIntegerWidth and overflow, so Signed plus GoUnsignedWidth or unsigned overflow is constructible; this violates INVARIANTS P2 / illegal-states-unrepresentable for substrate fact-bundles.

[briansrls]

BLOCKING: SwiftNonNumericPrimitiveFacts accepts the full SwiftScalar coproduct, so a nonnumeric row can be IntScalar or pair BoolScalar with StringRepresentationFact; this violates INVARIANTS P2 / illegal-states-unrepresentable.

[briansrls]

Blocking P2 review — addressed (verified on merge commit 50ae900bc)

Reviewed against the findings at 6994ad57. Both were valid; fixes landed before merge in 909092b64 / dcd7e4431 (squash: 50ae900bc).

1. go.dag — integer fact carrier (was parallel axes)

Before: GoIntegerPrimitiveFacts record with independent signedness, GoIntegerWidth, and overflow → illegal combos (e.g. Signed + GoUnsignedWidth).

After: Coproduct arms tie width kind to signedness/overflow projection:

• GoSignedIntegerPrimitiveFacts { surface_spelling, width: SignedIntWidth, encoding, std_projection }
• GoUnsignedIntegerPrimitiveFacts { surface_spelling, width: UnsignedIntWidth, encoding, std_projection }

go_integer_facts_node / go_primitive_bundle_from_integer_facts match on the arm and project Signed/Unsigned + truncate-on-overflow from the variant (not parallel fields). Removed GoIntegerWidth wrapper.

2. swift.dag — nonnumeric facts (was independent scalar + value_fact)

Before: SwiftNonNumericPrimitiveFacts { scalar: SwiftScalar, value_fact: SwiftNonNumericValueFact } → e.g. IntScalar + StringRepresentationFact representable.

After: Per-kind coproduct — each arm carries its matching representation:

• SwiftBoolPrimitiveFacts / SwiftCharacterPrimitiveFacts / SwiftStringPrimitiveFacts / SwiftVoidPrimitiveFacts

Catalog rows and bundle/substrate builders updated; scalar classifier and representation nodes are projections from the coproduct arm.

Verification

• v2-compiler compile --source-root src/v4 — 0 diagnostics
• cargo test -p v3-compiler v4_go_language — pass

— sent from snappy-bear-761