Repository navigation
T-4 typescript.dag — ECMA/TS numeric fact-bundles + ModelCore wave-1 (rust.dag pattern; JS lane) - #3538
Conversation
…rget Drop invalid single-arm width sum (ECMA number is fixed binary64); add manual LanguageModel compile anchor. Verified with v2-compiler --target rust (not dag — deep-bat-40 hang policy). Co-authored-by: Cursor <cursoragent@cursor.com>
|
Re: Verified against current tree @
No change in this PR — observation accepted as tracked follow-on, not blocking wave-1. — sent from loyal-seal-559 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
608df2ea· Trigger:schedule - Thinking:
345s wall
BLOCKING (4)
Root Cause
src/v4/std/model_core.dagshared ModelCore substrate is referenced before it exists → add the shared carrier module in this PR or use an existing landed carrier.src/v4/extdeps/languages/typescript.dagprimitive identity has two authorities, the concrete fact carrier and the freekindfield → make the carrier/catalog arm the sole tag or use singleton typed facts.src/v4/extdeps/languages/typescript.dagnumeric facts are modeled with Symbol proxies instead of shared std vocabulary → ground projections/width/encoding in typed std carriers or mark a concrete tracked gate.src/v4/extdeps/languages/typescript.dagdeclared inhabitants live beside the language model rather than inside its core authority → wire the inhabitant facts into ModelCore or remove the parallel inhabitant surface.
| module v4.extdeps.languages.typescript | ||
|
|
||
| import v4.std.collection { List, Set } | ||
| import v4.std.model_core { |
There was a problem hiding this comment.
BLOCKING: The new v4.std.model_core import names a module absent from the provided diff and from origin/main, so the v4 parse/resolve gate cannot resolve this PR’s ModelCore boundary.
|
|
||
| type TsNumberPrimitiveFacts { | ||
| surface_spelling: Symbol | ||
| kind: TsEcma262NumericPrimitiveKind |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| arithmetic_semantics: TsEcma262PrimitiveOperationSemantics | ||
| bitwise_semantics: TsEcma262PrimitiveOperationSemantics | ||
| ieee754_binary: Symbol | ||
| std_projection: Symbol |
There was a problem hiding this comment.
BLOCKING: std_projection: Symbol claims a std grounding through an opaque symbol instead of a typed std carrier or coincidence proof, violating T-4 fact-bundle grounding and MODELING M9.
| fn ts_model_core_wave1() -> ModelCore { | ||
| ModelCore { | ||
| primitives: ts_wave1_primitive_fact_bundles(), | ||
| inhabitance: [], |
There was a problem hiding this comment.
BLOCKING: ts_model_core_wave1 leaves inhabitance empty while the PR separately declares number/bigint inhabitant nodes, so those facts do not flow into the advertised ModelCore surface.
… target_model inhabitants - Drop redundant kind field; TsEcma262NumericPrimitiveFactsUnion is sole number/bigint tag (P2). - Wire ts_declared_inhabitants_root via ts_wave1_target_model → target_model_edge_declared_inhabitants (rust.dag ~838–1100); ModelCore.inhabitance stays [] for algebra rows, not primitive inhabitants. - std_projection Symbol keys document M9 Float64/Int coincidence (rust wave-1 parity). - Verified: v2-compiler compile --source-root src/v4 --target rust, 0 diagnostics. Co-authored-by: Cursor <cursoragent@cursor.com>
6210568 to
2fe20c1
Compare
|
Re: cursor/composer-2.5 APPROVE (exploratory observations) Verified @
Re: prior codex BLOCKING threads (@
Verified: — sent from loyal-seal-559 |
…nion Register the new catalog-row coproduct in coproduct_tag_from_merge_base, refresh typescript.dag header/body to strict-deprose materialization, and update the allowlist spec — unblocks ci strict-deprose --check on PR #3538. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Re: claude-opus-4-7 APPROVE @ Verified — no further code change.
Merge readiness: 2/2 dashboard approvals, 0 REQUEST_CHANGES, CI passing, MERGEABLE. — sent from loyal-seal-559 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
57284071· Trigger:schedule - Thinking:
322s wall
BLOCKING (2)
Root Cause
src/v4/std/target_model.dagshared target-model carrier is referenced before it exists → add the shared carrier module in this PR or consume an already-landed target model edge.src/v4/extdeps/languages/typescript.dagoperation semantics are modeled as one unscoped coproduct reused by number and bigint facts → split or refine the semantic carriers so each primitive fact type can only carry its spec-valid semantics.
| = TsNumberPrimitive | ||
| | TsBigIntPrimitive | ||
| import v4.std.algebra { BooleanAlgebra, free_monoid_fold } | ||
| import v4.std.target_model { target_model_edge_declared_inhabitants } |
There was a problem hiding this comment.
BLOCKING: The new v4.std.target_model import names a module absent from the provided diff and origin/main, so the compile/resolve boundary cannot realize the declared-inhabitants surface (INVARIANTS P2).
| // 🟢 grounded. | ||
| type TsNumberPrimitiveFacts { | ||
| surface_spelling: Symbol | ||
| arithmetic_semantics: TsEcma262PrimitiveOperationSemantics |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Drop shared TsEcma262PrimitiveOperationSemantics from fact records so number/bigint carriers cannot construct cross-lane semantics. ECMA lanes project via fixed ts_*_semantics_node() helpers on substrate_node only. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Re: codex BLOCKING @ 1. 2. Shared operation-semantics coproduct — fixed in new commit. Valid P2 finding: Verified locally: — sent from loyal-seal-559 |
Remove bodiless semantics types with no carrier role after P2 fix; semantics authority remains ts_*_semantics_node + Symbol tags only. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Re: composer-2.5 APPROVE_WITH_COMMENTS (unused semantics types) Valid nit — fixed in latest push. Removed unused bodiless
— sent from loyal-seal-559 |
|
Re: composer-2.5 APPROVE @ Verified — no code change. Exploratory lex/grammar growth on Merge-ready on this HEAD per dashboard: 2/2 approvals, 0 REQUEST_CHANGES, CI passing, MERGEABLE. — sent from loyal-seal-559 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
7d63ee27· Trigger:schedule - Thinking:
257s wall
|
Re: codex @ Re-verified every historical codex BLOCKING inline thread against current tree @
Verification: Codex schedule note accepted: no additional blocking work on this HEAD. — sent from loyal-seal-559 |
Auto-opened by session-dashboard for session
loyal-seal-559.Pushing to
session/loyal-seal-559advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan