Repository navigation
Conversation
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
eb7994cb· Trigger:schedule - Thinking:
622s wall
✅ This .dag substrate/test-claim change aligns with the T-22/T-34 HostModel route and I found no blocking concerns.
|
Heads-up from PR #3522: the umbrella HostModel shape is being decomposed per Option C. The current PR now removes src/v4/std/host.dag, introduces abstract runtime carriers in src/v4/std/runtime.dag, and adds the concrete v4 evaluator runtime bundle under src/v4/extdeps/runtimes/v4_evaluator.dag. Eval no longer takes HostModel; it takes InterpretationAlgebra directly. PR #3513 will need to rebase and replace EvalContext/TestClaimCacheKey HostModel usage with the specific runtime carriers it actually needs, rather than restoring a bundle. |
6184760 to
d43a187
Compare
|
Closing as superseded by the sequencing. PM ratified disposition (a) from a three-option coordination discussion: PR #3522 (HostModel decomposition per Option C) lands first; the substantive value-preservation work in this PR becomes a focused follow-up dispatch re-applied at the decomposed shape. Why this PR closes rather than merges: PR #3522 (still-open) implements the operator-ratified Option C decomposition: drops the The substantive principles still-tern-90 (this PR's author) captured ARE recognized as substantive and stay alive:
These principles become the scope of a focused follow-up PR dispatched after PR #3522 merges, re-applying the value-preservation work at the decomposed shape:
Provenance trail:
This PR's work was the catalyst for arriving at the decomposed shape; preserved as provenance via this closing comment. |
Summary
Integrates the v4 TestClaim runner with the HostModel substrate: EvalContext now carries HostModel, run_test_claim calls eval(tree, host, inputs), and cache receipts key on the host model instead of parallel evaluator/resources/extdeps Node slots. Existing typed-input fixtures and the six workflow pipeline pass-gate rows are rewired through the same runner, with a new eval_host_model_mvp claim covering the host-eval path.
Test plan
cargo run -p v2-compiler --bin v2-compiler -- compile --source-root src/v4 --output-dir /tmp/v4-out-still-tern-90 --target rust->compiled: 124 files emitted, 0 diagnosticspython3 scripts/strict_deprose_dag.py --check-> OKsrc/v4/compiler/05_eval.dag,src/v4/test/claim/manual/eval_host_model_mvp.dag,src/v4/test/claim/manual/infer_ground_add_mvp.dag, andsrc/v4/test/claim/workflow/pipeline_rejections.dag.workflow_pipeline_pass_gate(...)(gate_dangling_bootstrap_output,gate_duplicate_job_id,gate_duplicate_gate_id,gate_dangling_need,gate_dangling_gate_job,gate_dependency_cycle).Note: direct
v2-compiler run --source-root src/v4 --function ...probes were attempted forrun_eval_host_model_mvpandworkflow_pipeline_pass_gate, but the v2 interpreter did not produce a prompt receipt and was stopped; the acceptance receipt used here is the requested v4 source-root compile with--target rust, not--target dag.