Repository navigation
Conversation
Add compile anchor for bool decl-ref, never coincidence, and i64 fact-bundle vs std Int64 coincidence target; align typescript E-6 markers with rust; strip accidental merge-conflict markers from cpp slices so v2 bootstrap parse is clean again. Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
f63b3b69· Trigger:schedule - Thinking:
191s wall
BLOCKING (1)
Root Cause
src/v4/extdeps/languages/rust.dagRust exposes only the generic IntScalar kind×width axes, so the test can compile without constructing the Signed+Bits64 primitive point → add a concrete Rust i64 fact-bundle/coincidence carrier or an explicit gated receipt, then have the anchor consume that exact carrier.
| type rust_anchor_never_scalar_classifier = RustScalar | ||
|
|
||
| // §B refinement case — `RustScalar.IntScalar` fact-bundle (kind×width) vs std `Int64` coincidence target (fold-discharge, not alias). | ||
| type rust_anchor_i64_scalar_classifier = RustScalar |
There was a problem hiding this comment.
BLOCKING: The i64 exemplar names the whole RustScalar classifier instead of a concrete Rust i64 fact bundle, so it does not anchor the Rust Reference facts or the Int64 coincidence required by INVARIANTS P1 / modeling-discipline Practice 8.
|
Review metadata
1. Story of the diffThis PR is a small v4 grounding-slice cleanup and exemplar. It resolves conflict-marker residue in the C++ ABI / C++ language-model files, preserving the richer C++ scalar/ABI fact-bundle side rather than the shorter resolver-only side. It also keeps the canonical-B bool grounding shape for Rust and TypeScript: language-specific bool grounding points at the shared 2. Invariant categories1. LAYER MODELCompliant — the PR touches v4 2. INVARIANTS.md + modeling-discipline.mdFinding — Practice 9 / no comment-duplicating ledgers: 3. CODING.mdFinding — comment discipline: 4. TESTING.mdFinding — behavior-driven test discipline / grounding regression coverage: 5. LOCKED DESIGN DECISIONSN/A — no locked design doc is changed. The stale 6. TRACKED vs UNTRACKED DEBTCompliant — the newly added TypeScript canonical-B staging comment is bounded: 2.5. Top-down PM intent reviewFinding — semantic dilution of the grounding exemplar: the thesis-level target is that primitive grounding is structural: target-side primitive types are modeled from the target reference, algebra inhabitance is declared structurally, and mapping is a structural algebra-homomorphism search, not a name/table shortcut ( 3. VerdictREQUEST_CHANGES The canonical-B direction is right, and the bool rows keep single authority. I would not land this as-is because the PR preserves retired |
Summary
rust_primitive_grounding_anchor.dagas the operator-ratified canonical-B compile exemplar for per-primitive grounding/coincidence: bool decl-ref →bool_boolean_algebra,RustNeverprimitive coincidence, and theRustScalar.IntScalarfact-bundle vsstd/integer.Int64coincidence target (fold-discharge, not alias).typescript.dagts_bool_groundingwith the same E-6(b) scaffold marker used across other language slices.rust.dagbool anchor URL; fix accidental merge-conflict markers incpp.dag/cpp_abi.dagthat were breakingv2-compiler compile --source-root src/v4.Why
Operator ratified A-vs-B = B (decl-ref grounding, not
GroundingMapspelling twins).rust.dagon main is the verified shape; this PR materializes the depth bar as a compile anchor so held T-4 Phase-3 work (#3308 typescript, #3309 python) can follow the same pattern.Test plan
v2-compiler compile --source-root src/v4 --output-dir /tmp/v4-out— 80 modules, 0 diagnosticsMade with Cursor