Repository navigation
FRESH Test/Bootstrap-Infra lane (operator Wave-0 GO; #3322 merged 17e98967e; supersedes old swift-ram-178 — do NOT reuse). FIRST ACTION: create your own closeout leaf-task so role doesn't auto-close. WAVE-0 dispatch NOW (keystone-independent): T-19 testgen, T-20 bootstrap (already #3213-advanced), T - #3330
briansrls wants to merge 15 commits into
Conversation
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
396ebd4d· Trigger:schedule - Thinking:
210s wall
BLOCKING (2)
Root Cause
src/v4/workflow/bootstrap.dagT-20 remains scaffold-only with noBootstrapPlanorbootstrap_*declarations → land the bootstrap authority declarations in this PR or narrow the smoke to existing surface.src/v4/workflow/ci.dagCI remains scaffold-only with no bootstrap import or imported names → land the CI bootstrap import/consumer declarations before adding this ratchet.
|
Verified the blocking review against the current code and the base ref. The premise is wrong for both bullets:
The smoke is therefore ratcheting existing |
|
Status note for merge-gate record: current head |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
4c71baad· Trigger:schedule - Thinking:
277s wall
Non-blocking — Strengths
src/v3/compiler/tests/integration/v4_test_bootstrap_wave0_smoke_test.rsStatic review found no concern; focused cargo verification was attempted but sandboxed Cargo registry writes blocked the run.
ROADMAP — Verified
- T-PB-B: The new hand-Rust smoke is paired with a concrete T-PB-B pb_rust_tests_outside_residual_zero deferral and a named generated TestClaim dissolution trigger.
✅ No blocking concerns.
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
3180d223· Trigger:schedule - Thinking:
265s wall
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
c835fd2a· Trigger:schedule - Thinking:
149s wall
|
Verified current #3330 state against the relayed codex item on stale commit |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
49fac375· Trigger:schedule - Thinking:
87s wall
Non-blocking — Strengths
docs/briefs/v3-v4-interim-validation-ledger.mdClassified as design/docs; the new ledger preserves the zero-floor/P5 intent by rejecting new v3 hand-Rust interim validation for v4.
ROADMAP — Verified
- T-PB-B: The disposition aligns with the roadmap target that Rust-authored tests go to zero rather than expanding EXPECTED_HAND_AUTHORED_TEST.
✅ No blocking concerns in the current diff.
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
70145281· Trigger:schedule - Thinking:
96s wall
✅ The remaining docs-only ledger change is consistent with the Pure Bootstrap zero-floor and I found no blocking concerns.
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
13e32bb8· Trigger:schedule - Thinking:
161s wall
Non-blocking — Strengths
docs/briefs/v3-v4-interim-validation-ledger.mdClassified as design/docs; the ledger preserves the Pure Bootstrap zero-floor direction by steering v4 validation away from new hand-Rust integration tests.
ROADMAP — Verified
- T-PB-B: ROADMAP.md keeps Rust-authored tests headed to zero via .dag TestClaim/ExecuteCommand migration, matching the ledger’s preferred receipt shape.
✅ No blocking concerns.
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
ca003b67· Trigger:schedule - Thinking:
75s wall
Non-blocking — Strengths
docs/briefs/v3-v4-interim-validation-ledger.mdThe ledger preserves the Pure Bootstrap 0-floor direction by rejecting new v3 hand-Rust v4 smoke tests and naming .dag/generated receipts instead.
ROADMAP — Verified
- T-PB-B: ROADMAP.md keeps Rust-authored tests headed to zero via ExecuteCommand-backed .dag TestClaim migration, matching the ledger’s preferred receipt shape.
✅ No blocking concerns in this doc-only PR.
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
75862803· Trigger:schedule - Thinking:
86s wall
Non-blocking — Strengths
docs/briefs/v3-v4-interim-validation-ledger.mdDesign/docs-only ledger preserves the Pure Bootstrap 0-floor direction by rejecting new interim v3 hand-Rust v4 smoke debt.
ROADMAP — Verified
- T-PB-B: The preferred receipt keeps v4 validation headed toward
.dagTestClaimor generated coverage, matchingpb_rust_tests_outside_residual_zero.
✅ No blocking concerns in the provided diff.
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
31961963· Trigger:schedule - Thinking:
87s wall
Non-blocking — Strengths
docs/briefs/v3-v4-interim-validation-ledger.mdThe docs-only change preserves the Pure Bootstrap 0-floor direction by rejecting new interim v3 hand-Rust v4 smoke debt in favor of .dag/generated receipts.
ROADMAP — Verified
- T-PB-B: The preferred receipt keeps v4 validation on whole-tree v4 parse/resolve plus generated/TestClaim follow-ups instead of growing EXPECTED_HAND_AUTHORED_TEST.
✅ No blocking concerns in the provided docs-only diff.
|
Review metadata
1. Story of the diffThis PR does not add the Wave-0 v3 Rust smoke test itself; instead it adds 2. Invariant categories
2.5. Top-down PM intent reviewFinding. The PM-level intent is that test and pipeline authority move into 3. VerdictREQUEST_CHANGES The PR avoids adding the bad Rust smoke test, but it replaces that with a forbidden hand-maintained ledger. Delete the new ledger document and keep the disposition in PR review/commit metadata or an existing allowed receipt surface. |
Summary
Records the Rust-to-0 disposition for the proposed Wave-0 v4 test/bootstrap validation receipt. The new v3 hand-Rust
v4_test_bootstrap_wave0_smoke_test.rswas classified as forbidden interim v4-validation debt under the settled policy and dropped before merge.The PR now adds the v3/v4 interim-validation ledger entry for #3330 and keeps the preferred receipt non-census: whole-tree v4 source-root compile / CI plus the substrate authority PRs and generated/TestClaim follow-ups.
Test plan
cargo fmt --all --check— passed.git diff --check— passed.cargo test -p v3-compiler sg0 --test integration— passed remotely.cargo run -p v2-compiler -- compile --source-root src/v4 --target dag --output-dir /tmp/sleek-gull-v4-check— emitted 1 file, 0 diagnostics.SG-0 hand-path delta: 0
SG-0 pairing: none; the proposed
v4_test_bootstrap_wave0_smoke_test.rsv3 hand-Rust path is not shipped, not listed inEXPECTED_HAND_AUTHORED_TEST, and has no INVARIANTS P5 row.