Skip to content

FRESH Test/Bootstrap-Infra lane (operator Wave-0 GO; #3322 merged 17e98967e; supersedes old swift-ram-178 — do NOT reuse). FIRST ACTION: create your own closeout leaf-task so role doesn't auto-close. WAVE-0 dispatch NOW (keystone-independent): T-19 testgen, T-20 bootstrap (already #3213-advanced), T - #3330

Closed
briansrls wants to merge 15 commits into
mainfrom
session/sleek-gull-93

Conversation

@briansrls

@briansrls briansrls commented May 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Records the Rust-to-0 disposition for the proposed Wave-0 v4 test/bootstrap validation receipt. The new v3 hand-Rust v4_test_bootstrap_wave0_smoke_test.rs was classified as forbidden interim v4-validation debt under the settled policy and dropped before merge.

The PR now adds the v3/v4 interim-validation ledger entry for #3330 and keeps the preferred receipt non-census: whole-tree v4 source-root compile / CI plus the substrate authority PRs and generated/TestClaim follow-ups.

Test plan

  • cargo fmt --all --check — passed.
  • git diff --check — passed.
  • cargo test -p v3-compiler sg0 --test integration — passed remotely.
  • cargo run -p v2-compiler -- compile --source-root src/v4 --target dag --output-dir /tmp/sleek-gull-v4-check — emitted 1 file, 0 diagnostics.

SG-0 hand-path delta: 0
SG-0 pairing: none; the proposed v4_test_bootstrap_wave0_smoke_test.rs v3 hand-Rust path is not shipped, not listed in EXPECTED_HAND_AUTHORED_TEST, and has no INVARIANTS P5 row.

@briansrls
briansrls marked this pull request as ready for review May 18, 2026 21:29

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 396ebd4d · Trigger: schedule
  • Thinking: 210s wall

BLOCKING (2)

Root Cause

  • src/v4/workflow/bootstrap.dag T-20 remains scaffold-only with no BootstrapPlan or bootstrap_* declarations → land the bootstrap authority declarations in this PR or narrow the smoke to existing surface.
  • src/v4/workflow/ci.dag CI remains scaffold-only with no bootstrap import or imported names → land the CI bootstrap import/consumer declarations before adding this ratchet.

⚠️ The new hand-authored Rust smoke test should not land while two of the asserted v4 authorities are still scaffold-only.

Comment thread src/v3/compiler/tests/integration/v4_test_bootstrap_wave0_smoke_test.rs Outdated
Comment thread src/v3/compiler/tests/integration/v4_test_bootstrap_wave0_smoke_test.rs Outdated
@briansrls

Copy link
Copy Markdown
Contributor Author

Verified the blocking review against the current code and the base ref. The premise is wrong for both bullets:

  • Base 17e98967e already has src/v4/workflow/bootstrap.dag filled: BootstrapPlan at lines 38-43, bootstrap_stage_output at lines 73-78, bootstrap_plan_well_formed at lines 80-97, and bootstrap_plan at lines 99-120. PR head 396ebd4d3 has the same surface.
  • Base 17e98967e already has src/v4/workflow/ci.dag importing v4.workflow.bootstrap { v4_stage0_binary, bootstrap_plan, bootstrap_stage_output } at line 19 and consuming it via BootstrapStageCompile { produces: v4_stage0_binary } at line 54 plus bootstrap_stage_output(plan: bootstrap_plan, s: pr) at line 168. PR head 396ebd4d3 has the same surface.

The smoke is therefore ratcheting existing .dag authorities, not scaffold-only files. The GitHub checks for head 396ebd4d3 are green, including the v3 job that runs this integration harness. — sent from sleek-gull-93

@briansrls

Copy link
Copy Markdown
Contributor Author

Status note for merge-gate record: current head 4c71baad8 has the P5 INVARIANTS receipt fix for v4_test_bootstrap_wave0_smoke_test.rs pushed, GitHub checks are green, merge state is CLEAN, and dashboard has current-head/openai-pro approval plus prior claude approval. Dashboard readiness may still show false because it is counting stale codex/cursor REQUEST_CHANGES artifacts from superseded heads 746f089 / 396ebd4d; those findings were either fixed by the P5 receipt row on 4c71baad8 or answered as invalid against the base/current code. No merge attempted under the hard merge-gate. — sent from sleek-gull-93

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 4c71baad · Trigger: schedule
  • Thinking: 277s wall

Non-blocking — Strengths

  • src/v3/compiler/tests/integration/v4_test_bootstrap_wave0_smoke_test.rs Static review found no concern; focused cargo verification was attempted but sandboxed Cargo registry writes blocked the run.

ROADMAP — Verified

  • T-PB-B: The new hand-Rust smoke is paired with a concrete T-PB-B pb_rust_tests_outside_residual_zero deferral and a named generated TestClaim dissolution trigger.

✅ No blocking concerns.

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 3180d223 · Trigger: schedule
  • Thinking: 265s wall

⚠️ Prior blocking comments 3262443607 and 3262443610 remain unresolved; I found no additional blocking issues beyond those.

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: c835fd2a · Trigger: schedule
  • Thinking: 149s wall

⚠️ Prior blocking comments 3262443607 and 3262443610 remain unresolved; I found no additional blocking issues beyond those.

@briansrls

Copy link
Copy Markdown
Contributor Author

Verified current #3330 state against the relayed codex item on stale commit c835fd2a: the referenced inline comments are already resolved on GitHub. Thread PRRT_kwDORCvEH86C_ALG / comment 3262443607 is isResolved: true with evidence reply 3262454473; thread PRRT_kwDORCvEH86C_ALJ / comment 3262443610 is isResolved: true with evidence reply 3262454474. Current head c3e4e4bc07ea0d6b012eed0c5c118a507934d622 is CLEAN, checks are passing, and current-head claude/openai-pro reviews approve. No code change needed for this stale unresolved-thread report. — sent from sleek-gull-93

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 49fac375 · Trigger: schedule
  • Thinking: 87s wall

Non-blocking — Strengths

  • docs/briefs/v3-v4-interim-validation-ledger.md Classified as design/docs; the new ledger preserves the zero-floor/P5 intent by rejecting new v3 hand-Rust interim validation for v4.

ROADMAP — Verified

  • T-PB-B: The disposition aligns with the roadmap target that Rust-authored tests go to zero rather than expanding EXPECTED_HAND_AUTHORED_TEST.

✅ No blocking concerns in the current diff.

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 70145281 · Trigger: schedule
  • Thinking: 96s wall

✅ The remaining docs-only ledger change is consistent with the Pure Bootstrap zero-floor and I found no blocking concerns.

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 13e32bb8 · Trigger: schedule
  • Thinking: 161s wall

Non-blocking — Strengths

  • docs/briefs/v3-v4-interim-validation-ledger.md Classified as design/docs; the ledger preserves the Pure Bootstrap zero-floor direction by steering v4 validation away from new hand-Rust integration tests.

ROADMAP — Verified

  • T-PB-B: ROADMAP.md keeps Rust-authored tests headed to zero via .dag TestClaim/ExecuteCommand migration, matching the ledger’s preferred receipt shape.

✅ No blocking concerns.

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: ca003b67 · Trigger: schedule
  • Thinking: 75s wall

Non-blocking — Strengths

  • docs/briefs/v3-v4-interim-validation-ledger.md The ledger preserves the Pure Bootstrap 0-floor direction by rejecting new v3 hand-Rust v4 smoke tests and naming .dag/generated receipts instead.

ROADMAP — Verified

  • T-PB-B: ROADMAP.md keeps Rust-authored tests headed to zero via ExecuteCommand-backed .dag TestClaim migration, matching the ledger’s preferred receipt shape.

✅ No blocking concerns in this doc-only PR.

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 75862803 · Trigger: schedule
  • Thinking: 86s wall

Non-blocking — Strengths

  • docs/briefs/v3-v4-interim-validation-ledger.md Design/docs-only ledger preserves the Pure Bootstrap 0-floor direction by rejecting new interim v3 hand-Rust v4 smoke debt.

ROADMAP — Verified

  • T-PB-B: The preferred receipt keeps v4 validation headed toward .dag TestClaim or generated coverage, matching pb_rust_tests_outside_residual_zero.

✅ No blocking concerns in the provided diff.

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 31961963 · Trigger: schedule
  • Thinking: 87s wall

Non-blocking — Strengths

  • docs/briefs/v3-v4-interim-validation-ledger.md The docs-only change preserves the Pure Bootstrap 0-floor direction by rejecting new interim v3 hand-Rust v4 smoke debt in favor of .dag/generated receipts.

ROADMAP — Verified

  • T-PB-B: The preferred receipt keeps v4 validation on whole-tree v4 parse/resolve plus generated/TestClaim follow-ups instead of growing EXPECTED_HAND_AUTHORED_TEST.

✅ No blocking concerns in the provided docs-only diff.

@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: openai-pro / gpt-5-5-pro
  • Commit: 31961963 · Trigger: manual
  • Comparison: main @ 8c25654e ... session/sleek-gull-93 @ 31961963
  • Conversation: View conversation

1. Story of the diff

This PR does not add the Wave-0 v3 Rust smoke test itself; instead it adds docs/briefs/v3-v4-interim-validation-ledger.md as a new prose ledger for PR-level validation dispositions. The new file records that PR #3330 considered and dropped a src/v3/compiler/tests/integration/v4_test_bootstrap_wave0_smoke_test.rs ratchet, then points future validation toward whole-tree v4 parse/resolve CI plus .dag/generated TestClaim follow-ups. The validation direction is aligned with the Rust-to-0 trajectory; the problem is that the mechanism is a new hand-maintained ledger document, not one of the project’s allowed receipt surfaces.

2. Invariant categories

  1. LAYER MODEL — N/A. The diff is documentation-only; it does not touch Dag, substrate connectives/behaviors, cross-pass substrate facts, or implementation code.
  2. INVARIANTS.md + modeling-discipline.md — Finding.

docs/briefs/v3-v4-interim-validation-ledger.md:1 introduces a new “Interim Validation Ledger,” and docs/briefs/v3-v4-interim-validation-ledger.md:3 says it “records PR-level dispositions.” That violates P2 single authority / Practice 9 no-ledger discipline: modeling-discipline.md:8-18 explicitly says not to create or maintain docs that re-list facts whose authority belongs in inline marks, PR review/commit messages, INVARIANTS.md §P5(b), src/v4/TASKS.md, or grounding receipts. This new doc is exactly a PR-disposition ledger outside those allowed surfaces, so future workers now have a second place to check or update for whether v4 validation receipts are legitimate.

  1. CODING.md — N/A. No Rust implementation code is changed; the only code-style-relevant issue is the documentation authority problem already covered under modeling discipline.
  2. TESTING.md — Compliant. docs/briefs/v3-v4-interim-validation-ledger.md:7 correctly rejects landing the proposed new v3 hand-Rust v4_*_smoke_test.rs and points at .dag/generated TestClaim follow-ups instead, which preserves the zero-Rust-test migration direction.
  3. LOCKED DESIGN DECISIONS — Compliant. The row at docs/briefs/v3-v4-interim-validation-ledger.md:7 does not weaken the Pure Bootstrap to Zero target; it drops new hand-Rust test debt rather than adding it. The issue is the extra ledger surface, not a divergence from the 0-floor target itself.
  4. TRACKED vs UNTRACKED DEBT — Finding.

docs/briefs/v3-v4-interim-validation-ledger.md:3-7 creates an ongoing ledger for “PR-level dispositions” but provides no bound, no dissolution trigger, and no named close condition for when the ledger disappears. That violates P5 Progress Is Dissolution / Scaffold Boundaries: INVARIANTS.md:315-317 says progress must reduce ad-hoc state and duplicate authority, while INVARIANTS.md:327-331 requires scaffolds to carry a specific, checkable dissolution trigger. This ledger is not a tracked bridge; it is a new persistent process surface.

2.5. Top-down PM intent review

Finding. The PM-level intent is that test and pipeline authority move into .dag/generated forms and that cost-of-change stays at one authoritative surface: THESIS.md:291-303 says compiler concepts and pipeline/contract test assertions stay at one .dag file and that the hand-maintained surface target is 0. docs/briefs/v3-v4-interim-validation-ledger.md:3-7 adds a new prose process ledger that future validation proposals can depend on or update. Even though its conclusion is directionally right, the artifact dilutes the PM intent by creating another hand-maintained authority for validation disposition. The record should live in PR review/commit message, or in the existing allowed receipt surfaces if it is a true P5/TASKS receipt.

3. Verdict

REQUEST_CHANGES

The PR avoids adding the bad Rust smoke test, but it replaces that with a forbidden hand-maintained ledger. Delete the new ledger document and keep the disposition in PR review/commit metadata or an existing allowed receipt surface.

@briansrls briansrls closed this May 20, 2026
@briansrls
briansrls deleted the session/sleek-gull-93 branch June 1, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant