Repository navigation
[codex] Move LLVM instruction cost table to v4 cost lens - #3300
Merged
Merged
Conversation
briansrls
marked this pull request as ready for review
May 18, 2026 07:16
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
llvm_instruction_costout ofsrc/v4/extdeps/languages/llvm_ir.dagand intosrc/v4/lens/cost.dag, so the LLVM instruction cost table is owned by the cost lens rather than the LLVM IR shape model.v4/lens/cost.dagand is not still listed or defined inllvm_ir.dag.Why
P9 in
docs/audit/dissolution-inventory.mdidentifiedllvm_instruction_costas a property-projection table that should be owned bylens/cost.dag/ T-12. Keeping it inllvm_ir.dagmade LLVM IR both the instruction-shape authority and the cost-table authority.Validation
cargo test -p v3-compiler v4_lens_cost_owns_llvm_instruction_cost_table --test integrationNote: a semantic compile smoke for
src/v4/lens/cost.dagis not viable yet because the current v4 lowering path rejects block-bodied match functions and single-file v4 sibling imports; the ratchet therefore pins the single-authority placement directly.