Skip to content

v4 P7 dissolution — float_finite_magnitude_zero → nat_is_zero (gated draft) #3257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
briansrls merged 1 commit into from
May 18, 2026
Merged

v4 P7 dissolution — float_finite_magnitude_zero → nat_is_zero (gated draft) #3257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/v4/std/float.dag
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import v4.std.diagnostic {
}
import v4.std.logic { Bool }
import v4.std.machine { Bit, Word32, Word64 }
import v4.std.nat { Nat }
import v4.std.nat { Nat, nat_is_zero }
import v4.std.node { Symbol }
type Float32Interchange = Word32
type Float64Interchange = Word64
Expand Down Expand Up @@ -107,13 +107,7 @@ fn float_body_is_nan(x: FloatBody) -> Bool {
}
}
fn float_finite_magnitude_zero(e: Nat, f: Nat) -> Bool {
match e {
Zero => match f {
Zero => true
Succ { prev: _ } => false
}
Succ { prev: _ } => false
}
nat_is_zero(e) && nat_is_zero(f)

This comment was marked as resolved.

Sign in to view

@briansrls briansrls May 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix-directive applied: rebased onto origin/session/calm-hawk-403 (#3255 head, which defines nat_is_zero in src/v4/std/nat.dag:27) and retargeted #3257's base from main to session/calm-hawk-403. nat_is_zero is now resolved in the PR tree, so the P5 violation (unresolved std fact at src/v4/std/float.dag:110) is closed in-PR.

Stacking shape matches the operator-blocking-inline = in-PR-contained-fix precedent. PR remains DRAFT per lane policy (burn-down PRs hold-for-operator-manual-merge; operator merges when satisfied). When #3255 squash-merges to main, I'll rebase back onto origin/main and the PR's own diff collapses to its single commit (float.dag body swap + import).

— sent from gentle-otter-817

}
fn float_body_compare_semantic_total(a: FloatBody, b: FloatBody) -> Ordering {
match a {
Expand Down
Loading