Repository navigation
typescript: regate D2 scaffolds to fact bundles - #3251
Merged
Merged
Conversation
briansrls
changed the title
briansrls
marked this pull request as ready for review
May 18, 2026 02:34
briansrls
commented
May 18, 2026
briansrls
left a comment
briansrls
left a comment
Contributor
Author
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
47aadbf5· Trigger:schedule - Thinking:
161s wall
Non-blocking — Strengths
src/v4/extdeps/languages/typescript.dagThe scaffold is now bounded to the pre-rework primitive rows and names a concrete T-4 fact-bundle Phase-3 dissolution trigger without adding a new GroundingMap or alias fan-out authority.
✅ Mixed .dag model plus Rust test-comment update; no blocking concerns found.
briansrls
added a commit
that referenced
this pull request
May 18, 2026
Addresses codex BLOCKING review on #3254: the row described #3251's in-flight regate in landed present-tense. Reframed as a disposition established 2026-05-18 with #3251 explicitly OPEN / not-yet-merged and the regate/reseed in pending tense, so the decision log stays a truthful live-state authority (INVARIANTS P1/P2, Practice 9). Date 2026-05-18 retained — authoritative per system clock and all commit/dashboard timestamps. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
briansrls
commented
May 18, 2026
briansrls
left a comment
briansrls
left a comment
Contributor
Author
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
87957b96· Trigger:schedule - Thinking:
171s wall
Non-blocking — Strengths
src/v4/extdeps/languages/typescript.dagThe changed scaffold wording now names the post-D2 T-4 fact-bundle Phase-3 dissolution trigger and keeps GroundingMap/alias fan-out from becoming a new local authority.
✅ The PR is comment-only and the regated TypeScript scaffold language is bounded, traced to the post-D2 fact-bundle lane, and does not introduce a new modeling authority.
briansrls
commented
May 18, 2026
briansrls
left a comment
briansrls
left a comment
Contributor
Author
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
1af2ad67· Trigger:schedule - Thinking:
190s wall
Non-blocking — Strengths
src/v4/extdeps/languages/typescript.dagThe updated scaffold status is bounded to the TypeScript primitive surface and names the T-4 fact-bundle Phase-3 dissolution trigger required by INVARIANTS.md P5.
✅ No blocking issues found.
briansrls
added a commit
that referenced
this pull request
May 18, 2026
Addresses cursor REQUEST_CHANGES on #3254. #3251 (23061e2) merged into main: typescript.dag is now strict-de-prosed + 🟡-gated and its two coproducts cite `DECISIONS.md TS-D2`, a row that did not exist. Renames the slug P4-TS-REGATE → TS-D2 so the merged in-file pointers resolve, and rewrites the row to current truth: #3251 LANDED (not OPEN/future); 🟢 terminal = the two TS-native ECMA-262 coproducts; 🟡 remaining = TsBoolean alias + unmodeled number/string/symbol facts; named trigger node …71ec74f4-080 + feeder gates. Removes stale "OPEN/will re-gate/in-flight/ post-#3251-merge follow-up" prose. Ledger-only; no typescript.dag edit (already merged via #3251). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
briansrls
added a commit
that referenced
this pull request
May 18, 2026
* v4 P4 — DECISIONS.md typescript D2→fact-bundle regate ledger row Per-language accountability slice for the D2-REVERSAL impact-map `typescript` rework entry. Records the 🟡-gated disposition, names PR #3251 as the in-file regate carrier, and ties dissolve-on-arrival to upstream P4 node adhoc-71ec74f4-080 + the five T-4 feeder gates (P1-KEYSTONE cleared @77b9e7d72). Ledger slice only — no parallel edit to typescript.dag (owned by #3251 per jolly-ibex-599 ruling). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * P4-TS-REGATE: pending/tracked framing — not landed present-tense Addresses codex BLOCKING review on #3254: the row described #3251's in-flight regate in landed present-tense. Reframed as a disposition established 2026-05-18 with #3251 explicitly OPEN / not-yet-merged and the regate/reseed in pending tense, so the decision log stays a truthful live-state authority (INVARIANTS P1/P2, Practice 9). Date 2026-05-18 retained — authoritative per system clock and all commit/dashboard timestamps. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * TS-D2: reconcile ledger row to post-#3251-merge main state Addresses cursor REQUEST_CHANGES on #3254. #3251 (23061e2) merged into main: typescript.dag is now strict-de-prosed + 🟡-gated and its two coproducts cite `DECISIONS.md TS-D2`, a row that did not exist. Renames the slug P4-TS-REGATE → TS-D2 so the merged in-file pointers resolve, and rewrites the row to current truth: #3251 LANDED (not OPEN/future); 🟢 terminal = the two TS-native ECMA-262 coproducts; 🟡 remaining = TsBoolean alias + unmodeled number/string/symbol facts; named trigger node …71ec74f4-080 + feeder gates. Removes stale "OPEN/will re-gate/in-flight/ post-#3251-merge follow-up" prose. Ledger-only; no typescript.dag edit (already merged via #3251). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-gates the TypeScript D2-shaped scaffold blocks identified by PR #3243's dissolution inventory. The cancelled
GroundingMap/ alias-row arrivals now point at the post-D2-reversalfeature: T-4 fact-bundle Phase-3 rework, with the feeder gate and dissolve-on-arrival obligation stated insrc/v4/extdeps/languages/typescript.dag.Also updates the TypeScript smoke-test labels so SG-0 no longer describes the file as a D2-resolver slice.
Test plan
cargo test -p v3-compiler --test integration v4_extdeps_typescript_dag_compiles— passed via BuildBuddy.git diff --check— passed.