Repository navigation
v4 extdeps: thread OS effect resources - #3217
Merged
briansrls merged 1 commit intoMay 17, 2026
Merged
Conversation
briansrls
changed the title
briansrls
marked this pull request as ready for review
May 16, 2026 23:59
briansrls
commented
May 17, 2026
briansrls
left a comment
briansrls
left a comment
Contributor
Author
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
b4b368e7· Trigger:schedule - Thinking:
182s wall
BLOCKING (2)
Root Cause
src/v4/extdeps/process.dagEffect-resource threading modeled ProcessTable only on spawn output → make wait/capture result carriers include the advanced ProcessTable alongside the advanced Process/stdout/stderr.
| type SpawnProcessResult = Outcome<SpawnedProcess> | ||
|
|
||
| type WaitProcessRequest { | ||
| table: ProcessTable |
Contributor
Author
There was a problem hiding this comment.
BLOCKING: Adding the ProcessTable input to wait without returning an advanced ProcessTable silently drops the POSIX wait/reap table-state fact, violating facts-flow-forward / INVARIANTS P2.
Contributor
Author
There was a problem hiding this comment.
| } | ||
|
|
||
| type CaptureProcessRequest { | ||
| table: ProcessTable |
Contributor
Author
There was a problem hiding this comment.
BLOCKING: Adding the ProcessTable input to capture without returning an advanced ProcessTable has the same table-state drop for the wait/reap performed by capture, violating facts-flow-forward / INVARIANTS P2.
Contributor
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Conforms the v4 OS extdep operation signatures to the ratified
lens/effect.dagB3/B-5 model: effects are explicit parameters, returned-modified-resource is write, and returned-derived-value is read. This PR is intentionally based on #3209 so the diff is only the effect-resource follow-up.Filesystem { label: String }and threads it through file-system read/write/list/kind requests.WriteFileResulttoOutcome<Filesystem>.ProcessTable { label: String }and threads it through process spawn/wait/capture requests.Outcome<SpawnedProcess>so the modified process table and spawned process move together.Test plan
cargo fmt --all --checkPASScargo run -p v2-compiler -- compile --source-root src/v4 --output-dir <tmp> --target dagPASS: 64 modules resolved, 0 diagnosticsNotes
Depends on #3209 for the process wait/capture advanced-
Processcontract reconcile.