Repository navigation
r3-path-b-brief-4: add DB-10 data value receipts - #3145
Conversation
bd760f1 to
e77e54d
Compare
2d4adee to
05bf81c
Compare
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
05bf81c9· Trigger:schedule - Thinking:
218s wall
BLOCKING (2)
Root Cause
src/v3/compiler/src/lower.rsthe new DB-10 diagnostic helper copied a stale singular-correction API shape → constructResolveError { name, span, fixes: Vec::new() }or an actualVec<Correction>.src/v3/compiler/tests/integration/m2_feature_parity_test.rsDB-10 acceptance is being ratcheted in hand Rust without the required Pure Bootstrap receipt → add one PR-body or planning-artifact receipt naming the T-PB-B/ROADMAP deferral, SG-0 shrink, or deleted scaffold path.
| Diagnostic::ResolveError { | ||
| name, | ||
| span: span.clone(), | ||
| correction: crate::diagnostics::Correction::deferred_for_diagnostic_class( |
There was a problem hiding this comment.
BLOCKING: Diagnostic::ResolveError has a fixes: Vec<Correction> field, not correction, and Correction::deferred_for_diagnostic_class does not exist, so this new fail-closed path cannot compile.
| } | ||
|
|
||
| #[test] | ||
| fn db_10_data_value_inline_demo() { |
There was a problem hiding this comment.
BLOCKING: This expands hand-authored Rust under src/v3/ without a changed P5 receipt artifact; INVARIANTS.md P5 requires exactly one checkable receipt for new or expanded Rust tests.
76643bb to
03502d3
Compare
|
Verified against current branch head |
Summary
Adds the DB-10 acceptance receipt for compile-time
datavalues now that Phase A showed the implementation is already present at HEAD. The integration tests are split by claim while preserving thedb_10_data_value_inline_demoreceipt namespace:data answer: Int = 42inlines as42 + 1across Rust, Python, and Go emissiondata config: Config = { host: "h", port: 8080 }inlinesconfig.hostas"h"across Rust, Python, and Go emission and does not lower to aFieldProject<host>transformx.foofails closed withInt has no field fooThe lowering change is the dissolution consumer for DB-10: when a
data-rooted field path cannot resolve through the compile-timeValueBody, it emits a typedResolveErrordiagnostic instead of silently falling through to the generic runtime field-path lowering.P5 / Pure Bootstrap Receipt
src/v3/compiler/tests/integration/m2_feature_parity_test.rs::db_10_data_value_inline_demo::*.docs/design-m2-feature-parity.md, landed by docs(r3): rust retirement catalogue + emit.rs modeling doc (format drafts) #3139 and now checked by this PR.analyze_symbolic_cost_dimension; it does not cement a new Rust authority path.Test plan
cargo test -p v3-compiler --test integration db_10_data_value_inline_demo -- --nocapture— passed (3 tests)cargo test -p v3-compiler --test integration 3a2 -- --nocapture— passed (14 tests)Worker attestation