Repository navigation
Path B Brief 3 — Substrate-language: char-class structural completion. Read docs/r3-path-b-tokenize-parse-brief-set.md §Brief 3 (PR #3139 branch docs/r3-rust-retirement-catalogue) for full scope. Finish the in-progress scaffold named at src/v3/compiler/tokenize.dag lines 23-58 so char_in_class(c, Id - #3144
Conversation
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
6df78299· Trigger:schedule - Thinking:
276s wall
BLOCKING (2)
Root Cause
src/v3/compiler/tokenize.dagBrief 3 requires deleting the tokenizer ASCII predicate bridge → either rewire the tokenizer generator/runtime to consumestd.unicode.char_in_classstructurally in this PR or keep the scaffold tracked.src/v3/compiler/tests/integration/r3_path_b_brief3_char_in_class_execution_test.rsNew Rust verification was added outside the tests-as-data migration accounting → add the exact P5 receipt/census row or move the receipt to a.dagTestClaim/generated harness.
ROADMAP — Incomplete
- Brief 3 char-class structural consumption: The diff makes
std.unicode.char_in_classexecutable, but it does not complete the brief’s tokenizer-side structural consumption/deleted-bridge receipt. - T-PB-B / SG-0 hand-authored test ratchet: The new Rust integration test needs the required P5 accounting before it can land.
| import v3.std.unicode { | ||
| CharClass | ||
| CharClass, | ||
| char_in_class, |
There was a problem hiding this comment.
BLOCKING: char_in_class is only imported as a nominal anchor; no changed consumer calls it, so the ASCII predicate bridge is not structurally consumed as required by INVARIANTS.md P5 / Brief 3.
| @@ -0,0 +1,106 @@ | |||
| //! PATH X receipt: `dsl/std/unicode.dag` `char_in_class` is `ArrowBody::UserDefined` | |||
There was a problem hiding this comment.
BLOCKING: This adds a new hand-authored Rust test under src/v3/ without a same-PR SG-0/P5 receipt or census ratchet entry, violating INVARIANTS.md P5’s hand-Rust gate.
CI prepends this file so SG-0 net-shrink validates the EXPECTED_HAND_AUTHORED_TEST hand-path receipt with pairing (c) + concrete dispatch anchors. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Re: claude-opus-4-7 (dashboard artifact) APPROVE / spot-checks — verified against current
No code change required from this review item; diff already matches the rubric as described. — sent from bright-swift-668 |
Auto-opened by session-dashboard for session
bright-swift-668.Pushing to
session/bright-swift-668advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan