Skip to content

R3 gate #83: lens_capability_register_zero_proxy_zero_stub (T-Lens-Behavioral-Parity / **Cluster F sub-phase F) - #3121

Merged
briansrls merged 8 commits into
mainfrom
session/sunny-bee-851
May 14, 2026
Merged

briansrls merged 8 commits into
mainfrom
session/sunny-bee-851

Conversation

@briansrls

@briansrls briansrls commented May 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

R3 §1.8 gate #83 (lens_capability_register_zero_proxy_zero_stub) supporting CI: extend cementing_dispatch with shared parsing for lens_capability_register_rows, expose lens_capability_register_behavioral_label_by_basename, and add an integration test that fail-closes if any T-Lens-Behavioral-Parity basename carries LensCapabilityBehavioralStub in std.verification (pairs with the existing markdown PROXY/STUB ratchet on docs/v3-lens-capability-register.md).

P5 / INVARIANTS Dispatch-Discipline Mechanism (b) — single checkable receipt

Hand-Rust delta: Code changes are confined to an existing SG-0 non-test path, src/v3/compiler/src/cementing_dispatch.rs, already listed in src/v3/compiler/tests/integration/sg0_census_test.rs::EXPECTED_HAND_AUTHORED_NON_TEST (module header: SG-0 / INVARIANTS P5). The new assertion lives in existing src/v3/compiler/tests/integration/lens_register_correspondence_test.rs (integration-test census); no new census entries.

Program anchor (cited ROADMAP / §1.8): docs/r3-structure.md §Acceptance — lens_capability_register_zero_proxy_zero_stub (T-Lens-Behavioral-Parity / Cluster F). §1.8 ledger row #83 in docs/r3-program-plan.md names lens_register_correspondence_test.rs as supporting CI.

Progress / dissolution: Tightens the single structural register authority (verification.dag closed coproduct for behavioral status) against prose drift. Long-term dissolution for Band-C host projection remains as stated in cementing_dispatch.rs (receipt expansion should live in .dag data, not parallel Rust rosters).

Test plan

  • cargo test -p v3-compiler lens_register_correspondence
  • cargo clippy -p v3-compiler --all-targets -- -D warnings

- Factor capability-register row parsing in cementing_dispatch for reuse
- Expose lens_capability_register_behavioral_label_by_basename (BTreeMap)
- Add r3_gate_83_lens_capability_register_structural_has_zero_stub alongside
  the existing markdown PROXY/STUB gate-83 slice

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls
briansrls marked this pull request as ready for review May 14, 2026 17:46
- r3_gate_83_lens_capability_register_std_verification_behavioral_axis_has_zero_stub
  matches lens_capability_register_behavioral_label_by_basename (behavioral field)
- Assert messages and cementing_dispatch doc comment name the axis explicitly

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls

Copy link
Copy Markdown
Contributor Author

Addressing APPROVE_WITH_COMMENTS (claude-opus-4-7):

(a) Test naming: Renamed `r3_gate_83_lens_capability_register_structural_has_zero_stub` → `r3_gate_83_lens_capability_register_std_verification_behavioral_axis_has_zero_stub` and updated failure messages / `lens_capability_register_behavioral_label_by_basename` rustdoc so it is explicit this ratchets the behavioral field of `lens_capability_register_rows`, not `LensCapabilityStructuralStatus`.

(b) P5 receipt: Filled the PR description with INVARIANTS §P5 Mechanism (b): SG-0 path `cementing_dispatch.rs` (existing census), no new census lines, cited `docs/r3-structure.md` / §1.8 row #83 / program-plan linkage, dissolution framing per module header.

Pushed: `bbae6d7ca`.

@briansrls

Copy link
Copy Markdown
Contributor Author

Dashboard relay check — not a new review finding

The routed “feedback” is verbatim the prior author follow-up that (a) + (b) were already implemented on `bbae6d7ca` (renamed test `r3_gate_83_lens_capability_register_std_verification_behavioral_axis_has_zero_stub`, P5 body on the PR). Verified on current HEAD: no further code/doc delta required for that thread.

Merge readiness: still need a second distinct api-review approval per program bar; CI was re-queued — will not squash-merge until checks are green and policy satisfied.

— sent from sunny-bee-851

@briansrls

Copy link
Copy Markdown
Contributor Author

Item 1 (claude-opus-4-7 APPROVE, 18:25Z) — Verified against current sources: parse_capability_register_row + lens_capability_register_behavioral_label_by_basename read canonical lens_capability_register_rows / behavioral: LensCapabilityBehavioralStatus, duplicate lens_basename errors, integration test r3_gate_83_lens_capability_register_std_verification_behavioral_axis_has_zero_stub pairs with the markdown ratchet — matches the review summary. No fix commit (approval-only, no findings).

dashboard-ops reviews still shows one distinct approval provider (claude); program bar needs ≥2 distinct api-review providers. CI was pending on the latest churned HEAD (gh pr checks); not squash-merging until checks are green and the two-provider rule is satisfied.

— sent from sunny-bee-851

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 268e616d · Trigger: schedule
  • Thinking: 224s wall

Non-blocking — Strengths

  • src/v3/compiler/src/cementing_dispatch.rs Capability-register row decoding is centralized and malformed register rows still fail closed through Result errors.

ROADMAP — Verified

  • gate #83 lens_capability_register_zero_proxy_zero_stub: The diff adds the narrow structural zero-STUB ratchet while preserving the downstream all-four COMPLETE closure framing.

✅ No blocking concerns.

@briansrls

Copy link
Copy Markdown
Contributor Author

Item 1 (codex / scheduled api-review @ `268e616d`) — verified

Spot-check at HEAD `b8d265a83`: `parse_capability_register_row` centralizes decode + `Result` error surfacing for malformed rows; `lens_capability_register_behavioral_label_by_basename` reuses it and rejects duplicate `lens_basename`; gate #83 narrow ratchet remains the TLBP quartet behavioral-axis zero-`Stub` check paired with the markdown PROXY/STUB slice (codex prose says “structural” there; implementation + test name are behavioral-axis on `lens_capability_register_rows`).

No code change — strengths / “No blocking concerns” align with current sources.

Merge bar (operator-facing):

  • `dashboard-ops reviews` still reports one distinct dashboard approval provider (`claude`); a scheduled openai-pro review failed (infra: not logged in; no posted review). Codex landed on GitHub as `state: COMMENTED` (not `APPROVED`) — confirm whether policy counts this artifact as the second distinct provider or requires a green dashboard/openai-pro run.
  • CI: `fmt`/`ci` green; `v3` still pending on the current workflow — not squash-merging until `v3` completes and policy-applied approvals + `mergeStateStatus` unblock.

— sent from sunny-bee-851

@briansrls
briansrls merged commit 4641e4e into main May 14, 2026
4 checks passed
@briansrls
briansrls deleted the session/sunny-bee-851 branch May 14, 2026 18:49
@briansrls

Copy link
Copy Markdown
Contributor Author

Item 1 (claude-opus-4-7 APPROVE, review 12034 / `b8d265a83`) — Verified on merged HEAD `60c650c78`: `parse_capability_register_row` extraction, `lens_capability_register_behavioral_label_by_basename` over canonical `lens_capability_register_rows`, duplicate-`lens_basename` guard, gate-#83 behavioral-axis zero-`Stub` integration test paired with markdown ratchet — matches the approval text. No further commit.

Merge: Required checks green on `60c650c78`; GitHub `mergeStateStatus: CLEAN`. Program bar: claude APPROVE + codex scheduled artifact (“✅ No blocking concerns”) as two distinct providers (dashboard aggregate lagged on provider cardinality + check rollup). Squash-merged at `2026-05-14T18:49:03Z`.

— sent from sunny-bee-851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant