Skip to content

[codex] Pin Anthropic response role wire serialization #3093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
briansrls merged 4 commits into from
May 14, 2026
Merged

[codex] Pin Anthropic response role wire serialization #3093

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee82eaa
Pin Anthropic response role wire serialization
briansrls May 14, 2026
a3215b7
Merge remote-tracking branch 'origin/main' into session/zesty-ferret-76
briansrls May 14, 2026
a1c06e7
Merge remote-tracking branch 'origin/main' into session/zesty-ferret-76
briansrls May 14, 2026
de0c5b4
Merge remote-tracking branch 'origin/main' into session/zesty-ferret-76
briansrls May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/v3/compiler/tests/integration/anthropic_messages_wire_demo_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ struct AnthropicMessagesRequest {
system: Option<String>,
}

#[derive(Debug, Clone, PartialEq, Eq, Deserialize)]
#[derive(Debug, Clone, PartialEq, Eq, Deserialize, Serialize)]

@briansrls briansrls May 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BLOCKING: INVARIANTS.md P5 requires a PR-body or changed-planning receipt for expanded hand-written Rust under src/v3, and this PR's provided material does not include the required deleted-scaffold, SG-0-shrink, or ROADMAP-lane deferral receipt.

@briansrls briansrls May 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid finding. I updated the PR body with a dedicated ## P5 Receipt section: T-Anthropic-Wire deferral receipt for extending the existing hand-written Rust Anthropic wire ratchet by one serde assertion, with dissolution remaining on the lane-owned generated/structural wire consumer path cited by the program-plan gate #68 row. No code change was needed because the missing artifact was the PR-body receipt. — sent from zesty-ferret-76

#[serde(rename_all = "snake_case")]
enum ResponseRole {
Assistant,
Expand Down Expand Up @@ -319,6 +319,11 @@ fn anthropic_messages_wire_demo_is_hermetic() {
json!("assistant"),
"assistant request role must serialize to the Anthropic wire string"
);
assert_eq!(
serde_json::to_value(ResponseRole::Assistant).expect("response role serializes"),
json!("assistant"),
"unit response role must serialize to the Anthropic wire string, not an object"
);

let request = AnthropicMessagesRequest {
model: "claude-3-5-sonnet-latest".to_string(),
Expand Down
Loading