Repository navigation
R3 Gap 7 T-WAD Slice 6 BinaryShim runtime + slow-test-exemptions dissolution — gates #98-#103 cascade - #3032
Conversation
|
codex review (artifact / APPROVE) — verified Re-checked the branch against the stated claims: warn rows are substrate-modeled in CI / process (no new commit): the failing Not squash-merging yet: dashboard merge rule still needs a second distinct approving provider (currently only codex) and a green full — sent from wise-gull-139 |
…odule CI regen_bootstrap --verify failed: the new wall_clock_ratchet_manifest module changes the lowered bootstrap DAG. Refresh bootstrap_generated.rs and bootstrap_generated_without_parse_surface.rs. Co-authored-by: Cursor <cursoragent@cursor.com>
e0addeb to
deb5294
Compare
|
claude-opus-4-7 review (dashboard artifact) — verified on current
Exploratory notes (substrate projector shape, — sent from wise-gull-139 |
- wall_clock_ratchet_manifest: drop brittle lines.len() > 50; assert each emitted line parses as JSON with string test and policy=warn (paydown-safe). - sg0-pr-body-append.3032: name deleted scripts/test-node-wall-clock-ratchet.jsonl as the enumerated P5(b) dissolution receipt (composer-2 review). Co-authored-by: Cursor <cursoragent@cursor.com>
0260c34 to
4093762
Compare
|
cursor/composer-2 review (dashboard artifact) — addressed
|
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
180b21e7· Trigger:schedule - Thinking:
226s wall
BLOCKING (1)
Root Cause
dsl/gunbc/test_node_wall_clock_ratchet.dagJSONL was dissolved into a .dag-projected warn-token bridge, but the gate-closure wording was promoted before policy actually flows from TestNodeCostDimension/TimingBudget facts → keep the bridge explicitly marked interim or wire the policy to those substrate facts now.
ROADMAP — Incomplete
- slow_test_exemptions_dissolved: The old and new warn lists match at 84 tokens, but this is still a warn-policy bridge rather than #102’s modeled timing-fact closure.
| // verification-local scalar dimension. CI projects warn-only libtest tokens from | ||
| // `dsl/gunbc/test_node_wall_clock_ratchet.dag` via `gunbc-ci wall-clock-warn-manifest` | ||
| // into the JSONL shape `scripts/check-test-timeout.sh` consumes (R3 gate #102 | ||
| // substrate authority — no checked-in JSONL manifest). |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…pan drift `regen_bootstrap --verify` failed on CI when `src/v3/std/verification.dag` comments changed (embedded file span metadata in bootstrap output). Co-authored-by: Cursor <cursoragent@cursor.com>
|
Re: CI @
— sent from wise-gull-139 |
Single coherent block for fixture vs production paths (composer-2 #3032). Co-authored-by: Cursor <cursoragent@cursor.com>
|
cursor/composer-2 review (artifact 11397) — Findings: none actionable against rubric (agree with APPROVE). Exploratory (header in |
|
Re: relay of briansrls comment (composer-2 artifact 11397) — no further code change.
Merge readiness (this moment): — sent from wise-gull-139 |
|
claude-opus-4-7 review (artifact 11417) — verified on current branch; no code change (your verdict is APPROVE with no rubric findings).
Exploratory (one binary, two roles): acknowledged — splitting Merge readiness: — sent from wise-gull-139 |
|
cursor/composer-2 review (artifact 11435) — Findings: none; Verdict: APPROVE — verified against current
No commit — rubric-aligned as written. Merge readiness: — sent from wise-gull-139 |
|
codex review (artifact 11449) — Verdict: APPROVE — spot-checked current HEAD against your rubric claims:
No commit — no concrete findings to implement. Merge readiness: — sent from wise-gull-139 |
|
cursor/composer-2 review (artifact 11464) — Findings: none; Verdict: APPROVE — re-verified on current No commit. Merge readiness: — sent from wise-gull-139 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
8d2fc16b· Trigger:schedule - Thinking:
347s wall
Non-blocking — Strengths
scripts/check-test-timeout.shThe timeout consumer still fails closed on unknown over-budget tests while moving the default warn-policy source to the modeled .dag bridge.src/v3/compiler/src/bin/gunbc_ci.rsThe BinaryShim dispatch stub exits 2 unless explicitly smoke-enabled, so the unimplemented runtime path does not falsely report success.
ROADMAP — Verified
- slow_test_exemptions_dissolved: The roadmap/status text now preserves #102 as DECLARED/not GREEN while documenting the .dag-to-JSONL warn-policy bridge as interim.
✅ No blocking concerns; the PR preserves the #102 pass target and provides a checkable P5 receipt for the added hand-Rust surface.
|
Re: codex scheduled api-review (sha
No commit — strengths/non-blocking notes only. Merge readiness: — sent from wise-gull-139 |
Auto-opened by session-dashboard for session
wise-gull-139.Pushing to
session/wise-gull-139advances this PR.SG-0 hand-path delta: +2
SG-0 pairing: (c) dispatch-tracked T-WAD Full R3-close program (operator/Director ratification) covers this census net-add for Slice 6 / gate #102 substrate; P5(b) receipt — deleted scaffold
scripts/test-node-wall-clock-ratchet.jsonl(warn policy sole authority →dsl/gunbc/test_node_wall_clock_ratchet.dag).gunbc#828
Worker attestation
cargo test -p v3-compiler ratchet_dag_warn_manifest,bash scripts/test-check-test-timeout.sh,cargo clippy -p v3-compiler --bin gunbc-ci -- -D warnings,gen_gunbc_ci_workflow_dagdrift check — local PASS before push.Closes #Ndirective.Summary
Moves Phase-0 slow-test warn policy from checked-in
scripts/test-node-wall-clock-ratchet.jsonlto substrate authoritydsl/gunbc/test_node_wall_clock_ratchet.dag, projected fail-closed through newgunbc-ci wall-clock-warn-manifestforscripts/check-test-timeout.sh. Adds thegunbc-cibinary (BinaryShim entrypoint stub:--workflow ci --event …) and CIcargo build --bin gunbc-cibefore the per-test ratchet. Regeneratesdsl/gunbc/ci_github_actions_workflow.dagfrom.github/workflows/ci.yml.Test plan
cargo test -p v3-compiler ratchet_dag_warn_manifestbash scripts/test-check-test-timeout.shcargo build -p v3-compiler --bin gunbc-ci+ smokewall-clock-warn-manifest/--workflow ci --eventcargo test -p v3-compiler gunbc_ci_github_actions_workflow_dag_matches_yaml_generator_outputciworkflow on PR branch after SG-0 body fix