Repository navigation
docs(r3): §1.8 row #62 status refinement — file-ingestion ratified shape (b) FileAttachment extending #53 per Director msg_09df44c6 - #2821
Conversation
…APPROVE_WITH_COMMENTS) cursor review #10531 (APPROVE_WITH_COMMENTS) caught 2 small fixes: 1. **:330 Origin field** — literal `Director'\''s` shell-escape artifact (leaked from heredoc authoring) → corrected to `Director's`. P1 documentation-faithfulness. 2. **:205 parenthetical** — "was 97; +6 T-WAD FULL R3 elevation" only sums to 103, not the headline 104. Added "+1 Miss-class dissolution 2026-05-12" so arithmetic reconciles: 97 + 6 + 1 = 104. P2 single-authority consistency. Both small fixes; no scope change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
… predicate 64→70 across 6 files) codex BLOCKING on merged PR #2804 (review 4276876807 @ 23:10:31Z): "The row scopes the migration from a relayed count instead of deriving it from its own terminal grep predicate → include every current Part A match in the phase plan, or explicitly narrow the predicate and route the excluded Lookup< sites to a separate gate.⚠️ One blocking scope gap in the new closure gate would leave the terminal predicate red after the documented migration." Verified at `7a7c19d3` HEAD: `git grep -nE "Lookup<" src/v3/lenses/ src/v3/std/` = 70 matches (NOT 64 as Director's relay msg_cefcbe05 had it): - cost.dag: 25 - complexity.dag: 25 - infer_helpers.dag: 3 (incl. active `-> Lookup<DeclarationId>` :141) - algebra.dag: 3 (incl. canonical `miss_symbolic_cost_lookup()` :225 + `hit_symbolic_cost_lookup` :229) - substrate.dag: 3 - lookup.dag: 11 Critical: `algebra.dag:225 miss_symbolic_cost_lookup()` is THE constructor at the bind layer that emits the 15 Miss returns Director's complexity-lens dump (msg_32a3775e) originally surfaced — it being out-of-scope contradicted the row's own Origin statement. Fixes: 1. Scope at HEAD: 64 → 70 across 6 files (was 4); added `algebra.dag` 3 + `infer_helpers.dag` 3. 2. Bundled-migration Phase 2 reframed as "monomorphized accessor sweep" (substrate 3 + algebra 3 + infer_helpers 3 = 9 sites; line anchors added). 3. Origin trailer: appended PR #2807 scope-correction note + codex BLOCKING #4276876807 attribution; flagged msg_cefcbe05 as superseded. Part A terminal predicate unchanged; the migration plan now matches it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…tified shape (b) FileAttachment carrier extending #53 Director ratification msg_09df44c6 on canvas PR #2820 + §4.3 line 505 verbatim authority. Disposition (b) wins per: - §4.3 line 505 explicitly names "T-Workflow-As-Data file-ingestion substrate (workflow_substrate_carriers_landed extended to file-attachment)" as closure path - Lane fit: gate #62 is T-WAD per §1.8; carrier extension is canonical T-WAD pattern - Sibling-carrier precedent: WorkflowSecret + CronExpression in #53 establish the pattern - Construction-first: model workflow concept, not compile-time intrinsic - No parallel-authority: (a)+(b) coexistence violates §P1 single-authority Status: DECLARED → DECLARED-with-ratified-shape-and-sub-canvas-pending. Sub-canvas (FileAttachment carrier-shape: type def + fields + workflow-context coupling) queued for Substrate Mgr per recursive feedback_substrate_shape_belongs_in_mgr_canvas. Worker dispatch follows sub-shape ratification. PR #2819 STAND DOWN per Director disposition (msg_09df44c6); bright-otter-731 audit (msg_e85224dc) preserved as diagnostic-trail input. Anti-patterns enumerated for post-ratification reviewers: - Compile-time read_utf8_file-equivalent (Candidate A drift) - FileAttachment landed without #53 sibling-carrier alignment - Legacy include_str! bridges preserved alongside FileAttachment (§P5 atomic-migration violation) include_str! audit at HEAD (Director-verified): no matches — gate is forward-looking, not retire-existing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ctor sub-canvas disposition msg_61e302c6) Director-ratified FileAttachment carrier-internals shape per msg_61e302c6 on PR #2820 sub-canvas (commit 4a96d33). Status: DECLARED-with-ratified-shape-and-sub-canvas-pending → DECLARED-with-ratified-shape-and-carrier-internals-ratified. Refined-B-1 carrier (5-of-7 strict subset of #55 WorkflowObservationAnchor): FileAttachment { subject_node: NodeId content_digest: ContentHash producer_id: WorkflowProducerId workflow_run_id: WorkflowRunId attached_at_ns: Nanoseconds } Drops observer_id + prover_id (timing-observation-specific epistemological roles; not applicable to file attachment). Q1-Q6 dispositions verbatim from Director: - Q1 carrier shape: Refined-B-1 (B-2 + B-3 disqualified) - Q2 encoding field: ABSENT default; if needed use `Encoding` from `dsl/std/encoding.dag` - Q3 `WorkflowAssetPath` branded nominal: NOT introduced (digest-only canonical) - Q4 workflow-coupling: deferred to worker brief / consumer evidence (#55 List analogy) - Q5 eager-vs-lazy: EAGER confirmed - Q6 `AttachmentEncoding`: Practice-4 RED — dissolved to existing `Encoding` lattice Director grep-verified at HEAD: #55 anchor structure at timing_lens.dag:98-106, 5 branded nominals at dsl/std/types.dag:324-331, dsl/std/encoding.dag exists with 6-variant `Encoding` BoundedLattice, no FileAttachment/AttachmentEncoding/WorkflowAssetPath at HEAD (no parallel-authority risk). Anti-patterns extended from 3 (top-level) to 7 (sub-canvas additions): - (4) AttachmentEncoding duplicating dsl/std/encoding.dag — Practice-4 RED dissolution - (5) path field on FileAttachment — parallel-rep vs canonical digest - (6) List<FileAttachment> on Job/Step preemptively — consumer-evidence-required - (7) Carrier deviation from Refined-B-1 5-field structure — strict subset of #55 Cascade: - Sub-canvas closure: carrier-internals ratified - Worker brief authoring: 5-field carrier + sibling-alignment receipt + bootstrap ratchet test + existence-proof use case - Sub-canvas-2 trigger (forward-looking): workflow blob-store substrate (content_digest -> bytes resolution); Substrate Mgr authors after Refined-B-1 lands; NOT blocking carrier-internals ratification Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Review metadata
1. Story of the diffThis PR is a docs-only refinement of the R3 §1.8 program ledger in 2. Invariant categories
Compliant — the diff does not mutate
Compliant — the diff actively protects modeling discipline: gate #62 rejects parallel or lossy shapes by forbidding path authority, an
N/A — this is markdown planning text only; it adds no Rust functions, APIs, helpers, methods, result shapes, or implementation naming surface.
Compliant — no executable behavior changes, so no same-PR test is required, but the planning rows name the test obligations that must land with implementation: gate #62 requires a bootstrap ratchet test and existence-proof use case at
Compliant — the diff records ratified/locked decisions rather than diluting them: gate #62 preserves the Director-ratified
Compliant — the new follow-on work is bounded and tracked. Gate #62 names the follow-on blob-store trigger, the unresolved 2.5. Top-down PM intent reviewCompliant — the PR tightens the plan rather than changing its meaning. The count correction at 3. VerdictAPPROVE This is a docs-only authority refinement that makes the R3 work plan more precise, not looser. The substrate and test obligations it introduces are named, bounded, and tied to dissolution triggers; I did not find a diff-cited invariant violation. |
Summary
substrate_gap_file_ingestion_closed) status:DECLARED→DECLARED-with-ratified-shape-and-sub-canvas-pendingFileAttachmentcarrier extending gate Cursor/lane b workflow 2281 #53include_str!audit at HEADAuthority
docs/r3-program-plan.md§4.3 line 505 verbatim: "T-Workflow-As-Data file-ingestion substrate (workflow_substrate_carriers_landedextended to file-attachment)"docs/r3-program-plan.md§1.8 row Cursor/lane b workflow 2281 #53 (parent gate for sibling-carrier extension)feedback_substrate_shape_belongs_in_mgr_canvasfor sub-canvas triggerDirector rationale (preserved on-ledger)
(b) wins on 5 axes:
Disqualified:
read_utf8_file— P5-style intrinsic, doesn't match §4.3; re-introducesinclude_str!semantics under new syntaxCascade
Test plan
🤖 Generated with Claude Code