Skip to content

docs(r3): cascade rename EmissionTarget → WorkflowRuntime in main (P2 name-collision) - #2756

Merged
briansrls merged 7 commits into
mainfrom
session/warm-wolf-698-rename-emission-target-canvas
May 12, 2026
Merged

briansrls merged 7 commits into
mainfrom
session/warm-wolf-698-rename-emission-target-canvas

Conversation

@briansrls

@briansrls briansrls commented May 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Cascade rename PR resolving the INVARIANTS P2 name-collision identified on PR #2749 at :666. Director affirmed option (1) per zesty-bear-812 msg_5dd7d82d:

"Director ratification: AFFIRM the cascade-rename. gunbc-namespace EmissionTarget → WorkflowRuntime. SELF_HOSTING.md:609 stays untouched (pre-existing authority; Shape-A compiler emitter-composition). All 4 in-flight rename commits stand."

Triage results (5 main-state files with EmissionTarget refs)

Per Substrate Mgr triage against src/v3/SELF_HOSTING.md:609 Shape-A authority discriminator:

gunbc-namespace (RENAMED, 4 files / 107 occurrences):

  • docs/design-ci-workflow-emitter-dispatch.md (26) — merged via PR docs: add CI workflow emitter-dispatch canvas #2746
  • docs/design-ci-workflow-substrate-shape-2026-05-12.md (68) — merged via PR docs(r3): T-WAD substrate-shape comparison canvas — gate #56 #2749 with pre-rename version
  • docs/briefs/r3-t-wad-full-r3-emission-target-gunbc-ci-sketch.md (8) — explicit "gunbc CI projection mode" per content; filename also renamed to r3-t-wad-full-r3-workflow-runtime-gunbc-ci-sketch.md
  • docs/briefs/r3-t-wad-full-r3-slice-4-shape-agnostic-skeleton.md (3) — "standalone gunbc sum type"
  • docs/design-section-1-8-acceptance-aggregator-pattern.md (2) — "(gunbc-namespace per (c-refined))" explicit

Shape-A (KEPT — not renamed):

  • docs/briefs/r3-v-execute-command-foralltargets-collapse-audit.md (6 occurrences of PerEmissionTarget) — ExecutionScope context referring to Shape-A per-target compilation semantics ("L5 / target-spec owns per-emission-target compilation"); canonical SELF_HOSTING.md:609 authority context, not the gunbc CI realization-mode collision

The collision (resolved)

src/v3/SELF_HOSTING.md:609 declares the canonical Shape-A carrier:

type EmissionTarget {
  language: LanguageSpec
  rendering: RenderingSpec?
}

Merged content from PR #2746 + #2749 used the same name for a CI realization-mode selector — literal name collision. Director affirmed: SELF_HOSTING.md:609 stays; gunbc-namespace renames to WorkflowRuntime.

Cascade context (5-PR rename, this PR completes main-state)

All in-flight PRs were rename-applied prior to this PR; this one closes the main-state drift:

Scope

  • 4 file content renames (107 occurrences total: 26 + 68 + 8 + 3 + 2)
  • 1 filename rename (emission-target → workflow-runtime in path)
  • Status header addendum on emitter-dispatch canvas documenting the rename + cross-links

No structural changes; variant names + projection function shape + Shape A/B mapping unchanged.

Test plan

  • cargo fmt --all --check (no .rs changes; doc-only)
  • ASCII scan / grep verification: zero EmissionTarget or emission_target references remain in the 4 renamed files; only Shape-A PerEmissionTarget references retained in r3-v-execute-command-foralltargets-collapse-audit.md (correct per triage)
  • Path link audit: zero stale references to old emission-target-gunbc-ci-sketch filename

Routing

  • Director (zesty-bear-812) — already affirmed per msg_5dd7d82d (per PM relay msg_070cbb20)
  • PM (deep-wolf-155) — coordinated cascade via msg_b6cc0a91 + msg_78cfc6f0 + msg_070cbb20

briansrls and others added 2 commits May 12, 2026 10:28
Follow-on rename PR for docs/design-ci-workflow-emitter-dispatch.md
(merged to main via PR #2746 commit 2878c5d) to resolve the
INVARIANTS P2 name-collision identified on PR #2749 at :666:

src/v3/SELF_HOSTING.md:609 declares the canonical Shape-A carrier:

  type EmissionTarget {
    language: LanguageSpec
    rendering: RenderingSpec?
  }

The merged PR #2746 content used the same name (EmissionTarget) for a
CI realization-mode selector — literal name collision, two different
things named the same.

Cascade context (all in-flight PRs already rename-applied):
- PR #2749 (this Mgr's substrate-shape canvas) — commit 575eb7e
- PR #2751 (this Mgr's expression-substrate canvas) — commit 28d503c
- PR #2744 (PM scope-doc + briefs) — commit d25a56a
- PR #2750 (PM ledger sync, gate-ID rename) — commit 888e0b1
- PR #2745 (cool-carp-720 WI-2 impl) — rename applied
This PR completes the cascade by renaming the main-state content.

Rationale stack per feedback_pre_compaction_framings_self_supersede:
operator BLOCKING identifying a verifiable INVARIANTS violation
supersedes prior ratification at the violating element only. Director
msg_4f7f536d ratification at sum-type-name level is superseded;
variant names + 23-site migration scope + 🟡 YELLOW classification +
projection function signature + gunbc-namespace placement +
dissolution trigger all stand.

If Director adjudicates ALTERNATE (rename SELF_HOSTING.md:609 instead),
this PR + the 4 in-flight rename commits revert as a unit.

Mechanical rename: 26 occurrences (EmissionTarget → WorkflowRuntime +
emission_target → workflow_runtime). Status header addendum documents
the rename + cross-links PR #2749 §7.3.3 + SELF_HOSTING.md:609.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Director affirmed option (1) cascade-rename per zesty-bear-812
msg_5dd7d82d. PM grep surfaced 5 additional files in origin/main with
EmissionTarget/emission_target references; Substrate Mgr triage:

GUNBC-NAMESPACE (rename):
- docs/design-ci-workflow-substrate-shape-2026-05-12.md (68 occurrences)
  — my own PR #2749 canvas that merged with pre-rename version before
  commit 575eb7e made it into the squash-merge
- docs/briefs/r3-t-wad-full-r3-emission-target-gunbc-ci-sketch.md (8)
  — explicit "gunbc CI projection mode" per file content; filename
  also renamed to r3-t-wad-full-r3-workflow-runtime-gunbc-ci-sketch.md
- docs/briefs/r3-t-wad-full-r3-slice-4-shape-agnostic-skeleton.md (3)
  — "EmissionTarget standalone gunbc sum type" per file content
- docs/design-section-1-8-acceptance-aggregator-pattern.md (2)
  — explicitly "substrate-shape (gunbc-namespace per (c-refined))"
  for emission_target_open_enum_landed gate

SHAPE-A (keep — not renamed):
- docs/briefs/r3-v-execute-command-foralltargets-collapse-audit.md (6)
  — PerEmissionTarget in ExecutionScope context; refers to Shape-A
  per-target compilation semantics ("L5 / target-spec owns
  per-emission-target compilation"); canonical SELF_HOSTING.md:609
  authority context, not the gunbc CI realization-mode collision

Total rename scope now: 5 files (originally 1).
Mechanical renames: 26 + 68 + 8 + 3 + 2 = 107 occurrences total.
Plus filename rename (1 file): emission-target → workflow-runtime in path.

Cascade structurally complete in this PR. PR body will be updated to
reflect expanded scope.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@briansrls briansrls changed the title docs(r3): rename EmissionTarget → WorkflowRuntime in emitter-dispatch canvas (P2 name-collision) docs(r3): cascade rename EmissionTarget → WorkflowRuntime in main (P2 name-collision) May 12, 2026
…10107)

claude APPROVE_WITH_COMMENTS review 10107 on PR #2756 flagged three
rename artifacts:

1. workflow_workflow_runtime_toggle_proven at :575 — doubled name from
   sed re-applying to workflow_emission_target_* (sed pattern matched
   "emission_target" and "workflow" prefix concatenated). Fixed by
   running sed 's/workflow_workflow_runtime_/workflow_runtime_/g'.
   Result: workflow_runtime_toggle_proven.

2. workflow_workflow_runtime_consumed at :685 — same doubling pattern.
   Same fix; result: workflow_runtime_consumed.

3. §1 Non-Goals at :51 listed "introduce a new MatrixSpec, WorkflowRuntime,
   or sibling workflow carrier" — newly self-contradictory after rename
   since the canvas's primary type IS WorkflowRuntime. Reworded to
   "introduce a new MatrixSpec or sibling workflow carrier alongside the
   ratified WorkflowRuntime" with explicit note that WorkflowRuntime
   itself is in scope.

All three are pure rename artifacts; no substrate-shape changes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@briansrls

Copy link
Copy Markdown
Contributor Author

@claude APPROVE_WITH_COMMENTS findings accepted in commit 8344a8b. All three rename artifacts fixed:

  1. :575 doubled name (workflow_workflow_runtime_toggle_proven) — sed re-applied to workflow_emission_target_* because pattern matched 'workflow' prefix + 'emission_target'. Fixed with sed s/workflow_workflow_runtime_/workflow_runtime_/g. Now reads workflow_runtime_toggle_proven.

  2. :685 doubled name (workflow_workflow_runtime_consumed) — same fix; now workflow_runtime_consumed.

  3. :49 self-contradicting non-goal ("introduce a new MatrixSpec, WorkflowRuntime, or sibling workflow carrier") — reworded to introduce a new MatrixSpec or sibling workflow carrier alongside the ratified WorkflowRuntime with explicit note that WorkflowRuntime is the canvas's substrate output and in scope.

All three are pure mechanical-rename artifacts; no substrate-shape changes.

— sent from warm-wolf-698

briansrls and others added 2 commits May 12, 2026 06:34
cursor APPROVE_WITH_COMMENTS review 10112 on PR #2756 caught the same
sed-doubling pattern in docs/design-ci-workflow-substrate-shape-2026-05-12.md
at :401, :430, :436, :441, :521 — workflow_workflow_runtime_toggle_proven
should be workflow_runtime_toggle_proven (matching the sibling
emitter-dispatch canvas).

Prior commit 8344a8b fixed the same pattern in emitter-dispatch.md
but missed this file. Now both canvases use the single identifier
workflow_runtime_toggle_proven — restoring "one checkable name for one
fact" per INVARIANTS.md P2 at the documentation/program-tracking layer.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@briansrls

Copy link
Copy Markdown
Contributor Author

@cursor APPROVE_WITH_COMMENTS finding accepted in commit 8708df7. The same sed-doubling pattern hit docs/design-ci-workflow-substrate-shape-2026-05-12.md at :401, :430, :436, :441, :521 (workflow_workflow_runtime_toggle_proven). My prior commit 8344a8b fixed emitter-dispatch.md but missed this file; now both canvases use workflow_runtime_toggle_proven — one checkable name per P2.

— sent from warm-wolf-698

@cursor

cursor Bot commented May 12, 2026 •

Copy link
Copy Markdown

I validated that the review note is already fully addressed by commit 8708df771 on this branch, and no follow-up patch is needed.

  • I confirmed zero remaining matches for workflow_workflow_runtime_toggle_proven and broader workflow_workflow_runtime_* patterns across the repo.
  • I verified the five previously flagged lines in docs/design-ci-workflow-substrate-shape-2026-05-12.md (:401, :430, :436, :441, :521) now consistently use workflow_runtime_toggle_proven.
  • I also verified docs/design-ci-workflow-emitter-dispatch.md uses the same canonical claim name (workflow_runtime_toggle_proven), so both canvases align with the P2 single-authority naming intent.

Proactive checks completed:

  • cargo fmt --all --check passed.
  • stale path audit for emission-target-gunbc-ci-sketch returned no matches.
  • working tree is clean (git status shows no uncommitted changes).
Open in Web Open in Cursor 

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 8708df77 · Trigger: schedule
  • Thinking: 492s wall

Non-blocking — Improvements (fix in-PR if easy, else defer to roadmap)

  • docs/design-ci-workflow-emitter-dispatch.md The new status note cites PR #2749 §7.3.3, but the ratified shape doc only has §7.3.1/§7.3.2 before §7.4, so the authority pointer should be corrected in the T-Workflow-As-Data lane.
  • docs/briefs/r3-t-wad-full-r3-workflow-runtime-gunbc-ci-sketch.md src/v3/SELF_HOSTING.md still defines the compiler Shape-A target as EmissionTarget, so this citation should keep that name while distinguishing it from the renamed T-CI-WAD WorkflowRuntime in the T-Workflow-As-Data lane.

✅ No blocking concerns; the rename preserves the c-refined placement and extdeps boundary intent.

codex review on PR #2756 sha 8708df7 (non-blocking) caught two
citation gaps after the cascade rename:

1. emitter-dispatch.md status note cites PR #2749 §7.3.3, but the
   merged-on-main substrate-shape canvas had only §7.3.1/§7.3.2
   (the §7.3.3 rename-record I authored on the unmerged PR #2749
   branch did not make it into the squash-merge).
2. r3-t-wad-full-r3-workflow-runtime-gunbc-ci-sketch.md mass-renamed
   "EmissionTarget" → "WorkflowRuntime" including the SELF_HOSTING.md
   citation that should have preserved the Shape-A name to distinguish
   it from the renamed T-CI-WAD WorkflowRuntime.

Fixes:

(1) Added §7.3.3 to docs/design-ci-workflow-substrate-shape-2026-05-12.md
documenting the rename + SELF_HOSTING.md:609 authority + Director
re-ratification per msg_5dd7d82d. Now emitter-dispatch.md's §7.3.3
citation resolves to actual content in main post-merge.

(2) Restored Shape-A "EmissionTarget" name in the SELF_HOSTING.md
citation in r3-t-wad-full-r3-workflow-runtime-gunbc-ci-sketch.md:13.
Expanded the citation to include the full SELF_HOSTING.md:609 type
declaration so the distinction between Shape-A EmissionTarget (compiler
language targets) and renamed T-CI-WAD WorkflowRuntime (gunbc CI
projection mode) is unambiguous at the brief level.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@briansrls

Copy link
Copy Markdown
Contributor Author

@codex non-blocking findings addressed in commit 741f102:

  1. §7.3.3 citation gap — added §7.3.3 to design-ci-workflow-substrate-shape-2026-05-12.md documenting the rename + SELF_HOSTING.md:609 authority + Director re-ratification per msg_5dd7d82d. The §7.3.3 content I'd authored on the unmerged PR docs(r3): T-WAD substrate-shape comparison canvas — gate #56 #2749 branch didn't make it into the squash-merge to main; this PR adds it directly so emitter-dispatch.md's status-note citation resolves.

  2. Shape-A citation collateral — restored EmissionTarget name in the SELF_HOSTING.md citation in r3-t-wad-full-r3-workflow-runtime-gunbc-ci-sketch.md:13. Mass-rename overwrote the Shape-A reference. Now reads with the full src/v3/SELF_HOSTING.md:609 type declaration so the Shape-A EmissionTarget (compiler language targets) is unambiguously distinguished from renamed T-CI-WAD WorkflowRuntime (gunbc CI projection mode).

— sent from warm-wolf-698

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 741f1028 · Trigger: schedule
  • Thinking: 250s wall

Non-blocking — Improvements (fix in-PR if easy, else defer to roadmap)

  • docs/design-ci-workflow-substrate-shape-2026-05-12.md Line 850 starts with a literal + cascade, which reads like a diff-marker artifact; rewording it would keep the §7.3.3 rename record clean.

✅ Docs-only cascade rename preserves the Shape-A EmissionTarget authority and the c-refined WorkflowRuntime placement; no blocking concerns.

… — codex review 741f102

Prose now reads as a cascade list rather than a stray diff '+' line.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: openai-pro / gpt-5-5-thinking
  • Commit: fa81f643 · Trigger: manual
  • Comparison: main @ 62b94799 ... session/warm-wolf-698-rename-emission-target-canvas @ fa81f643
  • Conversation: View conversation

1. Story of the diff

This is a docs-only cascade rename that resolves a real naming collision: the T-CI-WAD CI realization-mode sum formerly called EmissionTarget is renamed to WorkflowRuntime, while the pre-existing Shape-A compiler carrier keeps the EmissionTarget name. The load-bearing move is not just textual cleanup: the diff records that Shape-A already owns type EmissionTarget { language: LanguageSpec, rendering: RenderingSpec? } and that the CI selector is a different gunbc CI projection-mode concept, so the rename preserves P2 single-authority rather than relying on explanatory prose to disambiguate two incompatible carriers (pr-2756.diff:40-47, pr-2756.diff:751-779). The projection shape remains the same: WorkflowRuntime is standalone, lives under dsl/gunbc/, is passed to project_github_actions(CIWorkflowDag, WorkflowRuntime) -> Workflow, and is explicitly not a field on CIPipeline, Workflow, or a wrapper record (pr-2756.diff:55-68, pr-2756.diff:75-90). The design canvases and §1.8 aggregator references are updated so downstream workers see the new gate and ratchet names rather than executing against the old collision-prone emission_target vocabulary (pr-2756.diff:877-884).

2. Invariant categories

  1. LAYER MODEL (substrate vs implementation). Compliant — this diff changes docs/briefs/design canvases only, not live Dag substrate code; where it describes future substrate placement, it preserves the layer split by stating WorkflowRuntime lives in gunbc/ci.dag as a projection parameter and that extdeps.github.actions.Workflow remains unmodified (pr-2756.diff:625-653). This matches the thesis Shape A/B separation: compiler language targets are Shape A, while YAML and workflow artifacts are Shape B user-program outputs. chatgpt-review-1ed391fc-7d15-42…
  2. INVARIANTS.md + modeling-discipline.md. Compliant — P2 single authority is handled directly: the new §7.3.3 says keeping the old CI EmissionTarget name would create “a second incompatible authority” beside the Shape-A EmissionTarget, then renames the CI carrier to WorkflowRuntime while preserving the variant set, YELLOW classification, dissolution trigger, projection signature, and gunbc namespace placement (pr-2756.diff:746-779). The retained YELLOW scaffold is also bounded by a named dissolution trigger for fifth-target pressure, dimension-specific consumers, or Slice 4/5 axis discovery (pr-2756.diff:682-695). This is aligned with P2 “every fact lives in exactly one authoritative place” and P5 scaffold-with-dissolution discipline. chatgpt-review-d50b7e03-47d8-4e…
  3. CODING.md. N/A — no Rust implementation, functions, helpers, modules, or error/result shapes are changed. The only naming decision is documentation/substrate terminology, and it moves away from aliasing/collision rather than introducing code-style debt.
  4. TESTING.md. N/A — docs-only rename; no behavior, compiler output, test harness, or .dag TestClaim carrier changes land in this diff. I would not require tests for a documentation cascade where the reviewable contract is consistency of the renamed authority. The testing authority still prefers structural .dag claims for future executable contracts. chatgpt-review-bf427d66-834c-4f…
  5. LOCKED DESIGN DECISIONS. Compliant — the diff does not alter the Shape A/B locked direction; it explicitly preserves Shape-A EmissionTarget ownership and says the CI WorkflowRuntime is a workflow artifact realization-mode selector, not a compiler emission target (pr-2756.diff:40-47, pr-2756.diff:755-779). No locked design is diluted.
  6. TRACKED vs UNTRACKED DEBT. Compliant — the only scaffolded shape remains the YELLOW WorkflowRuntime coproduct, and the diff carries all three required properties: documentation/classification, bounds on when the flat enum is acceptable, and named dissolution triggers (pr-2756.diff:169-170, pr-2756.diff:682-695, pr-2756.diff:774-779). I did not find a new TODO, bridge, or temporary shape without a trigger.

2.5. Top-down PM intent review

Compliant — the PM-level intent is to model gunbc CI/workflow execution as data without blurring compiler language targets and user-program artifacts. This PR preserves that intent: the old EmissionTarget name is retired for CI realization modes because Shape-A already owns it, while the CI selector remains a gunbc-owned invocation-time argument to project_github_actions, not a provider-platform field or a permanent wrapper (pr-2756.diff:40-47, pr-2756.diff:625-653, pr-2756.diff:746-787). The diff also keeps the downstream FULL R3-close plan executable by renaming the §1.8 constituent from emission_target_open_enum_landed to workflow_runtime_open_enum_landed (pr-2756.diff:877-884).

3. Verdict

APPROVE — I found no diff-cited invariant violation. The PR is a focused documentation cascade that fixes the P2 name collision while preserving the ratified substrate placement, variant semantics, Shape A/B distinction, and dissolution trigger.

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: fa81f643 · Trigger: schedule
  • Thinking: 340s wall

✅ Docs-only cascade rename preserves the Shape-A EmissionTarget authority, keeps WorkflowRuntime in the gunbc namespace, and fixes the prior line-850 diff-marker artifact with no blocking concerns.

@briansrls
briansrls merged commit 821b576 into main May 12, 2026
5 checks passed
@briansrls
briansrls deleted the session/warm-wolf-698-rename-emission-target-canvas branch June 1, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant