Repository navigation
docs(r3): cascade rename EmissionTarget → WorkflowRuntime in main (P2 name-collision) - #2756
Conversation
Follow-on rename PR for docs/design-ci-workflow-emitter-dispatch.md (merged to main via PR #2746 commit 2878c5d) to resolve the INVARIANTS P2 name-collision identified on PR #2749 at :666: src/v3/SELF_HOSTING.md:609 declares the canonical Shape-A carrier: type EmissionTarget { language: LanguageSpec rendering: RenderingSpec? } The merged PR #2746 content used the same name (EmissionTarget) for a CI realization-mode selector — literal name collision, two different things named the same. Cascade context (all in-flight PRs already rename-applied): - PR #2749 (this Mgr's substrate-shape canvas) — commit 575eb7e - PR #2751 (this Mgr's expression-substrate canvas) — commit 28d503c - PR #2744 (PM scope-doc + briefs) — commit d25a56a - PR #2750 (PM ledger sync, gate-ID rename) — commit 888e0b1 - PR #2745 (cool-carp-720 WI-2 impl) — rename applied This PR completes the cascade by renaming the main-state content. Rationale stack per feedback_pre_compaction_framings_self_supersede: operator BLOCKING identifying a verifiable INVARIANTS violation supersedes prior ratification at the violating element only. Director msg_4f7f536d ratification at sum-type-name level is superseded; variant names + 23-site migration scope + 🟡 YELLOW classification + projection function signature + gunbc-namespace placement + dissolution trigger all stand. If Director adjudicates ALTERNATE (rename SELF_HOSTING.md:609 instead), this PR + the 4 in-flight rename commits revert as a unit. Mechanical rename: 26 occurrences (EmissionTarget → WorkflowRuntime + emission_target → workflow_runtime). Status header addendum documents the rename + cross-links PR #2749 §7.3.3 + SELF_HOSTING.md:609. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Director affirmed option (1) cascade-rename per zesty-bear-812 msg_5dd7d82d. PM grep surfaced 5 additional files in origin/main with EmissionTarget/emission_target references; Substrate Mgr triage: GUNBC-NAMESPACE (rename): - docs/design-ci-workflow-substrate-shape-2026-05-12.md (68 occurrences) — my own PR #2749 canvas that merged with pre-rename version before commit 575eb7e made it into the squash-merge - docs/briefs/r3-t-wad-full-r3-emission-target-gunbc-ci-sketch.md (8) — explicit "gunbc CI projection mode" per file content; filename also renamed to r3-t-wad-full-r3-workflow-runtime-gunbc-ci-sketch.md - docs/briefs/r3-t-wad-full-r3-slice-4-shape-agnostic-skeleton.md (3) — "EmissionTarget standalone gunbc sum type" per file content - docs/design-section-1-8-acceptance-aggregator-pattern.md (2) — explicitly "substrate-shape (gunbc-namespace per (c-refined))" for emission_target_open_enum_landed gate SHAPE-A (keep — not renamed): - docs/briefs/r3-v-execute-command-foralltargets-collapse-audit.md (6) — PerEmissionTarget in ExecutionScope context; refers to Shape-A per-target compilation semantics ("L5 / target-spec owns per-emission-target compilation"); canonical SELF_HOSTING.md:609 authority context, not the gunbc CI realization-mode collision Total rename scope now: 5 files (originally 1). Mechanical renames: 26 + 68 + 8 + 3 + 2 = 107 occurrences total. Plus filename rename (1 file): emission-target → workflow-runtime in path. Cascade structurally complete in this PR. PR body will be updated to reflect expanded scope. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…10107) claude APPROVE_WITH_COMMENTS review 10107 on PR #2756 flagged three rename artifacts: 1. workflow_workflow_runtime_toggle_proven at :575 — doubled name from sed re-applying to workflow_emission_target_* (sed pattern matched "emission_target" and "workflow" prefix concatenated). Fixed by running sed 's/workflow_workflow_runtime_/workflow_runtime_/g'. Result: workflow_runtime_toggle_proven. 2. workflow_workflow_runtime_consumed at :685 — same doubling pattern. Same fix; result: workflow_runtime_consumed. 3. §1 Non-Goals at :51 listed "introduce a new MatrixSpec, WorkflowRuntime, or sibling workflow carrier" — newly self-contradictory after rename since the canvas's primary type IS WorkflowRuntime. Reworded to "introduce a new MatrixSpec or sibling workflow carrier alongside the ratified WorkflowRuntime" with explicit note that WorkflowRuntime itself is in scope. All three are pure rename artifacts; no substrate-shape changes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
@claude APPROVE_WITH_COMMENTS findings accepted in commit 8344a8b. All three rename artifacts fixed:
All three are pure mechanical-rename artifacts; no substrate-shape changes. — sent from warm-wolf-698 |
…-rename-emission-target-canvas
cursor APPROVE_WITH_COMMENTS review 10112 on PR #2756 caught the same sed-doubling pattern in docs/design-ci-workflow-substrate-shape-2026-05-12.md at :401, :430, :436, :441, :521 — workflow_workflow_runtime_toggle_proven should be workflow_runtime_toggle_proven (matching the sibling emitter-dispatch canvas). Prior commit 8344a8b fixed the same pattern in emitter-dispatch.md but missed this file. Now both canvases use the single identifier workflow_runtime_toggle_proven — restoring "one checkable name for one fact" per INVARIANTS.md P2 at the documentation/program-tracking layer. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
@cursor APPROVE_WITH_COMMENTS finding accepted in commit 8708df7. The same sed-doubling pattern hit — sent from warm-wolf-698 |
|
I validated that the review note is already fully addressed by commit
Proactive checks completed:
|
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
8708df77· Trigger:schedule - Thinking:
492s wall
Non-blocking — Improvements (fix in-PR if easy, else defer to roadmap)
docs/design-ci-workflow-emitter-dispatch.mdThe new status note cites PR #2749 §7.3.3, but the ratified shape doc only has §7.3.1/§7.3.2 before §7.4, so the authority pointer should be corrected in the T-Workflow-As-Data lane.docs/briefs/r3-t-wad-full-r3-workflow-runtime-gunbc-ci-sketch.mdsrc/v3/SELF_HOSTING.md still defines the compiler Shape-A target as EmissionTarget, so this citation should keep that name while distinguishing it from the renamed T-CI-WAD WorkflowRuntime in the T-Workflow-As-Data lane.
✅ No blocking concerns; the rename preserves the c-refined placement and extdeps boundary intent.
codex review on PR #2756 sha 8708df7 (non-blocking) caught two citation gaps after the cascade rename: 1. emitter-dispatch.md status note cites PR #2749 §7.3.3, but the merged-on-main substrate-shape canvas had only §7.3.1/§7.3.2 (the §7.3.3 rename-record I authored on the unmerged PR #2749 branch did not make it into the squash-merge). 2. r3-t-wad-full-r3-workflow-runtime-gunbc-ci-sketch.md mass-renamed "EmissionTarget" → "WorkflowRuntime" including the SELF_HOSTING.md citation that should have preserved the Shape-A name to distinguish it from the renamed T-CI-WAD WorkflowRuntime. Fixes: (1) Added §7.3.3 to docs/design-ci-workflow-substrate-shape-2026-05-12.md documenting the rename + SELF_HOSTING.md:609 authority + Director re-ratification per msg_5dd7d82d. Now emitter-dispatch.md's §7.3.3 citation resolves to actual content in main post-merge. (2) Restored Shape-A "EmissionTarget" name in the SELF_HOSTING.md citation in r3-t-wad-full-r3-workflow-runtime-gunbc-ci-sketch.md:13. Expanded the citation to include the full SELF_HOSTING.md:609 type declaration so the distinction between Shape-A EmissionTarget (compiler language targets) and renamed T-CI-WAD WorkflowRuntime (gunbc CI projection mode) is unambiguous at the brief level. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
@codex non-blocking findings addressed in commit 741f102:
— sent from warm-wolf-698 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
741f1028· Trigger:schedule - Thinking:
250s wall
Non-blocking — Improvements (fix in-PR if easy, else defer to roadmap)
docs/design-ci-workflow-substrate-shape-2026-05-12.mdLine 850 starts with a literal+ cascade, which reads like a diff-marker artifact; rewording it would keep the §7.3.3 rename record clean.
✅ Docs-only cascade rename preserves the Shape-A EmissionTarget authority and the c-refined WorkflowRuntime placement; no blocking concerns.
… — codex review 741f102 Prose now reads as a cascade list rather than a stray diff '+' line. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Review metadata
1. Story of the diffThis is a docs-only cascade rename that resolves a real naming collision: the T-CI-WAD CI realization-mode sum formerly called 2. Invariant categories
2.5. Top-down PM intent reviewCompliant — the PM-level intent is to model gunbc CI/workflow execution as data without blurring compiler language targets and user-program artifacts. This PR preserves that intent: the old 3. VerdictAPPROVE — I found no diff-cited invariant violation. The PR is a focused documentation cascade that fixes the P2 name collision while preserving the ratified substrate placement, variant semantics, Shape A/B distinction, and dissolution trigger. |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
fa81f643· Trigger:schedule - Thinking:
340s wall
✅ Docs-only cascade rename preserves the Shape-A EmissionTarget authority, keeps WorkflowRuntime in the gunbc namespace, and fixes the prior line-850 diff-marker artifact with no blocking concerns.


Summary
Cascade rename PR resolving the INVARIANTS P2 name-collision identified on PR #2749 at :666. Director affirmed option (1) per
zesty-bear-812 msg_5dd7d82d:Triage results (5 main-state files with EmissionTarget refs)
Per Substrate Mgr triage against
src/v3/SELF_HOSTING.md:609Shape-A authority discriminator:gunbc-namespace (RENAMED, 4 files / 107 occurrences):
docs/design-ci-workflow-emitter-dispatch.md(26) — merged via PR docs: add CI workflow emitter-dispatch canvas #2746docs/design-ci-workflow-substrate-shape-2026-05-12.md(68) — merged via PR docs(r3): T-WAD substrate-shape comparison canvas — gate #56 #2749 with pre-rename versiondocs/briefs/r3-t-wad-full-r3-emission-target-gunbc-ci-sketch.md(8) — explicit "gunbc CI projection mode" per content; filename also renamed tor3-t-wad-full-r3-workflow-runtime-gunbc-ci-sketch.mddocs/briefs/r3-t-wad-full-r3-slice-4-shape-agnostic-skeleton.md(3) — "standalone gunbc sum type"docs/design-section-1-8-acceptance-aggregator-pattern.md(2) — "(gunbc-namespace per (c-refined))" explicitShape-A (KEPT — not renamed):
docs/briefs/r3-v-execute-command-foralltargets-collapse-audit.md(6 occurrences ofPerEmissionTarget) —ExecutionScopecontext referring to Shape-A per-target compilation semantics ("L5 / target-spec owns per-emission-target compilation"); canonical SELF_HOSTING.md:609 authority context, not the gunbc CI realization-mode collisionThe collision (resolved)
src/v3/SELF_HOSTING.md:609declares the canonical Shape-A carrier:Merged content from PR #2746 + #2749 used the same name for a CI realization-mode selector — literal name collision. Director affirmed: SELF_HOSTING.md:609 stays; gunbc-namespace renames to
WorkflowRuntime.Cascade context (5-PR rename, this PR completes main-state)
All in-flight PRs were rename-applied prior to this PR; this one closes the main-state drift:
575eb7e36) — note: merged on main with pre-rename version; this PR re-applies to the merged content28d503cf9)d25a56ab4)888e0b1b3)Scope
emission-target→workflow-runtimein path)No structural changes; variant names + projection function shape + Shape A/B mapping unchanged.
Test plan
cargo fmt --all --check(no .rs changes; doc-only)EmissionTargetoremission_targetreferences remain in the 4 renamed files; only Shape-APerEmissionTargetreferences retained inr3-v-execute-command-foralltargets-collapse-audit.md(correct per triage)emission-target-gunbc-ci-sketchfilenameRouting
msg_5dd7d82d(per PM relaymsg_070cbb20)msg_b6cc0a91+msg_78cfc6f0+msg_070cbb20