Repository navigation
complexity_violation_compile_error_demonstrated - #2737
Merged
Merged
Conversation
briansrls
marked this pull request as ready for review
May 12, 2026 05:26
5 of 6 tasks
briansrls
added a commit
that referenced
this pull request
May 14, 2026
… gate #92, ctrl-build pointer Addresses PM/Director fix-forward guidance (msg_42c90bfb 2026-05-14): 1. Line 24 close criteria: removed the remaining "R4-DEFERRED-with-operator-acceptance" language that codex review 11524 flagged as a generic escape hatch. New wording states no generic deferral; gap-specific structural blockage routes through docs/r3-actual-close-plan.md §1 + explicit Director/operator ratification recorded against the close-plan, not this audit doc. Re-swept for R4-DEFER / R4 defer / R4-defer / R4_DEFER — zero remaining occurrences in this audit doc. 2. Gate #92 row: promoted to HARNESS_NAMED (split). Even though PR #2737 removed the #[ignore] that PR #2723 added (per ledger Notes), fail-closed posture (INVARIANTS P3) requires the close-time command to explicitly invoke the named receipt rather than depend on the ignore-bit remaining off. Row now cites both the default workspace sweep portion and an explicit `cargo test -p v3-compiler -- --include-ignored complexity_violation_compile_error_demonstrated` invocation that fires the receipt regardless of ignore-bit state at the close-ceremony commit. 3. Cursor non-blocking exploratory note: added a one-line pointer that `ctrl-build` is the internal session-runtime BuildBuddy wrapper per CLAUDE.md, and that the §10 close-ceremony auditor substitutes the canonical local equivalent. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
briansrls
added a commit
that referenced
this pull request
May 14, 2026
…3024) * docs(r3): R3 close predicate-execution log — Phase 2 fill (45 EXECUTED / 61 N/A_NOT_PASSING) Populates docs/audit/r3-close-predicate-execution-2026-05-13.md (skeleton merged via PR #3019) per Gap 10 Phase 2 of docs/r3-actual-close-plan.md. For every §1.8 row at HEAD a2a7a88: - Status = PASSING / SATISFIED-BY-CONSTRUCTION (45 rows) → predicate execution status EXECUTED; close-time harness = workspace ratchet batch (cargo fmt / clippy --all-targets -D warnings / cargo test --workspace) with per-row ratchet cited under §1.8 row Notes; result pointer → §Workspace batch receipt. - Status = CONSUMER_LANDED / DECLARED / R3-LOAD-BEARING (decl-stage) / INTEGRATION_RECEIPT / CANVAS_RATIFIED (61 rows) → predicate execution status N/A_NOT_PASSING; per r3-close-interrogation.md §8 the predicate-execution requirement attaches only to PASSING gates. Adds row #106 show_correct_code_diagnostic_coverage (merged PR #3020 / Gap 9) so table mirrors §1.8 ledger one-for-one at HEAD (parity grep `grep -cE '^\\| [0-9]+ \\| `' yields 106 on both surfaces). Workspace batch receipt records cargo fmt --all --check exit 0 and clippy --all-targets -D warnings exit 0; cargo test --workspace --exclude gunbc-dag-tests is initiated and the §10 close-ceremony audit doc records the final 24h-of-close re-sweep with the merge-commit SHA. Overall verdict remains PENDING (61 gates not at PASSING at HEAD; close ceremony not opened). Authority: merged PR gunbc/gunbc#3013 Gap 10 close criterion; PR #3019 skeleton; PR #3020 row #106; docs/r3-close-interrogation.md §8; docs/r3-actual-close-plan.md Gap 10. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): weaken predicate-execution-log claims — Phase 2 = harness-naming, not execution receipt Addresses codex/codex-default REQUEST_CHANGES on PR #3024 (/api/reviews/11316/artifacts/stdout.log, 2026-05-13T20:35:21Z): 1. Per-row status `EXECUTED` (45 rows) → `HARNESS_NAMED`. The Phase 2 PR names the close-time harness per PASSING / SATISFIED-BY-CONSTRUCTION gate so the §10 close-ceremony 24h workspace re-sweep has a mechanical command to run; it does NOT assert an execution receipt. Execution receipts (PASS/FAIL per gate, log pointers, merge-commit SHA) are produced by the §10 close-ceremony artifact `docs/audit/r3-close-YYYY-MM-DD.md`, not by this Phase 2 PR. This eliminates the conflation between "harness identification" and "execution receipt" flagged at lines 26/174/180. 2. SHA anchor: explicit "Ledger-snapshot anchor" section clarifies that `a2a7a8825` is the §1.8 ledger snapshot at this PR's base commit (`git merge-base HEAD main`), and that this PR adds only the audit doc — it does not modify §1.8 or any authority surface. The derivation is valid for any HEAD that includes `a2a7a8825` with no subsequent §1.8 edits. Resolves the "HEAD a98cbc5 vs claimed a2a7a88" single-authority/live-state mismatch (INVARIANTS P1/P2). 3. Workspace batch receipt: only `cargo fmt --all --check` and `cargo clippy --all-targets -- -D warnings` are recorded as Phase 2 partial receipts (both clean against base commit `a2a7a8825`). `cargo test` is explicitly marked NOT_EXECUTED_BY_THIS_PR and anchored to §10 close-ceremony per r3-close-interrogation.md §8 + INVARIANTS.md P3 fail-closed/live-state discipline. Status-bucket distribution table and verdict text updated consistently. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): fix 61→58 verdict count drift — bucket table is authority (PR #3024 cursor APPROVE_WITH_COMMENTS) Addresses cursor/composer-2 review at 2026-05-13T21:09Z: line 28 verdict said 'remaining 61 gates' but Status-bucket table (20+30+4+3+1=58) is the mechanical authority. 48+58=106. Aligns narrative with single-authority / live-state discipline (INVARIANTS P1/P2). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): fix INVARIANTS P1→P2 label drift per openai-pro APPROVE_WITH_COMMENTS §Ledger-snapshot anchor heading and References list incorrectly labeled the single-authority / no-parallel-authority rule as P1 (Modeling Faithfulness). The correct invariant is P2 Boundary Discipline (INVARIANTS.md:144). P3 Fail-Closed reference is unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): rebalance §1.8 status buckets — row #11 R3-LOAD-BEARING→DECLARED, row #100 PASSING→DECLARED+TEXT-RATCHETED; re-anchor to main 4b491e4 Addresses codex non-blocking finding on PR #3024 (status-bucket hygiene): - Row #11 `tc1_eta_equivalence_executable`: per §1.8 the cell starts with "**DECLARED through R3**" (canvas-deferred past R3 per Path-A); prior parser priority matched the in-cell phrase "R3-load-bearing per §1.5" before the leading "DECLARED" keyword. Row is now DECLARED. - Row #100 `project_github_actions_landed`: amended on main to "**DECLARED + TEXT-RATCHETED**" (post-merge ledger evolution beyond prior CONSUMER_LANDED + PASSING shape). Row is now DECLARED. Re-derivation against current main (`4b491e46f`): - PASSING 45→44 (row #100 demoted) - DECLARED 30→32 (rows #11 + #100 added) - R3-LOAD-BEARING 4→3 (row #11 removed) - Other buckets unchanged. - Total 106 (parity preserved). - HARNESS_NAMED 48→47; N/A_NOT_PASSING 58→59. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): tighten Purpose bullets — composite CONSUMER_LANDED + PASSING is HARNESS_NAMED, bare CONSUMER_LANDED is N/A (cursor APPROVE exploratory note PR #3024) Aligns the prose with the table: §1.8 'CONSUMER_LANDED + PASSING' (e.g. rows #1, #97, #99, #101) flows to HARNESS_NAMED via the 'contains PASSING' clause; bare 'CONSUMER_LANDED' (e.g. rows #2, #3, #96) is N/A_NOT_PASSING. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): split harness override for gate #71 — strict receipt is #[ignore]'d Addresses BLOCKING inline comment on PR #3024 at line 135 (2026-05-13T23:22Z): Gate #71 v3_self_host_demonstration: the canonical strict receipt test r3_v3_self_host_demonstration_suite_passes_through_runner is #[ignore]'d at HEAD pending T-FixedPoint / Lane 3 promotion (per the test's own ignore-doc + docs/design-fixed-point-ratchet.md). Plain `cargo test --workspace` skips it, so the prior harness column overstated coverage for this row. Fix: row #71 now uses HARNESS_NAMED (split) and cites: 1. Non-ignored portion that DOES fire under the default workspace sweep: r3_v3_self_host_demonstration_dag_lowers_with_substituted_bin_path (r3_v3_self_host_demonstration_dag_test.rs:38) + SG-0 census presence ratchet (sg0_census_test.rs:667). 2. Ignored strict receipt requiring explicit invocation: `cargo test -p v3-compiler --release -- --ignored \ r3_v3_self_host_demonstration_suite_passes_through_runner`. Adds a general convention to the §1.8 table preamble: any gate whose canonical receipt is #[ignore]'d at HEAD is flagged HARNESS_NAMED (split) and must cite both the default-sweep portion and the --ignored override. Auditors verify §8 coverage by grepping for `HARNESS_NAMED (split)` and confirming the §10 sweep includes every cited --ignored override. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): defer to close-plan per-gap dispositions; remove generic R4-defer escape hatch (codex BLOCKING PR #3024 #2) Addresses codex BLOCKING finding #2 (line 24): the prior phrase "or is operator-accepted as R4-DEFERRED per §10" reintroduced a generic R4-defer escape hatch the higher-authority close plan explicitly forecloses for Gaps 1/2/3/9 per operator §4 IN-R3 ratification 2026-05-13 (docs/r3-actual-close-plan.md §11). Replacement defers to docs/r3-actual-close-plan.md's per-gap disposition: PROVEN-with-landed-PR-only for Gaps 1/2/3/9 (R4-defer + THESIS-reframe paths STRUCTURALLY FORECLOSED), close-plan disposition for other gaps. This audit doc inherits dispositions and does not author a parallel deferral semantics. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): manager fix-forward — strip generic R4-DEFER, split-harness gate #92, ctrl-build pointer Addresses PM/Director fix-forward guidance (msg_42c90bfb 2026-05-14): 1. Line 24 close criteria: removed the remaining "R4-DEFERRED-with-operator-acceptance" language that codex review 11524 flagged as a generic escape hatch. New wording states no generic deferral; gap-specific structural blockage routes through docs/r3-actual-close-plan.md §1 + explicit Director/operator ratification recorded against the close-plan, not this audit doc. Re-swept for R4-DEFER / R4 defer / R4-defer / R4_DEFER — zero remaining occurrences in this audit doc. 2. Gate #92 row: promoted to HARNESS_NAMED (split). Even though PR #2737 removed the #[ignore] that PR #2723 added (per ledger Notes), fail-closed posture (INVARIANTS P3) requires the close-time command to explicitly invoke the named receipt rather than depend on the ignore-bit remaining off. Row now cites both the default workspace sweep portion and an explicit `cargo test -p v3-compiler -- --include-ignored complexity_violation_compile_error_demonstrated` invocation that fires the receipt regardless of ignore-bit state at the close-ceremony commit. 3. Cursor non-blocking exploratory note: added a one-line pointer that `ctrl-build` is the internal session-runtime BuildBuddy wrapper per CLAUDE.md, and that the §10 close-ceremony auditor substitutes the canonical local equivalent. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(r3): re-anchor §1.8 ledger snapshot to current merge-base c055495; row #63 DECLARED→CANVAS_RATIFIED (codex BLOCKING PR #3024 review 11585) Addresses codex BLOCKING (review 11585): the prior anchor 4b491e4 was stale relative to git merge-base HEAD origin/main (now c055495 after main auto-merged in PRs #3025, #3035, #3037, #3038, #3040, #3046, #3049, #3050). The audit doc's single-authority claim must hold against the actual merge-base, not a frozen prior commit. Codex's row count of 100 at 4b491e4 is incorrect on this worktree (verified 106 at both 4b491e4 and c055495), but the anchor-drift point is valid: per INVARIANTS P2 the authoritative §1.8 snapshot must be reproducible from the current merge-base. Re-derivation at c055495 (verified mechanically): PASSING 44 + SATISFIED-BY-CONSTRUCTION 3 + CONSUMER_LANDED 20 + DECLARED 31 + R3-LOAD-BEARING 3 + INTEGRATION_RECEIPT 3 + CANVAS_RATIFIED 2 = 106. Versus prior anchor: row #63 substrate_gap_workflow_scheduling_closed moved DECLARED→CANVAS_RATIFIED (PR #2831 squash 89df284); buckets adjust DECLARED 32→31, CANVAS_RATIFIED 1→2. HARNESS_NAMED 47 and N/A_NOT_PASSING 59 totals are unchanged (the moved row stays N/A). Row #63 audit-doc cell flipped to cite CANVAS_RATIFIED label. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Demonstrates R3 gate #92 by re-enabling the T-LAS complexity-contract compile-error integration test. The test now uses the shared cached compile outcome helper, preserves the semantic-error outcome structurally, and asserts the authored
EnforcedApplicationemits the expected ParseError diagnostic when the observed complexity exceeds aClassConstantbudget.This also removes the test from the slow-test exemption list and lowers the timeout exemption ratchet from 84 to 83.
Test plan
cargo test -p v3-compiler --test integration t_las_complexity_contract_compile_error_test::complexity_violation_compile_error_demonstrated -- --nocapture— passed on BuildBuddy after one transient log-stream retry.git diff --check origin/main...HEAD— passed.