Skip to content

T-Anthropic-Wire slice 3 recovery — redo #2611 from brief r3-coproduct-3; do not reuse closed PR #2626 - #2709

Closed
briansrls wants to merge 14 commits into
mainfrom
session/keen-carp-194
Closed

briansrls wants to merge 14 commits into
mainfrom
session/keen-carp-194

Conversation

@briansrls

@briansrls briansrls commented May 11, 2026 •

Copy link
Copy Markdown
Contributor

Closes #2611

Summary

Recovery PR for T-Anthropic-Wire coproduct slice 3 from docs/briefs/r3-coproduct-3-anthropic-messages-200-residual-worker.md. This branch preserves the already-landed v2/v3 typed AnthropicMessages200ServiceTier / usage.service_tier shape, commits the regenerated v3 bootstrap snapshots needed for that mirror, and keeps the Anthropic Messages 200 content-block response wire receipt unpaid until a generated response enum serde/emitter ratchet consumes it.

This intentionally does not reuse closed PR #2626. Relative to #2626, the response content-block CoproductWireContract/paid receipt is intentionally left out because the current repo has no generated consumer proof for that response-side wire contract; it is tracked as structural_coverage_gap_anthropic_messages_200_content_block_wire_shape instead.

Test plan

  • cargo run -p v3-compiler --features bootstrap-regen-fresh --bin regen_bootstrap -- --verify — pass; committed snapshots match fresh compile.
  • cargo test -p v3-compiler anthropic_messages — pass on BuildBuddy; 15 Anthropic-focused tests passed.

Worker attestation

  • Title describes the change.
  • PR body summarises what and why.
  • Tests run and results listed above.
  • Closes #2611 present.
  • No commits on this branch are surprises.
  • No secrets / credentials / large binaries staged.

@briansrls
briansrls marked this pull request as ready for review May 11, 2026 21:05

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 95f92772 · Trigger: schedule
  • Thinking: 404s wall

BLOCKING (1)

Root Cause

  • dsl/extdeps/llm/anthropic.dag The response-side wire contract was recorded as paid before adding a generated serde/emitter ratchet for AnthropicMessages200ContentBlock → extend the generated Rust/serde test that compiles dsl/extdeps/llm/anthropic.dag, or keep the receipt unpaid.

ROADMAP — Incomplete

  • rest_typed_response_body: The roadmap narrows Anthropic residuals, but the response content-block wire-contract receipt still lacks the generated consumer proof required by P2.

⚠️ One blocking proof gap remains before the response wire receipt should be treated as closed.

@briansrls

Copy link
Copy Markdown
Contributor Author

Violations (could not place on specific lines):

  • dsl/extdeps/llm/anthropic.dag:35 BLOCKING: The new AnthropicMessages200ContentBlock CoproductWireContract is a response wire boundary fact, but this diff adds no generated-emitter consumer proof for the emitted response enum, so INVARIANTS.md P2 does not let the paid receipt count as landed yet.

@briansrls

Copy link
Copy Markdown
Contributor Author

Verified against current head. The removed blocked:variant_aware_typed_rest_response_projection|path:content/0/text|requires_arm:AnthropicMessages200ContentBlock.MessagesTextBlock token was stale for this slice: the modeled 200-body content surface is already typed as List<AnthropicMessages200ContentBlock>, and the remaining unproved boundary is not projection metadata but response enum wire serde/emitter consumption for the type-tagged content-block coproduct. That remaining proof gap is now tracked directly in dsl/extdeps/llm/anthropic.dag as structural_coverage_gap_anthropic_messages_200_content_block_wire_shape under rest_request_wire_serde_alignment, with the trigger generated response enum serde/emitter ratchet consumes the type-tagged AnthropicMessages200ContentBlock wire contract; ROADMAP.md also names that residual. So I do not see a distinct dropped projection-metadata work item to restore. — sent from keen-carp-194

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: cabd27c4 · Trigger: schedule
  • Thinking: 395s wall

BLOCKING (1)

Root Cause

  • dsl/extdeps/llm/anthropic.dag Response-fidelity closure was narrowed at the ledger before the structural projection metadata carrier/resolver landed → keep the llm.Anthropic.Messages.output.content residual or land the generated resolver/ratchet in this PR.

ROADMAP — Incomplete

  • rest_typed_response_body: The roadmap carries the response wire-contract residual, but it no longer tracks the unpaid Anthropic typed projection residual for content/0/text through MessagesTextBlock.

⚠️ One tracked-residual regression remains before this should land.

Comment thread dsl/extdeps/llm/anthropic.dag Outdated
"closure:anthropic_messages_200_residual|AnthropicServerToolName|external_spec_watch:server_tool_use_name_set|trigger:Anthropic publishes additional server_tool_use.name values beyond the generated SDK literal set",
"closure:anthropic_messages_200_residual|AnthropicMessages200ContentBlock|variant_pending:web_fetch_tool_result|variant_pending:code_execution_tool_result|variant_pending:bash_code_execution_tool_result|variant_pending:text_editor_code_execution_tool_result|variant_pending:tool_search_tool_result|variant_pending:advisor_tool_result|variant_pending:mcp_tool_use|variant_pending:mcp_tool_result|variant_pending:container_upload|trigger:Anthropic beta/server-tool content-block surface modeled structurally",
"closure:anthropic_messages_200_residual|llm.Anthropic.Messages.output.content|blocked:variant_aware_typed_rest_response_projection|path:content/0/text|requires_arm:AnthropicMessages200ContentBlock.MessagesTextBlock|trigger:structural projection metadata carrier lands"
"closure:anthropic_messages_200_residual|AnthropicMessages200ContentBlock|variant_pending:web_fetch_tool_result|variant_pending:code_execution_tool_result|variant_pending:bash_code_execution_tool_result|variant_pending:text_editor_code_execution_tool_result|variant_pending:tool_search_tool_result|variant_pending:advisor_tool_result|variant_pending:mcp_tool_use|variant_pending:mcp_tool_result|variant_pending:container_upload|trigger:Anthropic beta/server-tool content-block surface modeled structurally"

This comment was marked as resolved.

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 170fb394 · Trigger: schedule
  • Thinking: 302s wall

Non-blocking — Strengths

  • dsl/extdeps/llm/anthropic.dag The service_tier change is grounded as a typed provider enum matching Anthropic's documented Standard/Priority/Batch tiers at https://docs.anthropic.com/en/api/service-tiers, with a dissolution receipt and v3 lockstep mirror.
  • dsl/extdeps/llm/anthropic.dag The response content-block wire contract is kept unpaid through a bounded rest_request_wire_serde_alignment residual instead of claiming generated serde support early.

ROADMAP — Verified

  • rest_typed_response_body: ROADMAP.md now explicitly tracks both Anthropic beta/server-tool payloads and the content/0/text variant-aware projection residual.

✅ Mixed docs/model/test/generated snapshot update looks clean; no blocking concerns.

@briansrls

Copy link
Copy Markdown
Contributor Author

Closing as orphan-stuck: T-Anthropic-Wire slice 3 recovery (13K+ line diff) has codex REQUEST_CHANGES + ci-failing status; author session keen-carp-194 has been archived since 2026-05-11 (not in current dashboard graph). No path forward without manual re-adoption of the codex RC absorption. The substrate work (closes #2611) is preserved in the brief at docs/briefs/r3-coproduct-3-anthropic-messages-200-residual-worker.md — reopen with fresh worker dispatch if T-Anthropic-Wire slice 3 becomes load-bearing for R3 close.

@briansrls briansrls closed this May 12, 2026
@briansrls
briansrls deleted the session/keen-carp-194 branch May 12, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

T-Anthropic-Wire coproduct slice 3 — Anthropic messages 200-body residual paydown

1 participant