Repository navigation
R3 gate #27: omni SQL DDL alternative demo - #2597
Conversation
|
Review metadata
1. Story of the diffThis PR closes R3 gate #27 by adding SQL DDL as another Shape B projection over the existing omni service route extraction path. The load-bearing move is that The tests then assert the demo contract from both sides: 2. Invariant categories
The diff preserves that boundary by emitting the comment “Shape B SQL DDL projection; not a compiler target” at
2.5. Top-down PM intent reviewCompliant. The highest-level omni intent is “one workflow declaration projects onto every layer” and “coherence between layers is structural,” with SQL schemas listed as Shape B artifacts rather than compiler targets. chatgpt-review-8e2edc3d-7f61-47… The diff’s PM-facing claim matches that: gate #27 now says the SQL projection “consumes the same workflow DAG as the runnable backend” at 3. VerdictAPPROVE. The PR adds a narrow SQL DDL Shape B demo over the existing route authority, updates the R3 receipt, and tests both the normal route set and the empty projection regression. I found no diff-cited invariant violation. |
Summary
Adds the R3 gate #27 SQL DDL Shape B alternative over the existing omni service workflow projection. The new DDL projection consumes the same compiled DAG route set as the runnable backend, and the gate test checks that the schema lists exactly the backend exposure set.
Also updates the R3 program ledger to mark
omni_sql_ddl_alternative_demoas consumer landed + passing and extends the shared-node-tree note to include SQL DDL.Review follow-up
Fixed the empty-route DDL path so it emits a valid empty schema comment without a dangling
INSERT INTO ... VALUESstatement. Addedsql_ddl_projection_emits_valid_empty_schema_without_insert_valuesas a regression test.Test plan
cargo fmtcargo test -p v3-compiler --test integration m1_5_omni_shape_b_openapi_test -- --nocapture— passed, 10 tests. BuildBuddy invocation: https://app.buildbuddy.io/invocation/8a4116ea-79ed-4d96-988e-a359a65f93a6cargo test -p v3-compiler --test integration m1_5_omni_shape_b_openapi_test -- --nocapture— passed, 11 tests after review fix. BuildBuddy invocation: https://app.buildbuddy.io/invocation/4b5ea06d-5404-4643-9f90-9df5880b6cf4