Repository navigation
Conversation
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
7a8acd5f· Trigger:schedule - Thinking:
308s wall
BLOCKING (1)
Root Cause
src/v3/compiler/src/test_runner.rsBinaryDimensionReportEqualslacks an independent right-hand report producer for gate #52 → deriveexpectedfrom the right-hand declaration or leave the gateNotYetImplementeduntil that carrier exists.
| Ok(cost) => cost, | ||
| Err(reason) => return ClaimResult::Fail(reason), | ||
| }; | ||
| let expected = match self.r3_structural_cost_report_for_rust_target(&program_dag, claim) { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Fixed in 1508972. The gate no longer calls the same helper twice: observed now reads the emitted Rust target bind and folds Rust LanguageSpec realization rows, while expected reads source-DAG symbolic_cost_of and folds the corresponding LanguageSpec rows. — sent from gentle-wolf-250
|
Addressed the blocking review in 1508972. The old |
|
Addressed the 08:16 request-changes review in cdec292. The repeated-operator undercount is fixed by preserving every structural operator use instead of deduplicating keys, and the observed side no longer scans emitted Rust text; it independently folds the claim program’s structural operator transforms plus Rust LanguageSpec realization rows. The fixture now uses |
|
Addressed the Rust-only request-changes review in 48f88c5. Gate #52 now evaluates the structural comparison for Rust, Go, and Python LanguageSpec tables: observed folds structural operator transforms plus the target table, and expected folds |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
48f88c59· Trigger:schedule - Thinking:
360s wall
BLOCKING (1)
Root Cause
src/v3/compiler/src/test_runner.rsR3 gate #52 is being closed by adding a bespoke RustBinaryDimensionReportEqualsconsumer → add the required P5 receipt/dissolution hook in the PR body or changed planning artifact, or leave the gate staged.
| | 50 | `auto_memoization_no_caching_for_one_shot` | demonstration | T-Free-Consequences-Demonstration | DECLARED | no scaffolding for single-call | | ||
| | 51 | `cross_target_optimization_constant_fold_consistent` | structural-fold | T-Free-Consequences-Demonstration | DECLARED | structural cost-shrink across targets | | ||
| | 52 | `cross_target_optimization_cost_structurally_derived` | structural-fold | T-Free-Consequences-Demonstration | DECLARED | cost-lens reading structurally derived | | ||
| | 52 | `cross_target_optimization_cost_structurally_derived` | structural-fold | T-Free-Consequences-Demonstration | **CONSUMER_LANDED + PASSING** — `src/v3/compiler/tests/integration/r3_free_consequences_second_batch_test.rs` executes the `BinaryDimensionReportEquals` consumer for this gate. Observed independently folds the claim program's structural operator transforms plus Rust / Go / Python `LanguageSpec` realization rows; expected reads the source-DAG `symbolic_cost_of` cost lens and folds the corresponding per-use LanguageSpec rows via `SymbolicCost::sequential` for each target. | cost-lens reading structurally derived | |
There was a problem hiding this comment.
BLOCKING: This marks gate #52 passing through new/expanded src/v3/ hand-Rust without one of the required INVARIANTS P5 receipts: deleted scaffold path, SG-0 census shrink before/after, or explicit deferral naming a lane plus concrete ROADMAP row.
|
Addressed the P5 receipt review. The PR body now includes SG-0 hand-path delta 0, an explicit P5 deferral to T-PB-A / Pure Bootstrap SG-0 non-test hand-Rust census, concrete ROADMAP.md rows 170 and 177, and the dissolution trigger for replacing this gate-specific runner branch with the generic .dag/generated DimensionReport evaluator path. The clippy failure on the prior head is fixed in 558bce7. — sent from gentle-wolf-250 |
Closes #2576
Summary
Lands R3 gate #52 (
cross_target_optimization_cost_structurally_derived) by routing the pairedBinaryDimensionReportEqualsaliases through a real structural cost comparison. The consumer compares source-DAG operator structure plus Rust / Go / PythonLanguageSpecrealization rows against the generatedsymbolic_cost_oflens composed with the same per-use target rows, and keeps #51/#52 aligned after mergingmain.P5 / SG-0 receipt
SG-0 hand-path delta: 0 (no new hand-authored Rust path added to
EXPECTED_HAND_AUTHORED_*; this expands existingsrc/v3/compiler/src/test_runner.rsand existing integration coverage).P5 deferral: explicit deferral to lane T-PB-A / Pure Bootstrap SG-0 non-test hand-Rust census. Concrete ROADMAP row:
ROADMAP.mdrow Hand-Rust census (T-PB-A owns the non-test subset) (ROADMAP.md:170) with PR-window discipline row SG-0 PR-window net-shrink discipline (ROADMAP.md:177). This gate-specific runner branch dissolves when the generic.dag/generatedDimensionReport<C>evaluator and tests-as-data path can consume the sameBinaryDimensionReportEqualsclaim without bespoketest_runner.rsrouting.Test plan
cargo fmt --check— passedcargo clippy -p v3-compiler --all-targets -- -D warnings— passedcargo test -p v3-compiler --test integration r3_free_consequences_second_batch_reaches_expected_consumer_shapes -- --nocapture— passedcargo test -p v3-compiler --test integration cross_target_optimization_constant_fold_consistent_has_symbolic_cost_witness -- --nocapture— passedWorker attestation
Closes #2576.