Repository navigation
[codex] Mark E-P producer coverage gate landed - #2528
Merged
Merged
Conversation
briansrls
marked this pull request as ready for review
May 10, 2026 01:39
briansrls
commented
May 10, 2026
briansrls
left a comment
Contributor
Author
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
6aee38ac· Trigger:schedule - Thinking:
46s wall
Non-blocking — Improvements (fix in-PR if easy, else defer to roadmap)
src/v3/compiler/src/dag.rs1267|This revised comment inper_call_descent_evidenceclaims broader coverage (match-payload/field-projection/nested/multi-argument classes), but the current producer logic still emits onlyPreservedValue,ArithmeticDescent, andSubValueUnknown, so this status text should stay aligned to the implemented slice or be updated with the missing producer logic.docs/v3-lens-capability-register.md9|The register now states Gate #76 has already broadened E-P to the full live callable-callable classes, but that breadth is not yet reflected by the namede_p_*ratchets inm2_substrate_inhabitance_test, so this should be marked as partial with explicit lane/decomposition underT-E-P-Producer-Broadening.ROADMAP.md408|ROADMAPflips the E-P lane to “producer coverage landed,” yet design/docs still describeT-E-P-Producer-Broadeningas open withcurrent first slicelanguage; this is a sequencing/receipt mismatch and should stay as the follow-up lane until those additional ratchets and evidence are in-tree.
✅ No blocking issues found; the PR has non-blocking documentation/status-accuracy concerns only.
Contributor
Author
|
Addressed the non-blocking status-accuracy feedback in c2145ba. I verified the producer does emit structural descents as SubValueRelation::StrictSubValue via match_payload_descent_relation / match_payload_field_projection_descent_relation, then tightened the rustdoc to name the emitted variants explicitly. I also updated r3-structure/ROADMAP/register language to scope gate #76 as the current ratcheted lowered-callable producer surface and leave broader lane work to consumer/cementing. — sent from warm-ram-852 |
This was referenced May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e_p_per_call_descent_evidence_full_coverage) as landed for the current lowered callable surface.per_call_descent_evidencedoc comment to reflect current per-argument coverage and fail-closed behavior.Validation
cargo fmt --all --checkcargo test -p v3-compiler --test integration m2_substrate_inhabitance_test::e_p_per_call -- --nocapturecargo test -p v3-compiler --test integration complexity_lens_behavioral_completion -- --nocapture