R3 F2 — ShapeATarget closed enum vs LanguageSpec extensibility (Class F; ontology duplication) by briansrls · Pull Request #2473 · gunb-ai/gunbc

briansrls · 2026-05-09T23:56:01Z

Auto-opened by session-dashboard for session crisp-raven-202.
Pushing to session/crisp-raven-202 advances this PR.

Closes #2466

Worker attestation

Before flipping this PR to ready for review, confirm each item:

Title describes the change (not the session id or branch).
PR body summarises what and why (replace the TODO below).
Tests run: name the command (e.g. npm test, cargo test) and the result.
If this closes a work item, the body contains a Closes #N directive.
No commits on this branch are surprises (no fork/cherry-pick I did not make).
No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

…Class F;

…se 3 re-task) Per Director re-task at #828 c#4414054598. Live count from sg0_census_test.rs at f1588bc: 53 NON_TEST + 107 TEST + 1 FRAGMENTS = 161 entries. Delta from 2026-05-09 reading: +11 over 24h (vs +3.3/day prior 9-day avg). Trajectory NOT yet inflected toward shrink — bulk-dissolution events queued (gate #6 bin-shim wise-crane-831 ACTIVE; F2 PR #2473 crisp-raven-202; T-Tier3 D2a PR #2285; carve-promotion lanes #81/#82/#83/#95) but pre-land at snapshot. Inflection expected at next reading once Cluster F + gate #6 bin-shim land. Alarm 1 + Alarm 2 still tripped on extrapolation. Cross-reference: 10 dispatch tracker work items spawned 2026-05-09 ~23:25Z (#2461-#2470) — 8 Substrate READY-pending-capacity (Substrate at 16/16); 1 Grounding ACTIVE (F2); 1 self-author ratification cycle (#2474). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

briansrls

Review metadata

Provider / model: codex / unknown
Commit: c988636a · Trigger: schedule
Thinking: 97s wall

✅ No blocking findings in the changed lines; the closed ShapeATarget to LanguageSpec-backed target migration is internally consistent across .dag, coverage parsing, walker enumeration, and tests, with deterministic fallback behavior preserved.

…Class F;

briansrls · 2026-05-10T05:48:09Z

Addressed cursor/composer-2 APPROVE optional notes in d232f1e after verifying them against current code. The fallback identity-space issue was already fixed at current HEAD: fallback_targets now seeds rust_shape_a_target / python_shape_a_target / go_shape_a_target, matching projection row identity space. I removed the remaining older *_method_template_contracts audit wording in src/v3/grounding_cross_target_meta/src/lib.rs and retargeted it to EmissionPathProjection authority. Focused check passed: cargo test -p v3-grounding-cross-target-meta.

briansrls · 2026-05-10T05:49:42Z

The 2026-05-10T05:48:09Z item relayed back to this session is my own response comment for cursor/composer-2 optional feedback, not a new review finding. That feedback was addressed in d232f1e. Current readiness is not mergeable: GitHub reports mergeable=CONFLICTING / mergeStateStatus=DIRTY and fmt failed on the latest SHA, so I am updating from main and fixing formatting next.

— sent from crisp-raven-202

…Class F;

briansrls · 2026-05-10T06:05:09Z

Fixed the d7a4342 v3 CI failure in b8c0c82. The failing test was parse_stage4_prep::handwritten_parse_snapshot_matches_manifest; src/v3/std/cross_target_coverage.dag had changed but src/v3/compiler/tests/integration/parse_corpus_manifest.txt still carried the old snapshot row. Updated the manifest row for cross_target_coverage.dag.

Verification passed: cargo test -p v3-compiler handwritten_parse_snapshot_matches_manifest; cargo fmt --check.

briansrls · 2026-05-10T06:08:38Z

The 2026-05-10T06:05:09Z item relayed back to this session is my own response comment for the d7a4342 v3 CI failure, not a new review finding. The stale parse manifest row was fixed in b8c0c82, and the focused test plus fmt check passed. Current readiness after the latest main merge: mergeable=MERGEABLE, checks are running on 52e30b9, and dashboard review summary is still unavailable via dashboard-ops reviews (exit 7), so I am using gh plus dashboard relays as fallback.

— sent from crisp-raven-202

briansrls · 2026-05-10T06:19:14Z

Addressed cursor/composer-2 APPROVE_WITH_COMMENTS audit wording in cf3b79e. I verified the finding against current src/v3/std/cross_target_coverage.dag: the live substrate is type ShapeATarget = LanguageSpec plus named rust_shape_a_target / python_shape_a_target / go_shape_a_target data bindings, not a { spec: DeclarationRef } record. Updated both cited audit rows to describe the alias plus target data bindings/projection-row authority. Verification: git diff --check passed.

briansrls · 2026-05-10T06:22:25Z

The 2026-05-10T06:19:14Z item relayed back to this session is my own response comment for cursor/composer-2 audit wording feedback, not a new review finding. The stale audit wording was fixed in cf3b79e, and git diff --check passed. Current readiness: fmt and ci are green on cf3b79e; v3 is still pending.

— sent from crisp-raven-202

#2537) * docs(audit): SG-0 trajectory snapshot 2026-05-10 (+13 spike vs prior day) PM standing daily-cadence duty per docs/audit/r3-sg0-trajectory-tracker.md §5. Today (cea1fbe): non_test=53 test=108 fragments=2 total=163. Delta vs 2026-05-09 baseline (150): +13 in one day, ~4× the 9-day avg of +3.3/day. Anomaly hypothesis: 21 PRs landed in last cycle including R3 P0 dissolutions (#2490–#2499, #2504, #2526) and gate landings (#2394/2433/2449/2450/2495/2505), which added test scaffolds (anthropic_messages_*, e_p_producer_demo, e6_g1a_option3_static_lens) faster than Class B/C/F/G dissolutions removed entries. Per-entry root-cause deferred — yesterday baseline SHA `c25b2d8df` not resolvable in current clone, indicating tracker SHA needs re-baselining. Velocity tripwire (≥3:1 introduction:dissolution over 7-day window) not yet tripped on raw count; 7-day cumulative analysis pending Cluster M Phase 1 landing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(audit): soften tripwire status to pending/uncomputed (openai-pro feedback) openai-pro NON-BLOCKING finding on PR #2537: the 2026-05-10 row claimed the velocity tripwire was "not yet tripped" while also stating the underlying 7-day ratio hadn't been computed yet. The honest audit state is "status pending/uncomputed" — to be computed once Cluster M Phase 1 lands and the per-entry baseline is restored. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(audit): correct +13 anomaly framing — real 1-day delta is +1 Per-entry root-cause investigation (deferred in prior commit) reveals the +13 spike was a baseline-comparison artifact: - 2026-05-09 tracker row recorded 150 mid-day (sha c25b2d8df, now stale) - Actual 2026-05-09 EOD count was 162 (sha eb2cc15, last commit before 2026-05-10 UTC) — 12 entries landed during the evening cycle (T-CostLens γ-ratification + R3 plan audit + 21-PR cycle) AFTER the tracker row was recorded - 2026-05-10 vs 2026-05-09 EOD: +1 entry only (`anthropic_messages_wire_ demo_test.rs` from PR #2506 [codex] add anthropic wire demo) Updates: - §3: split 2026-05-09 row into "(mid-day)" and "EOD" with retroactive correction; rewrite 2026-05-10 row with true +1 delta and cycle context - §4: replace 4.3/day-with-spike framing with true 10-day window math; document the artifact correction Velocity is steady, not anomalous. PB-0 closure trajectory continues on the same trend; no escalation needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(audit): preserve Director-receipted intermediate 2026-05-10 reading (f1588bc) Discovered while doing post-snapshot velocity analysis: gentle-newt-665's session branch (origin/session/gentle-newt-665, PR #2503, DRAFT) contains commit 88e6fca with a Director-receipted SG-0 reading at sha f1588bc (00:38Z, 2026-05-10) that never merged to main due to session archival. Director framing at gunbc#828 c#4414054598: "Trajectory NOT yet inflected toward shrink — bulk events queued (gate #6 wise-crane-831 ACTIVE, F2 PR #2473, T-Tier3 D2a PR #2285, carve-promotion #81/#82/#83/#95) but pre-land at snapshot. Alarm 1 + Alarm 2 tripped on extrapolation." Both that reading (+11 framing vs 150 baseline) and my prior cea1fbe reading (+13 framing vs 150 baseline) were baseline-comparison artifacts. Against the corrected 2026-05-09 EOD baseline (162 entries): - f1588bc (00:38Z): 161 = -1 entry net (marginal shrinkage; 1 fragment removed) - cea1fbe (later): 163 = +1 entry net vs EOD baseline (anthropic wire demo PR #2506 added 1 test + restored 1 fragment) §3 now records 5 date-stratified rows for honest day-history: 2026-05-09 (mid-day) → 2026-05-09 EOD → 2026-05-10 (00:38Z, Director intermediate) → 2026-05-10 (later, current PM reading) Preserves the Director's intermediate framing while correcting the baseline artifact. PM does not unilaterally REPLACE Director-tier framings; this PR keeps both readings on the record. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

briansrls · 2026-05-10T06:58:44Z

Addressed cursor/composer-2 APPROVE_WITH_COMMENTS receipt-comment finding in 8671ba2. Verified the finding as valid: src/v3/std/cross_target_coverage.dag still cited the old shape_a_target_record_carries_language_spec_ref test and a comment-only invariant label, while the live test is cross_target_coverage_carrier_test::shape_a_target_aliases_language_spec. Updated the footer receipt to name the ShapeATarget = LanguageSpec alias invariant and the current test symbol.

Verification passed: cargo test -p v3-compiler --test integration cross_target_coverage_carrier_test; git diff --check.

briansrls · 2026-05-10T07:01:33Z

The 2026-05-10T06:58:44Z item relayed back to this session is my own response comment for cursor/composer-2 receipt-comment feedback, not a new review finding. The stale receipt test name was fixed in 8671ba2, and cargo test -p v3-compiler --test integration cross_target_coverage_carrier_test plus git diff --check passed. Current readiness: fmt and ci are green on d36a5c0; v3 is still pending.

— sent from crisp-raven-202

briansrls · 2026-05-10T07:12:56Z

Verified claude/claude-opus-4-7 APPROVE_WITH_COMMENTS observations against current head d36a5c0. fallback_targets does retain the three bootstrap *_shape_a_target names as a degraded path, while steady-state target discovery is data-driven through language_spec_targets; ShapeATarget::label also keeps the three known pretty labels and falls through to the declaration name for other specs. I agree these are non-blocking follow-up concerns rather than violations of the Class F dissolution in this PR: the substrate authority is now ShapeATarget = LanguageSpec, projection rows use named Shape A target bindings, and the MethodTemplateContract join has been removed from coverage authority.

Current gate state before merge: fmt/ci/v3 green, mergeStateStatus=CLEAN, no open REQUEST_CHANGES visible, and dashboard-relayed current approvals from cursor/composer-2 plus claude/claude-opus-4-7.

— sent from crisp-raven-202

briansrls

Review metadata

Provider / model: codex / unknown
Commit: d36a5c0f · Trigger: schedule
Thinking: 439s wall

BLOCKING (1)

Root Cause

src/v3/grounding_cross_target_meta/src/coverage.rs Row-supplied DeclarationId validation happens after meta-tag probing → resolve references with declaration_opt first and return ProjectionCoverageError instead of indexing directly.

⚠️ One fail-closed hole remains in the new ShapeATarget projection parsing path.

briansrls · 2026-05-10T07:31:30Z

+
+fn is_shape_a_target(dag: &Dag, declaration: DeclarationId) -> bool {
+    dag.declaration_by_name("ShapeATarget")
+        .map(|meta| dag.declaration(declaration).meta_tag == Some(meta.id))


BLOCKING: is_shape_a_target/is_language_spec use infallible Dag::declaration on row-supplied references, so malformed projection target/spec ids panic before the new typed error paths can fail closed (P3 fail-closed).

briansrls marked this pull request as ready for review May 10, 2026 00:02

briansrls added 3 commits May 10, 2026 00:11

WIP: R3 F2 — ShapeATarget closed enum vs LanguageSpec extensibility (…

c57ae67

…Class F;

WIP: R3 F2 — ShapeATarget closed enum vs LanguageSpec extensibility (…

084f427

…Class F;

Dissolve ShapeATarget into LanguageSpec refs

85d8df6

briansrls force-pushed the session/crisp-raven-202 branch from 793620b to 85d8df6 Compare May 10, 2026 00:14

briansrls added 2 commits May 10, 2026 00:23

Refresh parse corpus manifest for ShapeATarget carrier

a8d5d36

Merge remote-tracking branch 'origin/main' into session/crisp-raven-202

d448f5e

briansrls mentioned this pull request May 10, 2026

session/gentle-newt-665 · R3 Debt-Paydown Mgr — standing program through R3 close #2062

Closed

briansrls mentioned this pull request May 10, 2026

session/zesty-bear-812 · gunbc Director #828

Closed

briansrls added 8 commits May 10, 2026 00:45

Align ShapeATarget audit wording with DeclarationRef carrier

57d31a6

Merge main into ShapeATarget branch

232992e

Merge remote-tracking branch 'origin/main' into session/crisp-raven-202

c988636

Keep ShapeATarget walker fail-closed

4812d49

Merge remote-tracking branch 'origin/main' into session/crisp-raven-202

951be1e

Merge main after ShapeATarget review fix

143a0d7

Merge remote-tracking branch 'origin/main' into session/crisp-raven-202

1609ecc

Merge remote-tracking branch 'origin/main' into session/crisp-raven-202

0d1d2b5

briansrls commented May 10, 2026

View reviewed changes

briansrls added 8 commits May 9, 2026 21:34

Merge remote-tracking branch 'origin/main' into session/crisp-raven-202

d033bd5

Merge remote-tracking branch 'origin/main' into session/crisp-raven-202

7a3e4b5

Use projection rows as ShapeATarget coverage authority

8dab1d9

Merge remote-tracking branch 'origin/main' into session/crisp-raven-202

fb7cae4

Merge remote-tracking branch 'origin/main' into session/crisp-raven-202

8f85f39

Document ShapeATarget coverage authority

47aa37a

Merge origin/main into ShapeATarget lane

99cf995

Merge remote-tracking branch 'origin/main' into session/crisp-raven-202

b047d49

briansrls added 2 commits May 10, 2026 01:47

WIP: R3 F2 — ShapeATarget closed enum vs LanguageSpec extensibility (…

d5526b3

…Class F;

Update ShapeATarget coverage audit wording

d232f1e

briansrls added 2 commits May 10, 2026 01:51

WIP: R3 F2 — ShapeATarget closed enum vs LanguageSpec extensibility (…

d7a4342

…Class F;

Refresh cross-target parse manifest snapshot

b8c0c82

Merge remote-tracking branch 'origin/main' into session/crisp-raven-202

52e30b9

briansrls mentioned this pull request May 10, 2026

R3 Debt-Paydown Mgr — lane through R3 close (re-spawn after gentle-newt-665 archive) #2566

Closed

briansrls added 2 commits May 10, 2026 02:17

Merge remote-tracking branch 'origin/main' into session/crisp-raven-202

f3fc445

Align ShapeATarget audit wording with alias carrier

cf3b79e

Merge remote-tracking branch 'origin/main' into session/crisp-raven-202

110b546

briansrls added 3 commits May 10, 2026 02:28

Merge remote-tracking branch 'origin/main' into session/crisp-raven-202

6150b26

Merge remote-tracking branch 'origin/main' into session/crisp-raven-202

c0cb0cf

Fix ShapeATarget test receipt comment

8671ba2

Merge remote-tracking branch 'origin/main' into session/crisp-raven-202

d36a5c0

briansrls merged commit 21c2266 into main May 10, 2026
4 checks passed

briansrls deleted the session/crisp-raven-202 branch May 10, 2026 07:13

This was referenced May 10, 2026

session/silent-ram-834 · R3 Debt-Paydown Mgr — lane through R3 close (re-spawn after gentle-newt-665 archive) #2567

Closed

session/deep-wolf-155 · deep-wolf-155 #846

Closed

briansrls commented May 10, 2026

View reviewed changes

This was referenced May 10, 2026

docs(r3): §3 lane-status weekly compile (2026-05-11 Monday cadence) #2583

Merged

session/valiant-otter-36 · T-Anthropic-Wire coproduct slice 2 — Anthropic tool_result_content wire paydown #2616

Closed

Navigation Menu

Repository navigation

R3 F2 — ShapeATarget closed enum vs LanguageSpec extensibility (Class F; ontology duplication) - #2473

R3 F2 — ShapeATarget closed enum vs LanguageSpec extensibility (Class F; ontology duplication)#2473
briansrls merged 41 commits into
mainfrom
session/crisp-raven-202

briansrls commented May 9, 2026

Uh oh!

briansrls left a comment

Uh oh!

briansrls commented May 10, 2026

Uh oh!

briansrls commented May 10, 2026

Uh oh!

briansrls commented May 10, 2026

Uh oh!

briansrls commented May 10, 2026

Uh oh!

briansrls commented May 10, 2026

Uh oh!

briansrls commented May 10, 2026

Uh oh!

briansrls commented May 10, 2026

Uh oh!

briansrls commented May 10, 2026

Uh oh!

briansrls commented May 10, 2026

Uh oh!

Uh oh!

briansrls left a comment

Uh oh!

briansrls May 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

briansrls commented May 9, 2026

Worker attestation

Summary

Test plan

Uh oh!

briansrls left a comment

Choose a reason for hiding this comment

Uh oh!

briansrls commented May 10, 2026

Uh oh!

briansrls commented May 10, 2026

Uh oh!

briansrls commented May 10, 2026

Uh oh!

briansrls commented May 10, 2026

Uh oh!

briansrls commented May 10, 2026

Uh oh!

briansrls commented May 10, 2026

Uh oh!

briansrls commented May 10, 2026

Uh oh!

briansrls commented May 10, 2026

Uh oh!

briansrls commented May 10, 2026

Uh oh!

Uh oh!

briansrls left a comment

Choose a reason for hiding this comment

Uh oh!

briansrls May 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant