Repository navigation
docs(r3): gate #24 partial-CONSUMER_LANDED — Int+UInt arms via single-authority HEAD state - #2429
Conversation
…-authority HEAD state Mgr-ratified scope-narrow disposition at gunbc#2068 c#4413651570 (same shape as gate #18 quiet-ibex-647 precedent, Director (c) structural- coverage at gunbc#828 c#4413633535): gate #24 numeric_reframe_no_parallel_authority closes for Int + UInt arms by HEAD construction; Float arm tracked separately on S8 ApproximateField<F> cascade. Status moves DECLARED -> PARTIAL CONSUMER_LANDED 2026-05-09: - Int arm: type Int = AbelianGroup<GroupCompletion<Nat>> at dsl/std/integer.dag:147 (Slice 3 PR #1466 Q6 single-authority form); no type Int = Int64 residue. - UInt arm: type UInt = Nat at dsl/std/integer.dag:148 (PR #1818 canonical-instance form); no type UInt = UInt64 residue. - Float arm: HELD on S8 cascade per S9 brief Phase-2 STOP-AND-ESCALATE (docs/briefs/r3-substrate-s9-t-numeric-construction-worker.md:95-100). dsl/std/float.dag:18 type Float = Float64 persists pending S8 ApproximateField<F> import; hand-rewrite ahead of S8 precluded by feedback_import_not_redeclare_carriers. Advances to full CONSUMER_LANDED upon S8 land. Audit receipt: fierce-fox-86 grep at gunbc#2068 c#4413645211. Doc/ledger-closure scope only — no code edits to dsl/std/float.dag or substrate carriers. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
90dd345a· Trigger:schedule - Thinking:
205s wall
BLOCKING (1)
Root Cause
docs/r3-program-plan.md§1.7 defines only DECLARED/CONSUMER_LANDED/PASSING and has no per-arm state-check status → keep #24 DECLARED with the Int/UInt evidence in Notes until an executable consumer lands, or define a non-closing PARTIAL status and mirror that meaning in r3-structure.
Non-blocking — Strengths
docs/r3-program-plan.mdThe factual Int/UInt/Float code-state claims in the new receipt match the PR-head files I checked.
| | 24 | `numeric_reframe_no_parallel_authority` | state-check | T-Numeric-Construction | DECLARED | old aliases removed | | ||
| | 24 | `numeric_reframe_no_parallel_authority` | state-check | T-Numeric-Construction | **PARTIAL CONSUMER_LANDED 2026-05-09** (Int + UInt arms closed; Float arm HELD on S8 `ApproximateField<F>` cascade per S9 brief Phase-2 STOP) — Int arm satisfied at HEAD by `type Int = AbelianGroup<GroupCompletion<Nat>>` at `dsl/std/integer.dag:147` (Slice 3 PR #1466 single-authority Q6 form); UInt arm satisfied at HEAD by `type UInt = Nat` at `dsl/std/integer.dag:148` (PR #1818 canonical-instance form). No `type Int = Int64` / `type UInt = UInt64` parallel-authority residue remains in `dsl/std/` or `src/v3/std/` per fierce-fox-86 grep audit at gunbc#2068 c#4413645211. Float arm: `dsl/std/float.dag:18` `type Float = Float64` parallel-authority alias persists pending S8 `ApproximateField<F>` import (currently lives in `src/v3/std/approximate_field.dag:75` only); editing `dsl/std/float.dag` ahead of S8 would parallel-declare per `feedback_import_not_redeclare_carriers`. Mgr ratification of partial-arm-closure precedent (per gate #18 #2068 c#4413651570) follows Director (c) structural-coverage at gunbc#828 c#4413633535. Advances to full CONSUMER_LANDED upon S8 cascade landing abstract Float in `dsl/std/float.dag`. | old aliases removed | | ||
| | 25 | `omni_openapi_backend_emission_demo` | demonstration | T-Omni-Shape-B | **CONSUMER_LANDED** (PR #2251 — Shape B OpenAPI 3.1 projection demo via `src/v3/compiler/src/omni_shape_b_openapi.rs` + `tests/integration/m1_5_omni_shape_b_openapi_test.rs`; refresh per cluster-analysis audit §1) | one workflow → OpenAPI + backend | | ||
| | 26 | `omni_documentation_drift_lock_demo` | demonstration | T-Omni-Shape-B | DECLARED | Markdown drift-locks against impl | |
There was a problem hiding this comment.
BLOCKING: The new PARTIAL CONSUMER_LANDED status is outside the §1.7 status taxonomy and cites HEAD code-state plus grep evidence rather than an executable gate consumer, so the canonical ledger can overstate gate #24 progress under INVARIANTS P2/P5.
…otes (§1.7 schema fix) Codex BLOCKING review on PR #2429: §1.7 status taxonomy defines only DECLARED / CONSUMER_LANDED / PASSING. The prior "PARTIAL CONSUMER_LANDED" label introduced a non-canonical status not in the schema. Per reviewer's option (1): keep Status=DECLARED; per-arm HEAD evidence (Int/UInt arms structurally clear at HEAD; Float arm HELD on S8) lives in Notes column as non-closure receipt. Status → CONSUMER_LANDED when an executable HEAD-grep consumer lands covering all three arms. Mirrors the §1.7 corpus rule: slice receipts are evidence in Notes, not closure-status promotions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Addressed BLOCKING review (codex sha 90dd345) at 869ab65. Reviewer is correct — §1.7 status taxonomy defines only DECLARED / CONSUMER_LANDED / PASSING, and "PARTIAL CONSUMER_LANDED" is not in the schema. Per reviewer's option (1): kept Status=DECLARED in §1.8 row #24 + r3-structure.md gate description; moved per-arm HEAD evidence (Int/UInt arms structurally clear; Float arm HELD on S8) into the Notes column as non-closure receipt. Status promotes to CONSUMER_LANDED when an executable HEAD-grep consumer lands covering all three arms. Mirrors the §1.7 corpus-rule pattern (slice receipts in Notes, not status-promotions). |
|
Re: inline BLOCKING at |
# Conflicts: # docs/r3-structure.md
Summary
numeric_reframe_no_parallel_authorityledger status: DECLARED → PARTIAL CONSUMER_LANDED 2026-05-09 for Int + UInt arms (already by-construction at HEAD); Float arm HELD on S8ApproximateField<F>cascade.docs/r3-program-plan.mdrow Mark LLM Code Review Pipeline V0 as complete #24 +docs/r3-structure.mdgate description. No code edits, no new substrate.Audit (per fierce-fox-86 at gunbc#2068 c#4413645211)
dsl/std/integer.dag:147—type Int = AbelianGroup<GroupCompletion<Nat>>(PR feat(std): T-Numeric-Construction Slice 3 — Int = AbelianGroup<GroupCompletion<Nat>> #1466 Q6 single-authority)dsl/std/integer.dag:148—type UInt = Nat(PR feat(std): T-Numeric-Construction S9 Phase-1 — UInt = Nat #1818 canonical-instance)type Int = Int64/type UInt = UInt64residue indsl/std/orsrc/v3/std/dsl/std/float.dag:18—type Float = Float64parallel-authority persists; deferred to S8 (ApproximateField<F>currently insrc/v3/std/approximate_field.dag:75only). Hand-rewrite ahead of S8 precluded byfeedback_import_not_redeclare_carriers.Test plan
git diffshows ledger-only edits (2 lines)dsl/std/float.dagor substrate carriers🤖 Generated with Claude Code