Repository navigation
[codex] prove integer refinement overflow parametrically - #2424
Merged
Merged
Conversation
briansrls
marked this pull request as ready for review
May 9, 2026 20:54
# Conflicts: # docs/briefs/r3-evaluator-tc3-d4-eval-step-producer-worker.md
briansrls
commented
May 9, 2026
briansrls
left a comment
Contributor
Author
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
f69f2ab8· Trigger:schedule - Thinking:
248s wall
Non-blocking — Strengths
src/v3/compiler/tests/integration/int_literal_cardinality_test.rsThe added implementation-level overflow table checks the shared MagnitudeOutOfRange path across signed, unsigned, alias, and current source-carrier-limited integer refinements without introducing substrate state.
✅ No blocking concerns in the changed Rust-test surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an R3 gate #21 integration receipt proving integer refinement overflow handling is parametric across fixed-width integer refinements, rather than a one-off
UInt8check.The new test table exercises source-representable out-of-range literals for
Int8,Int16,Int32,UInt8,UInt16,UInt32,UInt64, andUInt128, asserting the same structuralMagnitudeOutOfRangediagnostic with exact target bounds and no fabricated fixes. It also checks alias routing for the widths whose overflow edges are fully representable by the current i64 source literal carrier.Validation
cargo fmt --all --checkcargo test -p v3-compiler --test integration int_refinement_overflow_is_proven_parametric_for_representable_widths -- --nocapturecargo test -p v3-compiler --test integration int_literal_cardinality_test -- --nocapture