Repository navigation
docs(briefs): clarify markdown-table escape note in §Delta grep cells (followup #1926) - #1930
Merged
Merged
Conversation
…aterial delta vs origin/main 530c76e Re-executed live-on-main methodology vs current origin/main per Mgr dispatch (inbox #1742). All audit findings reproduce: Pop A substrate live with zero v3-side test coverage; non-Arrow Callable evaluator arm still parked; Pop B v2 dependencies and Cargo edges still present. Only drift: minor line-number shifts inside still-live declarations (substrate decls +1 line; B.2 oracle +~217 lines as the file grew). Net dispatch order unchanged; single-authority pointer to §Post-#1715 reclassification reaffirmed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…review #1805) Per Mgr non-blocking suggestion on PR #1805: add a single sentence above §A pointing readers to §Delta (2026-05-05+) for the live-offset drift table, so skimmers who land in §A.* don't mis-click on author-time line cites. Reaffirms feedback_section_anchors_over_line_numbers. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ity migration already landed (PR #1805 BLOCKING review) Per blocking review on PR #1805 (codex sha:72667918): the §Delta B.2 row incorrectly inferred from the surviving v2 oracle that Substrate authority migration is still pending. Re-grep at HEAD 530c76e shows the migration already landed: - src/v3/compiler/src/dag.rs:1789-1791 doc comment names dsl/std/algebra.dag as the semantic authority and demotes v2 stage0 to "drift ratchet". - src/v3/compiler/src/dag.rs:3596-3605 typed accessor reads the lowered data kernel_algebra_profile Map directly. - src/v3/compiler/tests/integration/m2_substrate_inhabitance_test.rs:1239 v3_kernel_algebra_profile_reads_lowered_dag_map_authority ratchets v3 reading the lowered-Dag Map authority (P0 invariant). B.2's remaining R3 PB-lane work is parity-test retirement + Cargo-edge drop, not authority migration. Net dispatch order corrected: §3.2 collapses to a PB-lane-internal mechanical retirement; no Substrate-Manager dispatch needed for B.2 disposition. Pop A gate set unaffected (still §"Post-#1715 reclassification"). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Per Director #1739 / `brief-authoring-checklist.md` §"Citation discipline" + PB Mgr dispatch (mirror of Substrate-Mgr sweep at 127287a): replace bare `file.md:NNN` references with section-anchor form across PB-owned `docs/briefs/r3-pb-*.md`. Files swept (3 of 4 with bare citations under `r3-pb-*` glob): - docs/briefs/r3-pb-runtime-equivalence-corpus-seed-audit.md (1) - docs/briefs/r3-pb-t-fixedpoint-worker.md (3) - docs/briefs/r3-pb-tier3-perf-budget-worker.md (4) Conversions: - `r2-evaluator-manager.md:27` → `r2-evaluator-manager.md` §"Owned deliverables (through R2 close)" — "Runtime value model" sub-lane row - `r3-structure.md:59`, `:60` → `r3-structure.md` §"Lane gating summary" - `r2-structure.md:296` → `r2-structure.md` §"R1 closure criteria" (the "`pb_self_compile_fixed_point` two-horizon semantics" paragraph) - `r2-pure-bootstrap-manager.md:24` → `r2-pure-bootstrap-manager.md` §"Owns (post-R1 R2 program work)" — "Tier 3 mirror dissolutions: termination" row (and analogous for :25/:26/:27 → computation / induction / effect-carrier rows) - `r2-pure-bootstrap-manager.md` §"Acceptance" line 101 → `r2-pure-bootstrap-manager.md` §"Acceptance" Verification: `grep -nE '\.md:[0-9]+' <files>` returns zero matches on the three swept briefs. Out of scope: docs/briefs/r3-pb-regen-lens-consumer-audit.md (~14 bare citations into external doc/audit corpus) — deferred to a follow-on sweep so this PR stays small per dispatch shape (≤4 files). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Follow-on to 23274a5 — completes the PB-owned `r3-pb-*.md` sweep. File: docs/briefs/r3-pb-regen-lens-consumer-audit.md (4 cells across "Documentation surface (authority chain)" and "Handoff points" tables; ~14 individual bare refs collapsed into stable section anchors). Drift fix while sweeping: the row at line 90 cited `r3-structure.md:26, :52, :107` as "T-LensProducer-Retirement sub-gate 3 acceptance"; lines 52 and 107 had drifted off-target ("Lens framework" / `anthropic_wire_*` respectively). Replaced with the canonical anchors that actually carry sub-gate 3 acceptance: §"Summary" item 2, §"Acceptance — `.dag` gates" T-LensProducer-Retirement (`regen_lens_dot_rs_retired` row), and §"Lane structure" T-LensProducer-Retirement row. Verification: `grep -nE '\.md:[0-9]+' docs/briefs/r3-pb-regen-lens-consumer-audit.md` returns zero matches. `.dag:` and `.rs:` line refs (code citations) intentionally untouched per dispatch scope. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Address BLOCKING review on PR #1831 (briansrls 2026-05-06T09:25Z). The previous sweep at 23274a5 preserved a drifted target: bare `r3-structure.md:59` / `:60` lived in §"Lane gating summary" (the 14-of-18 evaluator-gating roll-up), but the brief was citing them as authority for the `pb_self_compile_fixed_point` two-horizon semantics. That authority actually lives at r3-structure.md:89-90 under §"Acceptance — `.dag` gates" T-FixedPoint entry, "Two-horizon clarification" sub-bullet. Sweep preserved the drift instead of fixing it — same failure class as the r3-structure.md:52/:107 drift caught in 10e0355 on the regen-lens audit. Conversions (3 sites in the brief, all corrected): - §"Two-horizon framing": cite §"Acceptance — `.dag` gates" T-FixedPoint entry ("Two-horizon clarification" sub-bullet) - §"Acceptance gate (`.dag`)" intro: cite §"Acceptance — `.dag` gates" T-FixedPoint entry (`pb_self_compile_fixed_point` row + Two-horizon clarification) - "Two-horizon authority" footer cross-ref: same anchor Verification: `grep -n "Lane gating summary" docs/briefs/r3-pb-t-fixedpoint-worker.md` → 0 matches. `grep -nE '\.md:[0-9]+' docs/briefs/r3-pb-*.md` → 0 matches. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Per PB Mgr dispatch on inbox #1768 (sleek-eagle-514). Refreshes the per-surface inventory from `docs/audit/t-v2-retirement-migration-matrix.md` §2 against current `origin/main` HEAD. Docs-only; no code touched. No `src/v2/` deletion, no Cargo edge removal. Inventory + grep receipts only. Findings (refresh-class only — structural map unchanged): - Population A: 15 → 16 files (new: pb_method_template_projection_ consumability.rs). Same G-2 unit-retirement disposition. - Population B test-file line citations drifted (m2 L991→L1209 etc.); Cargo edge citations drifted (Cargo.toml L32-33 → L37-38). Constructs unchanged. - Population C dag.rs line set drifted (6 → 1 doc-comment at L1793). - 10 additional cosmetic files surfaced (gap-fill vs matrix §2.3). - Root `Cargo.toml` v2 references (L6/L8/L58/L61) inventoried — not previously listed in matrix. - G-1 closure surface count: 4 (unchanged). No new substantive v2_compiler consumer since matrix authoring at 66edec5. Cross-links every Population B/C row to migration-matrix § + S-1 input-packet decision row. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Address codex APPROVE_WITH_COMMENTS on PR #1848 (sha 6526307): the matrix-cited reproduction command `grep -rEln '...' src/ tests/` emits `grep: tests/: No such file or directory` because this repo has no top-level `tests/` (Rust integration tests live under `src/<crate>/tests/`, recursively covered by `src/`). Replaced with `src/`-only form (same match set, runs cleanly). Added §4 reproducibility note explaining the matrix's `tests/` argument is a no-op on current tree, flagging matrix doc hygiene for separate sweep. Renumbered "Constraints honored" §4 → §5. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
PB Mgr review on #1850 suggested adding a one-line note that methodology deltas were validated at merge-base after #1848 (line cites can drift on busy main). Refreshed the HEAD-verified note in the doc header to acknowledge initial-vs-follow-up validation windows + name the spot-checked surfaces. Editorial only; no inventory changes. All four PB Mgr must-fix / should-fix items already in b9958df. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Address codex REQUEST_CHANGES on PR #1850 sha f783475: `-l` prints filenames only, contradicting the doc's claim that the unified command produces "line-level enumeration" (§3 Δ7). The matrix cites `-rEln` because matrix is file-level inventory; this doc shifted to line-level but kept the `l` flag. Drop `l` → `-rEn`. Added a one-line note explaining the flag delta vs the matrix-cited form. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…edge Address codex BLOCKING on PR #1850 (sha 15faffa): the C-data row at `dsl/gunbc/compiler.dag:270` (`test_package = "v2-compiler-tests"`) was incorrectly tied to §B.2 Decision 3 (G-1 dev-dep edge retirement). That conflates two distinct removals: - G-1 / §B.2 Decision 3: deletes the dev-dep edge in `src/v3/compiler/Cargo.toml` — consumer-side dependency removed, but the `v2-compiler-tests` Cargo package itself still exists at workspace root. - G-2 / root workspace removal: deletes `src/v2/tests` workspace member (§1.4 root Cargo.toml L8) — the published package name goes away. The data row points at a *package name*, which remains valid post-G-1 and only becomes stale at G-2. Re-routed to a separate S-1 G-2 decision (CI test package retargeting), explicitly not tied to B.2/Decision 3. Updated both §1.3 C.3 row and §2 cross-ref row to reflect the correction. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
cursor optional nit on PR #1850: §2 cross-reference table listed `pb_method_template_projection_dag_emit_test.rs:28,54` while §1.3 C.2 and §3 Δ7 include L24 too. Pure doc hygiene; line set now consistent (L24,28,54). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
cursor optional polish on PR #1850: intro said "Every cell below cites a live grep / file/line on 2d26ed2" while the HEAD verified note acknowledges follow-up validations after #1848. Aligned the two: initial cells pinned to 2d26ed2; follow-up additions validated post-#1848 merge; future refreshes should re-pin HEAD before citing. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Per PB Mgr dispatch on inbox #1768 (assignment #1890): re-run §Verified row-#1 receipts against latest origin/main HEAD. Re-verification at HEAD 831080d (2026-05-06): - rg for `regen_lens_main` / `*_main -> ProcessExit` entry: no match (NOT-LIVE unchanged) - ls dsl/std/runtime/bin_shims/: README.md only (framework-only, unchanged) - All cited surfaces still resolve at the previously-pinned line numbers: process.dag :39 (ProcessExit) / :41 (ExitFailure) / :50 (exit_failure helper); bin_shim.dag :19 (BinShim type with entrypoint_name) Verdict unchanged: row-#1 NOT-LIVE; Shape A/B/C disposition is still the head-of-chain blocker. Doc body needed only the HEAD pin refresh + a re-verification note acknowledging the HEAD delta (#1503 PR-E E7, T-Numeric-Construction S9, Q-MachineConstraint #1856, T-V2 inventory #1848/#1850, etc.) without `regen_lens_main` authoring. No Shape pick. No regen_lens_main. No carrier/loader edits. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
… delta Per PB Mgr dispatch on inbox #1768 (assignment #1919, cycle #1861): re-execute §Delta methodology against current origin/main HEAD 2c7d820 after recent bootstrap/substrate churn (Q-MachineConstraint #1856, T-Numeric S9 #1840, #1807/#1892/#1903 paydown row refreshes, T-V2 inventory #1848/#1850). Verdict: no material delta. All audit findings reproduce; all zero-coverage greps still return zero; B.2 authority-migration markers in dag.rs still present. Line-anchor drift summary (vs prior §Delta @ 530c76e): - induction.dag: meet/join_sub_value -5 lines; int_pow_bounded / ceil_log / ceil_log_iter / master_theorem / derive_bound -3 lines - termination.dag: peano / positive_descent / proportional_divisor +103/+105/+106 lines (file grew substantially; symbols still live) - lib.rs Non-Arrow Callable fail-closed: shifted to :674; new second site at :2338 (same fail-closed semantics, different dispatch path) - lower.rs lower_constructor_invocation: +~89 lines - B.2 m2 oracle/shim block: structurally identical (no further drift) - Cargo edges :37-38: unchanged - dag.rs authority-migration markers: present at :1786-1798 (comment block) and :3587-3606 (typed accessor); semantic content unchanged New §Delta subsection added; freshness pointer at top refreshed to point to 2c7d820. Prior §Delta (530c76e) + B.2 reclassification preserved for audit history. Constraints honored: not S-1 authoring; no src/v2/ edits; no Cargo edge removal; no code migration. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…1926 Rest of the audit file uses `-rnE` (line-numbered output, call-site- capable per the existing per-row narrative). The new §Delta (2026-05-06) table inadvertently used `-rcE` (count-only). Aligned with the rest of the file; flag now consistent across all 8 grep invocations in §A and §Delta tables. Non-blocking nit only; no semantic change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Address codex REQUEST_CHANGES on merged PR #1926 (sha c68800f, openai-pro review 2026-05-07T00:27Z): \`\|\` inside table cells under \`grep -E\` is ambiguous in raw markdown source — \`\|\` is a markdown-table escape that renders as \`|\`, but a reader copying the raw source into a shell would get a literal pipe (no alternation). Verified both parses at HEAD \`2c7d82031\`: - as-written (literal \`\|\`): 0 matches - as-rendered/alternation (\`|\`): 0 matches The audit's "no material delta" verdict holds under either parse. The \`\|\` convention is load-bearing across the file (§Population A row cells at L25/L35/L45/L55, prior §Delta table at L183-186) — so the fix is to add a clarifying note above the §Delta table explaining the markdown-table escape, not to break the existing convention. Followup PR (since #1926 already merged before review arrived). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Review metadata
Findings: None. This diff only adjusts Verdict: APPROVE — Small, targeted doc follow-up that reduces misinterpretation of the §Delta grep rows; no rubric violations identified in the diff. |
Contributor
Author
|
Review (PB Mgr — neat-bear-351) This follow-up is worth landing: it closes the loop from the #1926 / #1919 review thread where markdown table syntax ( Verification: The cited replay forms match §Population A ( Merge posture: Docs-only — squash-merge after fmt/ci/v3 green. |
briansrls
commented
May 7, 2026
briansrls
left a comment
briansrls
left a comment
Contributor
Author
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
fe5fe43a· Trigger:schedule - Thinking:
121s wall
✅ Docs-only markdown escape clarification is consistent with the surrounding §Delta table and I found no concerns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Followup to merged PR #1926 addressing codex (openai-pro) REQUEST_CHANGES at sha `c68800fd` (review arrived ~3 min after merge): under `grep -E` raw markdown source has `\|` literal pipe ambiguity in the §Delta table cells.
Verification at HEAD `fe5fe43a3`
Both regex parses produce identical results — audit verdict holds independently:
```
\b(derive_bound|master_theorem)\b → 0 matches
\b(int_pow_bounded|ceil_log)\b → 0 matches
\b(peano_literal_materialization_cap|...)\b → 0 matches
\b(meet_sub_value|join_sub_value)\b → 0 matches
```
Same with the literal `\|` form: 0 matches across all four.
Why not change the cells
The `\|` markdown-table escape is load-bearing across the file:
Re-writing the table cells would touch 12+ lines of pre-existing audit-history convention. Adding one clarifying note is the minimum-churn fix that addresses the reviewer's concern (raw-source ambiguity) without breaking the load-bearing convention.
What this PR adds
One paragraph (3 lines) above the §Delta table:
Test plan
🤖 Generated with Claude Code