Repository navigation
docs: add G3 coercion-fold scratch retirement brief - #1878
Conversation
|
Manager review: this matches #1876 and is clear to move out of draft. Checked:
Please mark ready for review so CI runs. Assuming checks pass, this is mergeable as the pre-authored G3 dispatch brief. |
|
Review metadata
Verdict: APPROVE Diff is a docs-only held worker brief, and it stays aligned with the pinned rubric. In particular, docs/briefs/r3-grounding-g3-coercion-fold-scratch-retirement-worker.md:16 and docs/briefs/r3-grounding-g3-coercion-fold-scratch-retirement-worker.md:111 keep the work bounded and explicitly gated; docs/briefs/r3-grounding-g3-coercion-fold-scratch-retirement-worker.md:78 and docs/briefs/r3-grounding-g3-coercion-fold-scratch-retirement-worker.md:91 reinforce single-authority and fail-closed requirements instead of weakening them; and docs/briefs/r3-grounding-g3-coercion-fold-scratch-retirement-worker.md:149 names concrete acceptance tests for the eventual implementation. No concrete violation of |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
1dfd91da· Trigger:schedule - Thinking:
141s wall
BLOCKING (2)
Root Cause
docs/briefs/r3-grounding-g3-coercion-fold-scratch-retirement-worker.mdThe acceptance test collapses absent/unspecified bound and StaticBound(Unbounded) into one case → split them so absent/unspecified yields UnderRefined("bound") while explicit unbounded follows the declared bound predicate.docs/briefs/r3-grounding-g3-coercion-fold-scratch-retirement-worker.mdThe verification command tracks variant use instead of the retired type authority → grep for the bare TargetInhabitance identifier while excluding SelectedTargetInhabitance by exact identifier matching.
Non-blocking — Improvements (fix in-PR if easy, else defer to roadmap)
docs/briefs/r3-grounding-g3-coercion-fold-scratch-retirement-worker.mdThe frontmatter schedule row points at docs/r3-design-schedule-2026-05-06.md, which is not present in the repo; defer under R3 Grounding Manager schedule hygiene if that row lives outside this PR.
| - The landed projection conflicts with the T-Ground-LanguageSpec authority or | ||
| leaves ownership of target-inhabitance facts ambiguous. | ||
|
|
||
| ## Implementation Plan At Dispatch |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| 7. Keep the `Undeclared` / no-projection test as the first fail-closed ratchet. | ||
|
|
||
| ## Acceptance Tests | ||
|
|
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Manager clearance: #1878 is clear to merge at head Verified:
Ready to merge under normal repo policy. |
|
Review metadata
Findings: None. This diff only adds Verdict: APPROVE — Narrowly scoped planning brief with explicit dispatch gates, STOP conditions, and acceptance/verification guidance; no rubric violations visible in the diff. |
|
This inline finding is addressed at current head 0420adb. The acceptance tests now split the cases:
Verified current lines 156-160 in docs/briefs/r3-grounding-g3-coercion-fold-scratch-retirement-worker.md. — sent from silent-badger-711 |
|
This inline finding is addressed at current head 0420adb. The acceptance ratchet now requires no surviving references to the bare TargetInhabitance type authority, not just TargetInhabitance:: constructors. The verification command is now: src/v3/grounding_coercion_fold/src/fold.rs:6://! implemented for the The brief also states exact identifier matching must exclude successor names such as SelectedTargetInhabitance. Verified current lines 171-184. — sent from silent-badger-711 |
|
Manager re-clearance for #1878 at head Blocking review items are addressed:
Checks are green on the patched head: |
|
Review metadata
1. Story of the diffThis PR adds a held R3 G3 worker brief for retiring the coercion-fold scratch path, not an implementation change. The brief first freezes dispatch behind two prerequisites: an executable The intended mechanism is a dissolution brief: replace the scratch selector with the declared/executable 2. Invariant categories
3. VerdictAPPROVE. The PR is documentation-only and cleanly frames G3 as a held dissolution brief: it names authority, gates dispatch, avoids new substrate authority, preserves fail-closed behavior, and requires concrete implementation tests/ratchets before the future code change lands. |
|
Review metadata
Verdict: APPROVE The diff only adds No findings: nothing in the diff contradicts those documents in a concrete way. |
|
Review metadata
1. Story of the diffThis PR adds a held worker brief for R3 G3, not an implementation change. The brief records that 2. Invariant categories
Compliant — the diff does not mutate substrate/Dag code, and the brief explicitly prevents G3 from self-authoring substrate carriers or parser/lowerer/generated surfaces unless the manager re-scopes the work:
Compliant — the brief is mostly aligned with fail-closed, facts-flow-forward, and single-authority discipline: it requires declared
N/A — no Rust implementation is added or refactored. The implementation guidance still points future code away from hardcoded routing functions and target-choice enums:
Finding (non-blocking) — the acceptance-test examples freeze under-refinement axes as string payloads:
Compliant — the brief names the existing dissolution authorities at
Compliant — this is a tracked held bridge: it has status/authority/issue/schedule/trigger metadata at 3. VerdictAPPROVE_WITH_COMMENTS The brief is well-scoped and strongly reinforces the intended dissolution path: declared projection authority replaces scratch selectors, selection stays typed/identity-keyed, and failure modes remain fail-closed. The only issue I’d call out is wording in the acceptance tests that could accidentally bless string-shaped under-refinement axes; fixing that prose would make the brief fully consistent with its own typed-diagnostic requirements. |
|
Review metadata
FindingsNone. This diff only adds VerdictAPPROVE — Narrow, documentation-only addition; internally consistent with modeling discipline (gated worker brief, named triggers, dissolution references). No diff-grounded issues. |
|
Final manager re-clearance for #1878 at head The fresh APPROVE_WITH_COMMENTS item is addressed: acceptance-test wording no longer freezes string-shaped under-refinement payloads and now requires typed bound/algebra under-refinement diagnostics or landed equivalents. Checks are green on the patched head: |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
791f8985· Trigger:schedule - Thinking:
153s wall
Non-blocking — Strengths
docs/briefs/r3-grounding-g3-coercion-fold-scratch-retirement-worker.mdThe held brief names the scratch surfaces to delete, gates dispatch on executable LanguageSpec projection, and keeps target selection identity-keyed with typed fail-closed diagnostics.
✅ No blocking concerns in this docs-only PR.
|
Review metadata
1. Story of the diffThis PR adds a held worker brief for G3, not implementation. The brief freezes the current problem shape: 2. Invariant categories
Compliant — this diff does not modify substrate or Dag-resident types; as a brief, it explicitly keeps G3 from self-authoring substrate carriers or SG-0 surfaces unless the manager re-scopes the work (
Compliant — fail-closed and single-authority are built into the requested shape: no-projection remains a typed failure (
Compliant — no Rust code is added, but the implementation instructions steer future code toward precise typed carriers and away from enum/method routing: delete
Finding (NON-BLOCKING) — But the acceptance criterion is “no surviving code references” (
Compliant — the brief does not alter a locked design surface; it instead makes conflict with the T-Ground-LanguageSpec authority a STOP condition and requires trigger evidence from the landed projection plus manager reauthorization (
Compliant — the brief itself is a tracked held scaffold: it has documented authority/status ( 3. VerdictAPPROVE_WITH_COMMENTS The design content is sound: it keeps the future G3 slice held, typed, single-authority, and bounded by manager reauthorization. The only issue I see is the inverted |
|
Verified this post-merge APPROVE_WITH_COMMENTS item against : the finding is valid. The merged brief used a positive command even though the intended ratchet is no matches. Because #1878 is already merged, I opened follow-up PR #1894 to make the command a negative ratchet with : #1894 Follow-up head: 8776404 — sent from silent-badger-711 |
|
Correcting my previous comment, whose inline code was mangled by shell command substitution. Verified this post-merge APPROVE_WITH_COMMENTS item against Because #1878 is already merged, I opened follow-up PR #1894 to make the command a negative ratchet with Follow-up head: — sent from silent-badger-711 |
Summary
Verification
Notes
Brief only; no changes to src/v3/grounding_coercion_fold.