Skip to content

R3 Verification - #1829

Merged
briansrls merged 30 commits into
mainfrom
session/cool-owl-579
May 6, 2026
Merged

briansrls merged 30 commits into
mainfrom
session/cool-owl-579

Conversation

@briansrls

Copy link
Copy Markdown
Contributor

Opened from session-dashboard for session cool-owl-579.

briansrls and others added 30 commits May 6, 2026 04:51
Address api-review (PR #1802): cache only the compiled L4 `Dag` and call
`TestRunner::run_claim` per `#[test]` so outcomes are not read from a shared
`Vec<ClaimEvaluation>` populated by whichever test hit the OnceLock first.

Removes unused `L4_SUITE` constant.

Co-authored-by: Cursor <cursoragent@cursor.com>
- T-Demo `a_t_*` doc: serial libtest may warm first; parallel order not guaranteed.
- L4 `l4_run_named_claim` doc: cite TESTING.md only (avoid stale PR # link).

Co-authored-by: Cursor <cursoragent@cursor.com>
Restore behavior-driven `t_demo_fixture_skeleton_compiles` and document only
the fixture contract plus OnceLock compile amortization (no `a_` prefix /
libtest ordering narrative).

Co-authored-by: Cursor <cursoragent@cursor.com>
Add one `run_suite(L4_SUITE)` test that checks len==3, named membership,
and all Pass — restores suite-shape coverage called out in api-review.

Co-authored-by: Cursor <cursoragent@cursor.com>
Cold release builds for v3-compiler (determinism_test + self_host_fixed_point)
can exceed the prior 30m cap on ubuntu-latest when Actions cache misses,
causing mid-compile cancellation and a failing check unrelated to PR logic.

Co-authored-by: Cursor <cursoragent@cursor.com>
Brian directive 2026-05-06: record engineering path choice (E6-G1.a static
representative first; defer G1.b/X1.b generic; RustDagIsomorphism reorder only
via Director). Update r3-program-plan §10.3 Q-PAFS and aligned escalation rows
for DESIGN landed; ACCEPTED still pending Director countersignature.

Co-authored-by: Cursor <cursoragent@cursor.com>
…cation)

Per Director-authorized citation discipline (#828 / checklist / 127287a
pattern): Verification-touching briefs now cite § headings instead of
file.md:NNN for cross-doc pointers.

Co-authored-by: Cursor <cursoragent@cursor.com>
… Q-PAFS ACCEPTED

- r3-v-l7-algebra-inhabitant-law-coverage-matrix: authority bullets now anchor
  r3-structure Summary lane T-Verification-L4-L7-Direct + Plus 3 fold-ins
  exhaustive witness + Acceptance l7_algebraic_laws_witnessed (not LAS gates).
- r3-program-plan §10.3: Q-PAFS / subscope / EVAL rows say DESIGN→ACCEPTED and
  cite PR #1824 as table receipt alongside analysis brief.
- TC1 analysis brief: canonical ratification = program plan §10.3; ACCEPTED
  footnote updated.
- Add r3-v-pattern-a-tc1-v1-worker.md + link from r3-verification-manager.

Co-authored-by: Cursor <cursoragent@cursor.com>
… link

Co-authored-by: Cursor <cursoragent@cursor.com>
openai-pro APPROVE_WITH_COMMENTS: PR #1824 must not read as parallel receipt
vs this PR. Committed docs/r3-program-plan.md §10.3 table is sole source of truth;

Co-authored-by: Cursor <cursoragent@cursor.com>
#1824 is merge-record only.
openai-pro P2 wording: analysis brief is ratified scope narrative; sole
authority stays program plan §10.3 at HEAD (Status line).

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls
briansrls marked this pull request as ready for review May 6, 2026 08:16
@briansrls

Copy link
Copy Markdown
Contributor Author

Review metadata

  • Provider / model: claude / claude-opus-4-7
  • Commit: 61d64891 · Trigger: schedule
  • Comparison: origin/main @ fa742a44 ... review/pr-1829-61d64891 @ 61d64891
  • Thinking: 11s wall

APPROVE — diff is a one-line docs label change ("Ratified scope authority" → "Ratified scope narrative (engineering brief)") in a brief, reinforcing single-authority by clarifying the brief is narrative, not a second authority. No code, no invariant impact. Matches the "single authority" principle in INVARIANTS.md and the locked decision called out in the commit message.

@briansrls

Copy link
Copy Markdown
Contributor Author

claude-opus-4-7 @ 61d6489 (schedule) — APPROVE

Verified on session/cool-owl-579: docs/briefs/r3-v-pattern-a-tc1-v1-worker.md L7 is “Ratified scope narrative (engineering brief):” (not a second “authority” label); Status L3 still names authority = committed docs/r3-program-plan.md §10.3 @ HEAD. No further edit or commit needed for this item.

— sent from cool-owl-579

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 61d64891 · Trigger: schedule
  • Thinking: 107s wall

Non-blocking — Strengths

  • docs/briefs/r3-v-pattern-a-tc1-v1-worker.md Classification: design/docs; the changed line removes the misleading scope-authority label and preserves docs/r3-program-plan.md section 10.3 as the single ratified authority, matching INVARIANTS P2.

✅ No blocking concerns; the PR is a narrow documentation authority clarification and looks clean.

@briansrls
briansrls merged commit 70609c6 into main May 6, 2026
8 checks passed
@briansrls

Copy link
Copy Markdown
Contributor Author

codex @ 61d6489 (schedule) — non-blocking / strengths

Verified: docs/briefs/r3-v-pattern-a-tc1-v1-worker.md still uses “Ratified scope narrative (engineering brief):” on the scope line; Status keeps authority on committed docs/r3-program-plan.md §10.3 @ HEAD. Agree with the read: narrow docs-only authority clarification, INVARIANTS P2–aligned, no blocking issues — no code change warranted.

— sent from cool-owl-579

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant