Repository navigation
R3 Verification - #1829
R3 Verification#1829
Conversation
Address api-review (PR #1802): cache only the compiled L4 `Dag` and call `TestRunner::run_claim` per `#[test]` so outcomes are not read from a shared `Vec<ClaimEvaluation>` populated by whichever test hit the OnceLock first. Removes unused `L4_SUITE` constant. Co-authored-by: Cursor <cursoragent@cursor.com>
- T-Demo `a_t_*` doc: serial libtest may warm first; parallel order not guaranteed. - L4 `l4_run_named_claim` doc: cite TESTING.md only (avoid stale PR # link). Co-authored-by: Cursor <cursoragent@cursor.com>
Restore behavior-driven `t_demo_fixture_skeleton_compiles` and document only the fixture contract plus OnceLock compile amortization (no `a_` prefix / libtest ordering narrative). Co-authored-by: Cursor <cursoragent@cursor.com>
Add one `run_suite(L4_SUITE)` test that checks len==3, named membership, and all Pass — restores suite-shape coverage called out in api-review. Co-authored-by: Cursor <cursoragent@cursor.com>
Cold release builds for v3-compiler (determinism_test + self_host_fixed_point) can exceed the prior 30m cap on ubuntu-latest when Actions cache misses, causing mid-compile cancellation and a failing check unrelated to PR logic. Co-authored-by: Cursor <cursoragent@cursor.com>
Brian directive 2026-05-06: record engineering path choice (E6-G1.a static representative first; defer G1.b/X1.b generic; RustDagIsomorphism reorder only via Director). Update r3-program-plan §10.3 Q-PAFS and aligned escalation rows for DESIGN landed; ACCEPTED still pending Director countersignature. Co-authored-by: Cursor <cursoragent@cursor.com>
… Q-PAFS ACCEPTED - r3-v-l7-algebra-inhabitant-law-coverage-matrix: authority bullets now anchor r3-structure Summary lane T-Verification-L4-L7-Direct + Plus 3 fold-ins exhaustive witness + Acceptance l7_algebraic_laws_witnessed (not LAS gates). - r3-program-plan §10.3: Q-PAFS / subscope / EVAL rows say DESIGN→ACCEPTED and cite PR #1824 as table receipt alongside analysis brief. - TC1 analysis brief: canonical ratification = program plan §10.3; ACCEPTED footnote updated. - Add r3-v-pattern-a-tc1-v1-worker.md + link from r3-verification-manager. Co-authored-by: Cursor <cursoragent@cursor.com>
… link Co-authored-by: Cursor <cursoragent@cursor.com>
openai-pro P2 wording: analysis brief is ratified scope narrative; sole authority stays program plan §10.3 at HEAD (Status line). Co-authored-by: Cursor <cursoragent@cursor.com>
|
Review metadata
APPROVE — diff is a one-line docs label change ("Ratified scope authority" → "Ratified scope narrative (engineering brief)") in a brief, reinforcing single-authority by clarifying the brief is narrative, not a second authority. No code, no invariant impact. Matches the "single authority" principle in |
|
claude-opus-4-7 @ 61d6489 (schedule) — APPROVE Verified on — sent from cool-owl-579 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
61d64891· Trigger:schedule - Thinking:
107s wall
Non-blocking — Strengths
docs/briefs/r3-v-pattern-a-tc1-v1-worker.mdClassification: design/docs; the changed line removes the misleading scope-authority label and preserves docs/r3-program-plan.md section 10.3 as the single ratified authority, matching INVARIANTS P2.
✅ No blocking concerns; the PR is a narrow documentation authority clarification and looks clean.
|
codex @ 61d6489 (schedule) — non-blocking / strengths Verified: — sent from cool-owl-579 |
Opened from session-dashboard for session
cool-owl-579.