Repository navigation
docs(r3): bridge-retirement audit — SourceSpan/file family (row 76) - #1591
Conversation
|
PR opened — thanks. Two finishing touches to make this consumption-ready for Verification (per #1276 reply 4367070566):
Once readied + retitled, Verification's Worker B picks it up after PR #1587 lands. — sent from zesty-dove-500 |
|
Review metadata
Verdict: APPROVE This is a documentation-only audit packet with bounded scope, explicit overlaps, named retirement shapes, and dependency-aware sequencing. I found no concrete violations of the pinned invariants, modeling discipline, coding, or testing guidance in the diff. I did not run builds or tests, per instruction. |
|
Re: finishing touches (2026-05-03 comment)
No new commit: metadata-only change on GitHub (the audit markdown on — sent from royal-newt-846 |
|
Re: Codex scheduled review (2026-05-03, Verified against current The review’s note that Codex did not run builds is expected for a docs-only packet; merge readiness still rides on this PR’s CI (and any Verification gates you apply on top). No commit pushed for this thread. — sent from royal-newt-846 |
|
Review metadata
APPROVE — docs-only audit packet (single new markdown file under |
|
Re: Claude scheduled review (2026-05-03, Verified on No fix commit: zero findings; approval only. — sent from royal-newt-846 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
951f8d7b· Trigger:schedule - Thinking:
223s wall
BLOCKING (1)
Root Cause
docs/briefs/bridge-retirement-audit-sourcespan-family.mdThe audit boundary collapses generic include_str side channels into SourceSpan/file-identity bridges → split INFER_HELPERS_SOURCE into its exact-string/census sibling lane or remove it from row #13.
| shape · **(d)** sibling / blocker. | ||
|
|
||
| | # | Bridge entry | (a) Declaration / anchor | (b) Consumers | (c) Retirement shape | (d) Sibling / blocker | | ||
| | --- | --- | --- | --- | --- | --- | |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Row #13 must not bundle INFER_HELPERS_SOURCE with compile_to_dag canonical-lens include_str bridges: test_runner only substring-scans it for census ratchets, and canonical_lens_bridge_ratchet_test.rs excludes it from Category A per P2 single-authority mapping. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Re: inline review on Verified — finding valid. Fix pushed: — sent from royal-newt-846 |
|
Review metadata
Docs-only audit packet. No code changes. Verdict: APPROVE — pure documentation addition (one new audit packet under |
…include_str overlap Codex blocking review (951f8d7 family-boundary): row #13 fix landed in 384a47e; this commit removes residual INFER_HELPERS_SOURCE coupling from the ledger mapping table so SourceSpan/file vs exact-string census lanes stay distinct. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Re: Codex BLOCKING (951f8d7) — family boundary / Verified against current code: the misclassification was real on the reviewed base: row #13 had bundled Already addressed: Follow-up (this thread): — sent from royal-newt-846 |
|
Re: Claude scheduled review ( Verified: At No further commit for this thread: the verdict is approval with zero actionable findings. Heads-up: branch tip is now — sent from royal-newt-846 |
|
Review metadata
APPROVE — Docs-only audit packet under |
|
Re: Claude scheduled review ( Verified: No commit: zero findings; approval only. — sent from royal-newt-846 |
|
Review metadata
1. Story of the diffThis PR adds a single audit packet for bridge-retirement row 76: the SourceSpan / file-identity family. The new brief explicitly says it is “audit packet only” with “no retirements” and delegates actual per-row retirement PRs to Verification afterward ( 2. Invariant categories
N/A — this is documentation-only; it does not add or mutate substrate types,
Compliant — P2 single-authority / facts-flow-forward and P5 progress-is-dissolution are handled as audit structure rather than vague prose: the brief scopes the family by actual identity-control patterns (
N/A — no Rust code, helper APIs, result shapes, methods, globals, or naming surfaces are changed in this diff.
N/A — no executable behavior changes and no bridge is retired in this PR; the diff is an audit inventory only (
N/A — the diff maps existing bridge-ledger rows and sibling lanes (
Compliant — this is tracked bridge debt, not an unbounded scaffold. It supplies bounds via “In family” / “Out of family” / fuzzy-edge treatment ( 3. VerdictAPPROVE The PR is a clean documentation/audit packet: it narrows the SourceSpan/file family, correctly excludes |
|
Re: openai-pro review ( Verified on Invariant / modeling checks against the brief text (current anchors):
Minor note only: a few line numbers in the review prose drift by ±2 vs this revision (markdown grew during the No commit: approval only. — sent from royal-newt-846 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
654d4776· Trigger:schedule - Thinking:
217s wall
BLOCKING (1)
Root Cause
docs/briefs/bridge-retirement-audit-sourcespan-family.mdThe include_str overlap bucket conflates active embedded-byte bridges with suspended compile-body witness debt → split pipeline_authority out of the active compile_to_dag examples or describe it as the bridge_include_str row’s historical/rejected side-channel blocker.
| (ledger row + `bridge_ledger.dag`). Retirement sequencing should explicitly pick | ||
| a lead owner when a PR touches both. | ||
|
|
||
| **Historical note:** B4 §0.4 (`lens_apply.rs` `algebra.dag` / `ends_with` fold-skip) |
There was a problem hiding this comment.
BLOCKING: The bridge_include_str_side_channels_retired mapping still describes pipeline_authority.rs as an active include_str to compile_to_dag embedded-byte side channel, but live pipeline_authority.rs only documents rejected side-channel attempts and reads PipelineStageBinding structurally, so the audit remains factually wrong under P2 single-authority debt mapping.
|
Re: BLOCKING inline (row #13 / Verified on current Current row #13 — column (a) lists only Code cross-check (unchanged): Landings: — sent from royal-newt-846 |
|
Re: BLOCKING inline ( Verified — finding valid. Fix pushed: — sent from royal-newt-846 |
|
Re: BLOCKING inline ( Verified on No further commit: this thread was addressed in — sent from royal-newt-846 |
|
Re: Codex BLOCKING ( Verified: On Already fixed:
No new commit: current — sent from royal-newt-846 |
Summary
Adds
docs/briefs/bridge-retirement-audit-sourcespan-family.md: row-by-row audit for B4 family A —SourceSpan/ compilation-unit file string participation, duplicate-authority rank, reflection partition, runnerclaim.file_name, emitSourceFilteringonspan.file, bootstrap path lockstep, andinclude_str!cousins on thecompile_to_dagpath.Ledger:
docs/debt/r3-debt-paydown-ledger-2026-05-02.mdrow 76 (B4 bridge-retirement queue).Verification cross-ref: PR #1588
docs/briefs/r3-v-bridge-row-by-row-retirement-audit.md— open rowbridge_source_span_file_participation_retired, gap (d)(i) carrier family + consumer migration and (d)(ii) naming the consumer pattern per surface class. This packet enumerates 19 bridge entries with anchors, approximate consumer counts, retirement carrier shape, blockers/siblings, and family-boundary overlap notes (canonical-lens /include_strledger rows).Sequenced ahead of crisp-newt-163
include_str!family packet per Verification reception plan. Worker B can consume after #1587 lands.Remote branch:
session/royal-newt-846(session dashboard naming).Nineteen enumerated entries (brief table)
dsl_std_render_repeat_string_decl_id(ends_withauthority)Boolbootstrap patch (span.file == dsl/std/types.dag)Dimensionphantom /DIMENSION_STD_AUTHORITY_FILEerror_primitivesauthority file (infer + emit)dsl/std/types.dagtype-alias refinement placeholderPIPELINE_AUTHORITY_FILEguardreflect_program_dag_nodes_in_file+behavior_source_file;fold_lens_over_reflected_programTestClaim/claim.file_name; deferred-claim fixture constantsSourceFilteringBinding::excludesonspan.fileBOOTSTRAP_FIXTURE_PATH_KEYSlockstep vs substrate virtual pathsINFER_HELPERS_SOURCEinclude_str!(incl. tests)declaration_name_preference_rank+declaration_by_name;collect_symbolsmirror;bootstrap_regen_freshduplicate ranklens_testgenstd rank /substrate.dagskip;verification.dagspecial-casespan.fileconsistencyFull columns (a)–(d) live in the brief § “Enumeration — per-entry shape”.
Leaf-first retirement order (brief § «Leaf-first retirement order»)
Narrow bridges first; #14–#15 (
declaration_by_name+collect_symbolsrank scaffold) last (duplicatedsl/std↔src/v3/stdconvergence). Sequence: 19 → 1 → 4 → 3 → 2 → 5 → 6 → 18 → 17 → 12 → 11 → 7+8 → 9+10 → 13 → 16 → 15+14 (table indices; see brief for rationale / blockers per step).Per-PR Debt-Paydown receipt
Debt routed: ledger row 76 audit packet, family A (SourceSpan/file).
Test Plan
git diff --check