feat(v3): classify string_contains in method registry; populate Python+Go contract rows

[briansrls]

Summary

• Debt paid: ROADMAP.md:512 / docs/debt/r3-debt-paydown-ledger-2026-05-02.md:85 — Method-template consumer migration. Closes one of the five Phase-2 blockers from the docs(grounding): method-template consumer migration audit-to-retirement #1549 audit (Gap 1 — string_contains classification + skipped Python/Go contract rows).
• Substrate: dsl/std/methods.dag adds string_contains_method: MethodDeclaration = { name: "string_contains" } and broadens the documented registry scope to include target-only emit-shortcut method names. Rationale: the legacy emit map (dsl/extdeps/languages/{python,go}/emit.dag) disambiguates the String-substring shape from the collection-membership contains shape by name; v3's flat-name registry preserves that disambiguation by promoting string_contains to a first-class MethodRef row key rather than overloading contains_method.
• Per-target rows populated:
  • src/v3/std/python_method_template_contracts.dag — {arg} in {recv} (matches python/emit.dag:95).
  • src/v3/std/go_method_template_contracts.dag — strings.Contains({recv}, {arg}) (matches go/emit.dag:87).
  • Both files retire the "deferred to Phase 2 / Modeling" header for this row.
• Snapshot/manifest refreshes follow mechanically (regen helpers, not hand-edited): bootstrap_{generated,generated_without_parse_surface,std_generated}.rs and parse_corpus_manifest.txt.

Out of scope (per dispatch): Phase-2 deletion of legacy *_method_templates, LanguageSpec rewrite, PB projection work, Go chars row (#1549 Gap 4 — separate tokenizer-level issue).

Test plan

• cargo test -p v3-compiler --test integration -- method_registry method_template_contract m2_substrate_inhabitance — 78 passed (covers method_registry_covers_all_algebra_template_names, method_template_contract_per_target_dag_method_unique, bootstrap_method_template_contracts_lower_to_list_with_empty_diagnostics).
• cargo test -p v3-compiler --test integration — 768 passed; 26 ignored; 0 failed.
• cargo run -p v3-compiler --features bootstrap-regen-fresh --bin regen_bootstrap — clean regen.
• cargo test -p v3-compiler --test integration handwritten_parse_snapshot_matches_manifest passes after refresh.
• cargo clippy -p v3-compiler --all-targets -- -D warnings.
• cargo fmt --all --check (pre-push hook).

🤖 Generated with Claude Code

[briansrls]

Review metadata

• Provider / model: cursor / composer-2
• Commit: 918f475e · Trigger: schedule
• Comparison: origin/main @ 94c479cf ... review/pr-1561-918f475e @ 918f475e
• Thinking: 44s wall

---

Findings: None. The substantive change is registry plus contract data: string_contains_method in dsl/std/methods.dag with comments that explain target-only vs algebra contains and point at the locked inbox work; matching MethodTemplateContract rows in python_method_template_contracts.dag and go_method_template_contracts.dag using dag_method: { decl: string_contains_method }; parse_corpus_manifest.txt updated for the touched .dag files; bootstrap Rust regenerated. That aligns with P2 (single MethodRef authority instead of a bare-name gap), P1/P5 (closes the previously deferred classification with an explicit rationale and named receipts), and does not introduce fail-open paths, new enums without classification, or test-style issues in the diff itself.

Verdict: APPROVE — Small, coherent closure of the documented string_contains registry/row gap; nothing in the reviewed diff contradicts INVARIANTS, modeling discipline, CODING, or TESTING in a way that warrants a change request.

[briansrls]

Review pass on #1561: the implementation matches the Gap 1 dispatch.

Checked the diff against current main: dsl/std/methods.dag adds string_contains_method as a target-only emit-shortcut MethodDeclaration and documents why it is distinct from algebra contains; Python and Go contract files import that key and add rows matching the legacy emit templates ({arg} in {recv} and strings.Contains({recv}, {arg})). The previous deferral comments are retired, and the PR keeps Phase-2 deletion / LanguageSpec rewrite / PB projection / Go chars out of scope.

Generated churn looks proportionate: bootstrap_std_generated.rs, full bootstrap snapshots, and parse_corpus_manifest.txt move with the new std method declaration and row changes. I did not find a code blocker in the changed hunks.

I did not rerun the full local validation here; the PR body already reports full v3, targeted method registry/template/substrate tests, clippy, fmt, bootstrap regen, and manifest verification.

— sent from jolly-ram-908 (inbox #1130); reply at #1130

[briansrls]

Review metadata

• Provider / model: claude / claude-opus-4-7
• Commit: 71061a1b · Trigger: schedule
• Comparison: origin/main @ 0427f96f ... review/pr-1561-71061a1b @ 71061a1b
• Thinking: 14s wall

---

APPROVE — Diff is narrowly scoped and clean: adds string_contains_method to the registry (with comment justifying target-only emit-shortcut classification distinct from algebra contains), adds matching rows in Python and Go contract lists referencing the MethodRef, and updates the parse-corpus manifest hashes for the two changed .dag files. The change resolves a previously-flagged "open classification" comment and replaces the bare-string TODO with a real MethodDeclaration authority — directly aligned with single-authority / MethodRef-over-string discipline. No invariant violations observed.

[briansrls]

Review metadata

• Provider / model: codex / unknown
• Commit: 71061a1b · Trigger: schedule
• Thinking: 399s wall

---

Non-blocking — Improvements (fix in-PR if easy, else defer to roadmap)

• dsl/std/methods.dag Because dsl/std/algebra.dag already has FreeMonoid scalar contains, the new target-only string_contains entry should explicitly say it is a legacy emit alias and name its dissolution trigger under #1549 Gap 1/R3 if deferred.

✅ No blocking concerns; the Python and Go contract rows preserve MethodRef authority and the target template shapes look consistent.

[briansrls]

Review metadata

• Provider / model: cursor / composer-2
• Commit: b343c797 · Trigger: schedule
• Comparison: origin/main @ 7cd1cecd ... review/pr-1561-b343c797 @ b343c797
• Thinking: 59s wall

---

Findings: None. The substantive diff adds a documented legacy-alias MethodDeclaration in dsl/std/methods.dag with an explicit dissolution trigger (#1549 / algebra-profile-keyed dispatch), wires Python and Go MethodTemplateContract rows to string_contains_method (single registry authority, not a second template source), and refreshes parse_corpus_manifest.txt for the edited contract DAGs. That matches P2 / single-authority and the “tracked scaffold” expectations in INVARIANTS.md and docs/modeling-discipline.md rather than violating them. Large bootstrap_*_generated*.rs churn is mechanical fallout from the registry change, not a new Rust design surface; nothing in the diff suggests new fail-open paths or duplicate competing authorities for the same render fact.

Verdict: APPROVE — Narrowly scoped, consistent with the rubric, and the legacy-alias story is explicitly bounded and dissolvable.

Exploratory observations (optional): src/v3/std/methods.dag (not in this diff) still describes the dsl registry as “the 63 per-method data bindings”; after this PR the dsl file adds at least one extra binding beyond the algebra union, so that companion comment may deserve a tiny follow-up alignment later if you care about comment-level precision.

[briansrls]

Review metadata

• Provider / model: cursor / composer-2
• Commit: 72bd2880 · Trigger: schedule
• Comparison: origin/main @ 98caedb8 ... review/pr-1561-72bd2880 @ 72bd2880
• Thinking: 33s wall

---

Findings

• dsl/std/methods.dag:39–40 (comment prose) — Minor CODING.md / readability nit only: the header comment contains literal backslash-escaped quotes (\"Method-template / migration\") where normal quotation marks (or no nested quotes) would read cleanly. Not an invariant violation; optional cleanup.

Verdict

APPROVE — The diff wires string_contains as an explicit legacy alias in dsl/std/methods.dag, documents why it exists separately from algebra contains, and states a named dissolution trigger tied to #1549 / profile-keyed dispatch, which matches P5 tracked-bridge expectations in INVARIANTS.md. Python and Go MethodTemplateContract rows point at string_contains_method with templates aligned to existing v2 emit maps; src/v3/std/methods.dag companion comment stays consistent. Bootstrap/regenerated Rust churn follows from the new declaration. Nothing in the diff suggests P2 parallel semantic authority: the text is explicit that algebra does not split and the alias is for bare-string / MethodRef keying.

Exploratory observations (optional)

• The large bootstrap_generated*.rs diffs are mechanical IDshift from one new MethodDeclaration; expected for this kind of change in this repo.

[briansrls]

Review metadata

• Provider / model: cursor / composer-2
• Commit: 0acc4528 · Trigger: schedule
• Comparison: origin/main @ 98caedb8 ... review/pr-1561-0acc4528 @ 0acc4528
• Thinking: 24s wall

---

Reviewed the rubric excerpts and the full substantive diff (dsl/std/methods.dag, src/v3/std/*.dag, manifest). The remainder of the change is regenerated bootstrap (bootstrap_generated*.rs, bootstrap_std_generated.rs) driven by the DAG edits—mechanical ID/layout churn, not hand-authored logic.

Findings: None. The legacy string_contains entry is documented with an explicit dissolution trigger and scope (#1549 / v2 emit migration), satisfying the “tracked scaffold” pattern from the modeling discipline lens. Contract rows wire string_contains_method to the intended Python and Go templates and update imports consistently. parse_corpus_manifest.txt checksum updates match the touched .dag files per integration-test expectations (TESTING.md: corpus pins).

Verdict: APPROVE — Narrowly scoped registry + contract alignment; no concrete violations of INVARIANTS.md, docs/modeling-discipline.md, CODING.md, or TESTING.md visible in the authored diff.

[briansrls]

Review metadata

• Provider / model: codex / unknown
• Commit: 0acc4528 · Trigger: schedule
• Thinking: 245s wall

---

Non-blocking — Strengths

• dsl/std/methods.dag The alias classification is tracked bridge debt: documented, bounded to v2 bare-string emit dispatch, and tied to algebra-profile-keyed dispatch as the dissolution path.
• src/v3/std/python_method_template_contracts.dag The new row preserves MethodRef authority and matches the legacy Python substring render shape.
• src/v3/std/go_method_template_contracts.dag The new row preserves MethodRef authority and matches the legacy Go strings.Contains render shape.

✅ No blocking concerns; the prior classification gap is resolved cleanly.

[briansrls]

Review metadata

• Provider / model: codex / codex-default
• Commit: 3cf8cc59 · Trigger: schedule
• Comparison: origin/main @ 5ef6530c ... review/pr-1561-3cf8cc59 @ 3cf8cc59
• Thinking: 48s wall

---

Verdict: APPROVE

The diff is narrowly scoped and the string_contains legacy alias is documented as bounded transitional debt with a clear dissolution trigger. Python/Go rows point at the new MethodRef entry and match the existing legacy emit templates. No concrete violations of the pinned modeling, coding, or testing guidance observed. Tests not run per instruction.

[briansrls]

Review metadata

• Provider / model: claude / claude-opus-4-7
• Commit: f7284f55 · Trigger: schedule
• Comparison: origin/main @ d4056ec8 ... review/pr-1561-f7284f55 @ f7284f55
• Thinking: 11s wall

---

APPROVE — narrow, well-documented change. Adds string_contains_method to the registry with a clear header explaining the legacy-alias convention and a named dissolution trigger (v2 emit migrating to algebra-profile-keyed dispatch, #1549 R3), then wires Python and Go contract rows referencing it. Resolves the previously-deferred Phase 1 gap; comments in the contract files were updated in lockstep so the rationale stays consistent across the three sources. Generated bootstrap files and the parse-corpus manifest hashes regenerate as expected.

No findings.

[briansrls]

Review metadata

• Provider / model: codex / unknown
• Commit: f7284f55 · Trigger: schedule
• Thinking: 225s wall

---

Non-blocking — Strengths

• dsl/std/methods.dag The string_contains alias is documented, bounded to legacy v2 bare-string emit dispatch, and has a named dissolution trigger into algebra-profile-keyed contains dispatch.
• src/v3/std/go_method_template_contracts.dag The Go row preserves MethodRef authority and matches the legacy strings.Contains({recv}, {arg}) render shape for substring contains.
• src/v3/std/python_method_template_contracts.dag The Python row preserves MethodRef authority and matches the legacy {arg} in {recv} render shape for substring contains.

✅ No blocking concerns.