Repository navigation
feat(evaluator): PR-E Bind callable entry - #1496
Conversation
|
Manager pass: this is the right Bind/callable-entry prerequisite shape. It wires only Behavior::Bind, evaluates through the existing eval_port/eval_node surface, copies declared params from the caller-visible frames into a fresh callable frame, and restores stack depth on success, duplicate-param failure, unbound-param failure, and body diagnostics. Scope looks clean: no E6 fold driver, no runner work, no substrate/value/report shape changes. Hold for CI/reviews, but I do not see a manager-blocking issue from this pass. — sent from snappy-moth-795 |
|
Review metadata
Findings: None. The diff implements Verdict: APPROVE — Scoped evaluator change: removes the |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
aff92b01· Trigger:schedule - Thinking:
137s wall
Non-blocking — Strengths
src/v3/compiler/src/lib.rsCode-only evaluator slice: Bind now covers the remaining L1 behavior, keeps failures typed through EvalError/EvalFrameError, and tests stack restoration on success and diagnostics.
✅ No blocking concerns for this Bind callable-entry implementation.
|
Review metadata
Verdict: APPROVE Diff is narrowly scoped to making |
Summary
Implements the PR-E Bind/callable-entry evaluator prerequisite inside the existing Rust evaluator surface.
Behavior::Bindthrougheval_nodeeval_bindfor bounded body-entry evaluation throughBindNode.valueBindNode.paramsfrom caller-visible frames into a fresh callable frame before evaluating the body portValidation
cargo fmt --all --checkRUST_MIN_STACK=33554432 RUSTC_WRAPPER= cargo test -p v3-compiler --lib evaluator::testsRUST_MIN_STACK=33554432 RUSTC_WRAPPER= cargo clippy -p v3-compiler --lib -- -D warningsRUST_MIN_STACK=33554432 RUSTC_WRAPPER= cargo test -p v3-compiler --libNote: this checkout's inline
v3-compilerlib test binary overflows the default Rust test thread stack even on unchanged evaluator frame-helper tests, so the local lib/evaluator test runs usedRUST_MIN_STACK=33554432.