Repository navigation
Deployment risk D2 layer 4: remaining srv1 pins resolve through the prod-role holder - #13726
Merged
Merged
Conversation
…n unset (no srv1-live default) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…; annotations describe current behavior Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ows the broker host Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Author
|
Addressed review 78614's soft point: the comment on |
Contributor
Author
|
Re review 78615: agreed it is a citation nit, not a stall. The trigger is the capability (an entry takes the instance its deployment names) and the replacement is a modeled admission row; the PR reference only points at the frontier A census in the body. No code change. — sent from valiant-gull-69 |
…ated realization Both role-following paths read the raw resolver; an unactuatable holder (public roster, no desired row) would have been charged and authorized. They now consume prod_role_actuated_realization, via the new one-authority approval_broker_host(). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deployment-risk D2 layer 4 — one environment model, remaining srv1 pins
Layer 1 (#13688) made
gunbc.deployment_risk prod_role_selectionthe one switch andgunbc.roadmap_dashboard_instance prod_role_realizationits resolver. This PR moves the pins that decide placement or identity by the literal hostsrv1onto that authority. Role-following production readers consume layer 1's actuated join,gunbc.live_deploy.desired prod_role_actuated_realization(), so a selected holder with nodesired_deployment_roster()row refuses. The*_underfunctions remain pure folds over a supplied realization, for controls. No new switch, no new nickname.Changed (each with a consumer in this diff)
gunbc.roadmap_belt_actuate):belt_dispatch_instance_clino longer defaults an unset/blankGUNBC_BELT_INSTANCE_IDto srv1-live; it refuses before anything stages. Names resolve throughdashboard_instance_for_id(the roster), not hand-listed constructors. Stale annotations rewritten: parent's srv1 receipt (2026-10-11 ~05:45Z) shows no unit referencesbelt_dispatch_node_cli/GUNBC_BELT_NODE_ID/GUNBC_BELT_INSTANCE_ID, no Node roadmap server runs, and the only listeners are native gunbc on 127.0.0.1:8080 and :8085.gunbc.live_deploy.served_slice_charge):served_deployment_placement()consumesprod_role_actuated_realization()and follows the actuated holder's host. A refused or unactuatable realization refuses the charge (ServedDeploymentClaimUnmeasured), never srv1, never Unplaced.gunbc.auth.approval_keyring_converge): the host check and ssh target are the approval broker host. A new zero-argumentgunbc.auth.approval_broker_placement approval_broker_host()(=approval_broker_host_under(realization: prod_role_actuated_realization())) is the one production authority for where the broker lives.approval_keyring_converge_wetconsumes it, and the keyring functions take the resolvedApprovalBrokerHost. A refused or unactuatable realization refuses the run on every host.Divergence stated (DESIGN 3b)
belt_dispatch_admitted_instance_idsis a two-id list (srv2-deploy, srv1-live), not a roster row:DashboardActuatingalso admits the srv1 lab and macbook-local, so the roster cannot say "belt-admitted". Modeling that is a frontier.Declared frontier A — entry wrappers still calling
srv1_live_dashboard_instance()(38 sites)Trigger: an entry takes the instance its deployment names.
roadmap_belt_actuate(16),roadmap_serve(10),roadmap_dispatch_actuator(5),roadmap_dashboard_instance_apply(2, lab peer, bright-moth-475),roadmap_launch_deployment_cli(1),dispatch_preflight(1),dispatch_selection(1 — handled by #13720, not duplicated).Left as host facts (reason)
runner_host_grants,fleet_converge_plan(_cli)name the srv1 RUNNER host, not prod.session_residency,session_reservation_policy) are facts about the host.Deferred to a follow-up PR (
valiant-gull-69/d2-l4b)Dark-install (
apply.dag approval_broker_dark_install_srv1_wet) and itsci_spectarget, thedeployment_spec_srv1uses in live_deploydesired/apply/readiness, and theroadmap_launch_deployment_cliprod pins. Reason: they sit in files layer 2 (#13723) edits, and #13723 is held to land together with layer 3 (host self-report). They follow on a fresh branch after layers 2+3 land.Evidence
Remote claim_batch, all PASS: belt selection 5/5 (REDs: unset, blank, unadmitted spelling, lab-roster id), slice charge 4/4 (including moving the role off srv1, the real route, and
an_unactuatable_holder_is_never_charged), keyring 12/12 (held-by-srv1, held-by-srv2, NoProdRole, andan_unactuatable_holder_refuses_the_keyring_converge_on_every_host). The two unactuatable-holder controls use srv2-preview (in the public instance roster, no desired row) through the real joined routeprod_role_actuated_realization_in. Read-only drift gate exit 0 on head 623a87c; witnesses run 38127000341 on this head. Pre-existing red also failing on origin/main:host_allocation_conservation_test the_shakedown_charge_separates_conserves_from_oversubscribed.Known unexecuted
No live srv1 step. Holder/broker host equals srv1 under the current selection by claim only. Out-of-tree callers relying on the old belt default now meet a refusal.
🤖 Generated with Claude Code