Repository navigation
Foreign lexers (Rust bare +, TS single-quoted) and quoted-key brace claim (re-derives #13426, #13642) - #13700
Closed
gunbai-bot[bot] wants to merge 3 commits into
Closed
gunbai-bot[bot] wants to merge 3 commits into
gunbai-bot[bot] wants to merge 3 commits into
Conversation
Contributor
Author
|
Merged main into the branch (head 5a2e8e1) to resolve a conflict in the quoted-key failure-mode row: took this branch's measured version over the superseded 'NOT ESTABLISHED' text. The instrument exits in the body (self-host 0, v2-native-cli 0) were taken at 0825354; the merge brings in main's docs/hygiene changes only and touches no compiler source here, so I have not re-run them at the merge head. — sent from royal-owl-365 |
Contributor
Author
|
Superseded by #13760 (same change, reopened from an id-free branch, refreshed onto main). — sent from royal-owl-365 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-derives gunbc#13426 (foreign lexers) and gunbc#13642 (quoted-key brace) on current main. The old heads are history only, neither is a base. The two changes are small and sit on one branch; the first commit is the lexers, the second the brace.
What changed
+(src/v2/extdeps/languages/rust.dag): arust_lex_rulerow for+. Ingest grammar rows only; the fold is untouched (DESIGN 4).src/v2/extdeps/languages/typescript.dag): the single-quoted rule's body had reused the double-quoted char class and consumed the closing quote, so every single-quoted string refused. The body now excludes the quote.rust_ingest_lexer_missing_a_bare_operator_spelling,ts_single_quoted_string_body_reuses_the_double_quoted_char_class, and two related lexer rows.+parse claim and a TypeScript claim that'On'is onestring_littoken (the red-first control).anonymous_record_test.dag):ar_a_quoted_key_is_not_a_record_field_holdsnow asserts the resolve map-arm refusal, and body lowering accepts. The old claim asserted the wrong layer. The failure-mode row is updated.Receipts
gunbc test //gunbc/instruments:self-hostexit 0 and//gunbc/instruments:v2-native-cliexit 0 at head 0825354. The seed was built from this head.claim_ts_type_alias_minimal_parses_holds.Not carried over
Nothing deliberately dropped from either old PR beyond superseded wording.
🤖 Generated with Claude Code
Handoff (successor can continue from origin alone)
State: head 5a2e8e1, NOT yet refreshed onto main (7+ commits behind incl. seed and mirror changes). Known pre-existing red: claim_ts_type_alias_minimal_parses_holds. Next: merge main once (merge commit), rebuild seed, regen mirrors to fixed point, rerun claims (claim_batch --source-root dag --source-root src/v2) and both instruments on srv1, fresh review, packet. Lands after #13691.