Repository navigation
Move the bottom seam to std.error_primitives (re-derives #13399) - #13686
Merged
Merged
Conversation
pure_dag_seam_unreachable and its _float/_string projections leave std.bytes for the leaf std.error_primitives; all 7 importers re-pointed, std.algebra trim names the seam instead of an unnamed 1 / 0, seed mirrors name the new module. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Author
|
Instrument receipts (run in the session container, which has no systemd-run; cgroup memory.max is 24 GiB and the gunbc test memory envelope was enforced by the runner): |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…bove the fn) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…t_generation_equal=true) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-derives the seam of closed #13399 on current main; the old head is history, not a base.
What
pure_dag_seam_unreachableand its_float/_stringprojections leavestd.bytesforstd.error_primitives(the leaf: imports nothing, already imported bystd.algebra). Instd.bytesthe seam sat abovestd.types -> std.algebra, sostd.algebracould not name it andtrimspelled bottom as an unnamedfrom_code_point(1 / 0).Delete-first: the three fns are removed from
std.bytes(nothing re-exported them), then every importer re-pointed:std.encoding,std.decimal,gunbc.auth.approval_device_wire,gunbc.auth.oidc_id_token_verification,extdeps.languages.gpu.wgsl.kernel,extdeps.languages.simd.kernel,extdeps.cloud.gcp.secret_manager(enumerated by grep overdag/andsrc/; none outsidedag/).std.algebra trimnow diverges through the named seam. Seed mirrors (v1 maintenance, serves the v2 self-host):std.primitive_projectionrowmodule_path, runtime/v1_rt/interpreter panic text, and the generatedv1_compiler_runtime_rust.rstext.Not carried over
The
from_code_point/std.unicode.scalar/ recurring-failure-mode /src/v2witness edits in #13399: they belonged to the stacked #13381, not to the seam.Evidence
claim_batchon a seed built from this branch,dag/test/claim/error_primitives_bottom_seam_test.dag:PASS bottom_seam_projections_resolve_from_error_primitives,PASS trim_still_routes_to_the_host_realization. A bad import path (std.bytes) refuses at resolve, which is the discriminating red.gunbc test //gunbc/instruments:self-hostexit 0 andgunbc test //gunbc/instruments:v2-native-cliexit 0. (Run on the tree stacked with item 2, whose diff touches nosrc/v1;origin/mainbaseline self-host also exit 0.)Correction to the first push
The first head broke the required gate:
std.error_primitivessits belowstd.primitive_projectionin the import graph (projection -> decl_ref -> types -> algebra -> error_primitives), so no closure of it contains the roster, its self-call never resolves to the bridge, and the emitted crate failedfunction cannot return without recursing @ std_error_primitives.rs. Root fix at the emitter's owner:emit_fn_def(src/v1/05_emit_rust.dag) emits a NULLARY realized seam as its ownv1_rt::<bridge>()call (it already reads the roster directly viarust_host_seam_is_realized; a nullary seam has no by-ref/wrap choice). Stage0 mirrors regenerated tofirst_generation_equal=true. Parameterised seams still route through call-target resolution unchanged.🤖 Generated with Claude Code
Refresh 1667581 (2026-10-11): merged origin/main (merge commit); stage0 mirrors regenerated, never taking either side: round 3 reported first_generation_equal=true. self-host exit 0, v2-native-cli exit 0 on this head (container run; srv1 unreachable, no systemd-run).