Repository navigation
Conversation
…del row, pool-drop counterfactual Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…p claims of a parser and a consumer that do not exist Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…e figures in module or doc; drop the production-path pool-drop lever; declare the consumer frontier Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…pt; correct module citation Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ler/regression declared as frontier Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ed Optional<ByteSize> readings; trend rows consumed by the readout Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…adout, seed-growth receipt - writer refuses (exit 2, located) on unreadable rss/peak, trim reading, open or write failure; no fabricated zero - readout: tolerance is structure_count*1024 (KB rounding); the tree<=moment check is deleted, closure-scale measurement declared as the frontier - structure_has_trend_row enumerates the closed coproduct (floor NonFoldResidueRosterDiverged) - gunbc.memory_composition_seed_growth row; receipt regenerated from one run Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…r configuration The cargo-seam arm described a release the seed does not perform. The surviving ender is PoolReleasedBeforeResolution. Every seed-written receipt line carries the configuration cell the reader selects on (pool policy, container scope, run). Co-authored-by: Cursor <cursoragent@cursor.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…the seed moment or during cargo Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…s that configuration The two pool structures now carry that ender. The committed receipt is one instrumented self-host run under pool=released_before_resolution in this container (no cgroup peak). Co-authored-by: Cursor <cursoragent@cursor.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e76d7f5c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // path through this pair is the same computation it was before multi-target routing -- | ||
| // not an equivalent-looking substitute (checked against that function's body, which is | ||
| // exactly that composition). | ||
| pool_acquire::release_whole_tree_after_census(); |
There was a problem hiding this comment.
Every instrumented run clears POOL here before the pre-resolution readback, but memory_composition::release_stages records the pool_heads and pool_content_tokens_newline buckets only after emission. Those rows therefore measure an already-empty or incidentally re-acquired pool—the committed 4 KiB values are not the whole-tree structures named by self_host_step_memory_structures. Record the pool buckets at this release seam before clearing it, or exclude them from the receipt/model.
Useful? React with 👍 / 👎.
| let Some(path) = std::env::var_os("GUNBC_MEMORY_COMPOSITION_RECEIPT") else { | ||
| return; | ||
| }; |
There was a problem hiding this comment.
When GUNBC_MEMORY_COMPOSITION is set but GUNBC_MEMORY_COMPOSITION_RECEIPT is absent, this return silently discards every stage and bucket while the instrument continues successfully and release_stages still drops its structures. This contradicts the writer's fail-closed contract and lets a run appear successful without producing its only measurement; the missing path should invoke refuse just like an open or write failure.
Useful? React with 👍 / 👎.
| hand_authored_declarations: [ | ||
| DeclarationRef { module_path: "v1_compiler.cli_run.memory_composition", decl_name: "readback", field: WholeDeclaration }, | ||
| DeclarationRef { module_path: "v1_compiler.cli_run.memory_composition", decl_name: "release_stages", field: WholeDeclaration }, | ||
| DeclarationRef { module_path: "v1_compiler.cli_run.memory_composition", decl_name: "record_line", field: WholeDeclaration }, | ||
| DeclarationRef { module_path: "v1_compiler.cli_run.memory_composition", decl_name: "record_bucket", field: WholeDeclaration }, | ||
| DeclarationRef { module_path: "v1_compiler.cli_run.memory_composition", decl_name: "configuration_cell", field: WholeDeclaration } |
There was a problem hiding this comment.
This obligation roster omits the newly added enabled, rss_kb, refuse, and stage declarations, and the companion pool justification likewise omits pool_shape and drop_pool_heads_for_measurement. The repository's tools.seed_growth_change_population join enumerates private functions too, so it will report these additions as lacking a SeedGrowthJustification; add declaration references for all six helpers.
Useful? React with 👍 / 👎.
|
Auto-opened by the dashboard from the closing lane's working branch; its head is #13674's head rebased on #13673's (the stacked pair already carries this content as two draft PRs into main via session/keen-crane-875). Closing as a duplicate; review 78422's two findings are carried onto #13674 by comment and fixed there before either PR leaves draft. — sent from smart-gull-336 |
1 participant
Auto-opened by session-dashboard for session
proud-swift-735.Pushing to
session/keen-crane-875-leveradvances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan