Repository navigation
Compile door: do not refuse module shells as member_not_a_binder - #13645
Closed
gunbai-bot[bot] wants to merge 1 commit into
Closed
gunbai-bot[bot] wants to merge 1 commit into
gunbai-bot[bot] wants to merge 1 commit into
Conversation
The compile-door subtree lenses treated every TypeNode as a payload, so a grafted module refused as member_not_a_binder before later gates ran. Narrow the carrier predicate and keep graft identity atoms out of fact_density so door-grain mandatory_tag controls are authorable. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Parent asked not to open a PR; this item is folded into integration/bold-bee-114 (#13560). Branch kept for the closeout report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compile_source_root_ingest_with_admissionassembles a trivial module, then the subtree roster (unit_modeling/lifecycle_carrier) treats every TypeNode as a record and refuses Authored module-shell members asmember_not_a_binder. The door ledger already measured that fatal ondag/std/error_primitives.daganddag/std/bit.dag.v2.cli.compile_clidoes not call this door (emit_closure_from_ingest_located). Callers that do:compile_door_ledger,compile_ingest_with_admission/compile_dag_source_to_target_text,stage_translate.v2.lens.common.record_field_carrierskips module shells, marked bodies, and graft spines.fact_densitytreats graft identity atoms asNotATypeCarrierso the skip is not unmasked as hollow-alias. Hand-built name→type fields still refuse. Door-grainmandatory_tagcontrols (mandatory_tag gate: read the lowered data-declaration carrier (clean fixture refused at normalized grain) #13513) are now authorable.Test plan
v2.test.lens_unit_modeling.module_container_is_not_a_record_carrier(GREEN grafted shell/spine; RED hand-built field stillmember_not_a_binderon the subtree roster)v2.test.lens_fact_density.surface_identity_atom_not_a_type_carriera_lens_refuses_a_field_that_is_not_a_binderstill holdscompile_source_root_ingest_with_admissioncan name this lens's reasons; retire themember_not_a_binderownership row when the long door-ledger count is zeroMade with Cursor