Repository navigation
XL-2 PR2b: finish #13430 string templates - #13638
gunbai-bot[bot] wants to merge 25 commits into
Conversation
… modes Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… driver Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…rc/v2 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…serts the hole's byte range Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… not reproduced) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…e, v2.std.grammar Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… they append (no duplicated minted occurrence); red control follows the projected cause to the hole Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ster delta is measured by the census; gunbc#13126 holds the zero-count floor claim) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…owering; ONE real-path claim (lexer->parse->normalize->infer) is the located Int-hole red control Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…s (assemble_program_from_ingest_located): no second parse Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…fuse unreadable part sequences, emit keeps head/middle adjacent to the hole, generated concat bound to the roster row's declaring path Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…eed job) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… std.optional re-home Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… the extra-assembly unbound-hole claim (one real-path claim) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Duplicate of #13430 (same 1107-line change from the archived predecessor). Superseded; branch kept. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 27e3b1890a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| node_with_occurrence_id( | ||
| kind: ComputationNode { behavior: Transform }, | ||
| children: [ | ||
| Edge { label: Positional, target: node_with_occurrence_id(kind: TypeNode { connective: Atom { identity: ^collection_concat_shape } }, children: [], occurrence_id: occurrence) }, |
There was a problem hiding this comment.
When a module declares or imports a value named collection_concat_shape, this generated bare atom is captured by that binding: resolve_atom_not_string_literal checks lexical/root bindings and resolve_atom_unscoped checks the symbol index before the roster-by-declaration fallback. Consequently, a template such as "a{x}" can call the user's function (or fail against its type) instead of the concat primitive. Construct an already-bound reference to std.algebra.collection_concat_shape, rather than resolving this internal operator by an ordinary source-visible name.
Useful? React with 👍 / 👎.
Auto-opened by session-dashboard for session
silent-fox-272.Pushing to
session/silent-fox-272advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan